d8acd8ca2a
This changes all the puppet 3 validate_* functions to use the validate_legacy function. The validate_legacy function has been available since about three years but require Puppet >= 4.4.0 and since there is Puppet 4.10.12 as latest we should assume people are running a fairly new Puppet 4 version. This is the first step to then remove all validate function calls and use proper types for parameter as described in spec [1]. [1] https://review.openstack.org/#/c/568929/ Change-Id: Iaa929ff3f95e930af23a32a14ee81bb4971af3a5
61 lines
1.7 KiB
Ruby
61 lines
1.7 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe 'manila::backend::hitachi_hnas' do
|
|
|
|
let(:title) {'myhitachinas'}
|
|
|
|
let :params do
|
|
{
|
|
:driver_handles_share_servers => false,
|
|
:hitachi_hnas_ip => '172.24.44.15',
|
|
:hitachi_hnas_username => 'supervisor',
|
|
:hitachi_hnas_password => 'supervisor',
|
|
:hitachi_hnas_evs_id => '1',
|
|
:hitachi_hnas_evs_ip => ' 172.24.53.1',
|
|
:hitachi_hnas_file_system_name => 'FS-Manila',
|
|
}
|
|
end
|
|
|
|
shared_examples_for 'hitachi hnas share driver' do
|
|
it 'configures hitachi nas share driver' do
|
|
is_expected.to contain_manila_config("myhitachinas/share_driver").with_value(
|
|
'manila.share.drivers.hitachi.hds_hnas.HDSHNASDriver')
|
|
params.each_pair do |config,value|
|
|
is_expected.to contain_manila_config("myhitachinas/#{config}").with_value( value )
|
|
end
|
|
end
|
|
|
|
it 'marks hitachi_hnas_password as secret' do
|
|
is_expected.to contain_manila_config("myhitachinas/hitachi_hnas_password").with_secret( true )
|
|
end
|
|
end
|
|
|
|
shared_examples 'manila::backend::hitachi_hnas' do
|
|
context 'with provided parameters' do
|
|
it_configures 'hitachi hnas share driver'
|
|
end
|
|
|
|
context 'with share server config' do
|
|
before do
|
|
params.merge!({
|
|
:hitachi_hnas_password => true,
|
|
})
|
|
end
|
|
|
|
it { is_expected.to raise_error(Puppet::Error) }
|
|
end
|
|
end
|
|
|
|
on_supported_os({
|
|
:supported_os => OSDefaults.get_supported_os
|
|
}).each do |os,facts|
|
|
context "on #{os}" do
|
|
let (:facts) do
|
|
facts.merge!(OSDefaults.get_facts())
|
|
end
|
|
|
|
it_behaves_like 'manila::backend::hitachi_hnas'
|
|
end
|
|
end
|
|
end
|