From dddb501f86fca8c9905c35bc9c9d032673d4f887 Mon Sep 17 00:00:00 2001 From: Tobias Urdin Date: Thu, 17 Jan 2019 21:42:38 +0100 Subject: [PATCH] Inherit pyvers from openstacklib::defaults Change-Id: I64fd0792e00fcb21c81cce879475c8986a6c2f7e --- manifests/params.pp | 8 +------- spec/classes/mistral_client_spec.rb | 6 +----- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/manifests/params.pp b/manifests/params.pp index 417e7b4..ea85e65 100644 --- a/manifests/params.pp +++ b/manifests/params.pp @@ -4,13 +4,7 @@ # class mistral::params { include ::openstacklib::defaults - - if ($::os_package_type == 'debian') or ($::os['name'] == 'Fedora') or - ($::os['family'] == 'RedHat' and Integer.new($::os['release']['major']) > 7) { - $pyvers = '3' - } else { - $pyvers = '' - } + $pyvers = $::openstacklib::defaults::pyvers $client_package = "python${pyvers}-mistralclient" $db_sync_command = 'mistral-db-manage --config-file=/etc/mistral/mistral.conf upgrade head' diff --git a/spec/classes/mistral_client_spec.rb b/spec/classes/mistral_client_spec.rb index 60e79a7..64896a4 100644 --- a/spec/classes/mistral_client_spec.rb +++ b/spec/classes/mistral_client_spec.rb @@ -27,11 +27,7 @@ describe 'mistral::client' do let(:platform_params) do case facts[:osfamily] when 'Debian' - if facts[:os_package_type] == 'debian' - { :client_package => 'python3-mistralclient' } - else - { :client_package => 'python-mistralclient' } - end + { :client_package => 'python3-mistralclient' } when 'RedHat' { :client_package => 'python-mistralclient' } end