Remove broken checks from providers

The latest python-neutronclient doesn't show confirmation messages anymore,
errors will be caught anyway as the client will return non-zero code

Change-Id: Id291e158f7181adede1c3876b412132a63188f83

lib/puppet/provider/neutron_network/neutron.rb

@@ -102,7 +102,6 @@ Puppet::Type.type(:neutron_network).provide(
     results = auth_neutron('net-create', '--format=shell',
                            network_opts, resource[:name])
 
-    if results =~ /Created a new network:/
     attrs = self.class.parse_creation_output(results)
     @property_hash = {
       :ensure                    => :present,
@@ -116,9 +115,6 @@ Puppet::Type.type(:neutron_network).provide(
       :shared                    => attrs['shared'],
       :tenant_id                 => attrs['tenant_id'],
     }
-    else
-      fail("did not get expected message on network creation, got #{results}")
-    end
   end
 
   def destroy

lib/puppet/provider/neutron_port/neutron.rb

@@ -88,7 +88,6 @@ Puppet::Type.type(:neutron_port).provide(
       resource[:network_name]
     )
 
-    if results =~ /Created a new port:/
     attrs = self.class.parse_creation_output(results)
     @property_hash = {
       :ensure         => :present,
@@ -103,9 +102,6 @@ Puppet::Type.type(:neutron_port).provide(
       :subnet_id      => self.class.parse_subnet_id(attrs["fixed_ips"]),
       :ip_address     => self.class.parse_ip_address(attrs["fixed_ips"])
     }
-    else
-      fail("did not get expected message on port creation, got #{results}")
-    end
   end
 
   def destroy

lib/puppet/provider/neutron_router/neutron.rb

@@ -86,7 +86,6 @@ Puppet::Type.type(:neutron_router).provide(
     results = auth_neutron("router-create", '--format=shell',
                            opts, resource[:name])
 
-    if results =~ /Created a new router:/
     attrs = self.class.parse_creation_output(results)
     @property_hash = {
       :ensure                    => :present,
@@ -102,20 +101,10 @@ Puppet::Type.type(:neutron_router).provide(
       results = auth_neutron('router-gateway-set',
                              @resource[:name],
                              @resource[:gateway_network_name])
-        if results =~ /Set gateway for router/
       attrs = self.class.get_neutron_resource_attrs('router',
                                                     @resource[:name])
       @property_hash[:external_gateway_info] = \
         attrs['external_gateway_info']
-        else
-          fail(<<-EOT
-did not get expected message on setting router gateway, got #{results}
-EOT
-               )
-        end
-      end
-    else
-      fail("did not get expected message on router creation, got #{results}")
     end
   end
 

lib/puppet/provider/neutron_router_interface/neutron.rb

@@ -67,14 +67,10 @@ Puppet::Type.type(:neutron_router_interface).provide(
     end
     results = auth_neutron(args)
 
-    if results =~ /Added interface.* to router/
     @property_hash = {
       :ensure => :present,
       :name   => resource[:name],
     }
-    else
-      fail("did not get expected message on interface addition, got #{results}")
-    end
   end
 
   def router_name

lib/puppet/provider/neutron_subnet/neutron.rb

@@ -168,7 +168,6 @@ Puppet::Type.type(:neutron_subnet).provide(
     results = auth_neutron('subnet-create', '--format=shell',
                            opts, resource[:cidr])
 
-    if results =~ /Created a new subnet:/
     attrs = self.class.parse_creation_output(results)
     @property_hash = {
       :ensure                    => :present,
@@ -186,9 +185,6 @@ Puppet::Type.type(:neutron_subnet).provide(
       :network_id                => attrs['network_id'],
       :tenant_id                 => attrs['tenant_id'],
     }
-    else
-      fail("did not get expected message on subnet creation, got #{results}")
-    end
   end
 
   def destroy