openstack/puppet-neutron
Code Issues Proposed changes

designate region_name param

Browse Source 
The class neutron::designate didn't have a region_name parameter.
In our deployment, this was an issue we had to fix.

Change-Id: Ifde81be654ca73cb88515804b38a6e053f1409ac
This commit is contained in:
Thomas Goirand 2024-12-02 12:12:55 +01:00
parent 8b91541f2a
commit 1d5702d273
3 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
manifests/designate.pp
View File

@ -50,6 +50,10 @@
# (optional) Required if identity server requires client certificate # (optional) Required if identity server requires client certificate
# Defaults to $facts['os_service_default']. # Defaults to $facts['os_service_default'].
# #
# [*region_name*]
# (Optional) The region of the Designate service.
# Defaults to $facts['os_service_default'].
#
# [*allow_reverse_dns_lookup*] # [*allow_reverse_dns_lookup*]
# (optional) Enable or not the creation of reverse lookup (PTR) records. # (optional) Enable or not the creation of reverse lookup (PTR) records.
# Defaults to $facts['os_service_default']. # Defaults to $facts['os_service_default'].
@ -78,6 +82,7 @@ class neutron::designate (
$auth_url = 'http://127.0.0.1:5000', $auth_url = 'http://127.0.0.1:5000',
$cafile = $facts['os_service_default'], $cafile = $facts['os_service_default'],
$certfile = $facts['os_service_default'], $certfile = $facts['os_service_default'],
$region_name = $facts['os_service_default'],
$allow_reverse_dns_lookup = $facts['os_service_default'], $allow_reverse_dns_lookup = $facts['os_service_default'],
$ipv4_ptr_zone_prefix_size = $facts['os_service_default'], $ipv4_ptr_zone_prefix_size = $facts['os_service_default'],
$ipv6_ptr_zone_prefix_size = $facts['os_service_default'], $ipv6_ptr_zone_prefix_size = $facts['os_service_default'],
@ -107,6 +112,7 @@ class neutron::designate (
'designate/auth_url': value => $auth_url; 'designate/auth_url': value => $auth_url;
'designate/cafile': value => $cafile; 'designate/cafile': value => $cafile;
'designate/certfile': value => $certfile; 'designate/certfile': value => $certfile;
'designate/region_name': value => $region_name;
'designate/allow_reverse_dns_lookup': value => $allow_reverse_dns_lookup; 'designate/allow_reverse_dns_lookup': value => $allow_reverse_dns_lookup;
'designate/ipv4_ptr_zone_prefix_size': value => $ipv4_ptr_zone_prefix_size; 'designate/ipv4_ptr_zone_prefix_size': value => $ipv4_ptr_zone_prefix_size;
'designate/ipv6_ptr_zone_prefix_size': value => $ipv6_ptr_zone_prefix_size; 'designate/ipv6_ptr_zone_prefix_size': value => $ipv6_ptr_zone_prefix_size;

4
releasenotes/notes/designate-region-name-102d02ddc000de3f.yaml Normal file
View File

@ -0,0 +1,4 @@
---
features:
- |
The ``neutron::designate`` class now has a new ``region_name`` parameter.

3
spec/classes/neutron_designate_spec.rb
View File

@ -25,6 +25,7 @@ describe 'neutron::designate' do
should contain_neutron_config('designate/auth_url').with_value('http://127.0.0.1:5000') should contain_neutron_config('designate/auth_url').with_value('http://127.0.0.1:5000')
should contain_neutron_config('designate/cafile').with_value('<SERVICE DEFAULT>') should contain_neutron_config('designate/cafile').with_value('<SERVICE DEFAULT>')
should contain_neutron_config('designate/certfile').with_value('<SERVICE DEFAULT>') should contain_neutron_config('designate/certfile').with_value('<SERVICE DEFAULT>')
should contain_neutron_config('designate/region_name').with_value('<SERVICE DEFAULT>')
should contain_neutron_config('designate/allow_reverse_dns_lookup').with_value('<SERVICE DEFAULT>') should contain_neutron_config('designate/allow_reverse_dns_lookup').with_value('<SERVICE DEFAULT>')
should contain_neutron_config('designate/ipv4_ptr_zone_prefix_size').with_value('<SERVICE DEFAULT>') should contain_neutron_config('designate/ipv4_ptr_zone_prefix_size').with_value('<SERVICE DEFAULT>')
should contain_neutron_config('designate/ipv6_ptr_zone_prefix_size').with_value('<SERVICE DEFAULT>') should contain_neutron_config('designate/ipv6_ptr_zone_prefix_size').with_value('<SERVICE DEFAULT>')
@ -43,6 +44,7 @@ describe 'neutron::designate' do
:auth_url => 'http://localhost:5000', :auth_url => 'http://localhost:5000',
:cafile => '/path/to/cafile', :cafile => '/path/to/cafile',
:certfile => '/path/to/certfile', :certfile => '/path/to/certfile',
:region_name => 'region2',
:allow_reverse_dns_lookup => false, :allow_reverse_dns_lookup => false,
:ipv4_ptr_zone_prefix_size => 765, :ipv4_ptr_zone_prefix_size => 765,
:ipv6_ptr_zone_prefix_size => 876, :ipv6_ptr_zone_prefix_size => 876,
@ -63,6 +65,7 @@ describe 'neutron::designate' do
should contain_neutron_config('designate/auth_url').with_value('http://localhost:5000') should contain_neutron_config('designate/auth_url').with_value('http://localhost:5000')
should contain_neutron_config('designate/cafile').with_value('/path/to/cafile') should contain_neutron_config('designate/cafile').with_value('/path/to/cafile')
should contain_neutron_config('designate/certfile').with_value('/path/to/certfile') should contain_neutron_config('designate/certfile').with_value('/path/to/certfile')
should contain_neutron_config('designate/region_name').with_value('region2')
should contain_neutron_config('designate/allow_reverse_dns_lookup').with_value(false) should contain_neutron_config('designate/allow_reverse_dns_lookup').with_value(false)
should contain_neutron_config('designate/ipv4_ptr_zone_prefix_size').with_value(765) should contain_neutron_config('designate/ipv4_ptr_zone_prefix_size').with_value(765)
should contain_neutron_config('designate/ipv6_ptr_zone_prefix_size').with_value(876) should contain_neutron_config('designate/ipv6_ptr_zone_prefix_size').with_value(876)