Fix typos in parameter descriptions and tests

Change-Id: I72d4b0fde29e4313d297b9b6e55fea7a9ce0d847

lib/puppet/provider/neutron_router_interface/openstack.rb

@@ -13,7 +13,7 @@ Puppet::Type.type(:neutron_router_interface).provide(
     It is not possible to manage an interface for the subnet used by
     the gateway network, and such an interface will appear in the list
     of resources ('puppet resource [type]').  Attempting to manage the
-    gateway interfae will result in an error.
+    gateway interface will result in an error.
   EOT
 
   @credentials = Puppet::Provider::Openstack::CredentialsV3.new

manifests/agents/ml2/mlnx.pp

@@ -119,7 +119,7 @@ class neutron::agents::ml2::mlnx (
     #                 neutron::plugins::ml2::mellanox
     Package<| title == $mlnx_agent_package |> { tag +> 'neutron-package' }
 
-    # NOTE(tkajinam): Ubuntu/Debuan requires a separate package for eswitchd
+    # NOTE(tkajinam): Ubuntu/Debian requires a separate package for eswitchd
     #                 service.
     if $eswitchd_package {
       ensure_packages($eswitchd_package, {

manifests/agents/ml2/ovs.pp

@@ -57,7 +57,7 @@
 #
 # [*of_inactivity_probe*]
 #   (Optional) The inactivity_probe interval in second for the local switch
-#   connnection to the controller. A value of 0 disables inactivity probes.
+#   connection to the controller. A value of 0 disables inactivity probes.
 #   Defaults to $::os_service_default
 #
 # [*integration_bridge*]
@@ -104,7 +104,7 @@
 #
 # [*arp_responder*]
 #   (optional) Enable or not the ARP responder.
-#   Recommanded when using l2 population mechanism driver.
+#   Recommended when using l2 population mechanism driver.
 #   Defaults to $::os_service_default
 #
 # [*firewall_driver*]
@@ -205,13 +205,13 @@
 #
 # [*resource_provider_packet_processing_without_direction*]
 #   (optional) List of <hypervisor>:<packet_rate> tuples, defining the minimum
-#   pachet rate the OVS backend can guarantee in kilo (1000) packet per second.
+#   packet rate the OVS backend can guarantee in kilo (1000) packet per second.
 #   Defaults to empty list
 #
 # [*resource_provider_packet_processing_with_direction*]
 #   (optional) Similar to resource_provider_packet_processing_without_direction
 #   but used in case the OVS backend has hardware offload capabilities.
-#   Defauls to empty list
+#   Defaults to empty list
 #
 # [*resource_provider_default_hypervisor*]
 #   (optional) The default hypervisor name used to locate the parent of
@@ -221,12 +221,12 @@
 # [*resource_provider_inventory_defaults*]
 #   (optional) Key:value pairs to specify defaults used while reporting packet
 #   rate inventories,.
-#   Defauls to empty hash
+#   Defaults to empty hash
 #
 # [*resource_provider_packet_processing_inventory_defaults*]
 #   (optional) Key:value pairs to specify defaults used while reporting packet
 #   rate inventories,.
-#   Defauls to empty hash
+#   Defaults to empty hash
 #
 # [*explicitly_egress_direct*]
 #  (optional) When set to True, the accepted egress unicast traffic will not

manifests/agents/ml2/sriov.pp

@@ -75,7 +75,7 @@
 # [*number_of_vfs*]
 #   (optional) List of <physical_network>:<number_of_vfs> specifying the number
 #   VFs to be exposed per physical interface.
-#   For example, to configure two inteface with number of VFs, specify
+#   For example, to configure two interface with number of VFs, specify
 #   it as "eth1:4,eth2:10"
 #   Defaults to $::os_service_default.
 #
@@ -95,7 +95,7 @@
 # [*resource_provider_inventory_defaults*]
 #   (optional) Key:value pairs to specify defaults used while reporting packet
 #   rate inventories,.
-#   Defauls to empty hash
+#   Defaults to empty hash
 #
 class neutron::agents::ml2::sriov (
   $package_ensure                       = 'present',

manifests/cache.pp

@@ -108,7 +108,7 @@
 #   Defaults to true
 #
 # [*tls_enabled*]
-#   (Optional) Global toggle for TLS usage when comunicating with
+#   (Optional) Global toggle for TLS usage when communicating with
 #   the caching servers.
 #   Default to $::os_service_default
 #
@@ -128,7 +128,7 @@
 #
 # [*tls_keyfile*]
 #   (Optional) Path to a single file containing the client's private
-#   key in. Otherwhise the private key will be taken from the file
+#   key in. Otherwise the private key will be taken from the file
 #   specified in tls_certfile. If tls_enabled is False, this option
 #   is ignored.
 #   Default to $::os_service_default
@@ -144,7 +144,7 @@
 #   (Optional) Enable retry client mechanisms to handle failure.
 #   Those mechanisms can be used to wrap all kind of pymemcache
 #   clients. The wrapper allows you to define how many attempts
-#   to make and how long to wait between attemots.
+#   to make and how long to wait between attempts.
 #   Default to $::os_service_default
 #
 # [*retry_attempts*]

manifests/config.pp

@@ -87,7 +87,7 @@
 # [*plugin_nsx_config*]
 #   (optional) Manage configuration of plugins/vmware/nsx.ini
 #
-# DEPRECATED PRAMETERS
+# DEPRECATED PARAMETERS
 #
 # [*plugin_nvp_config*]
 #   (optional) Manage configuration of /etc/neutron/plugins/nicira/nvp.ini

manifests/deps.pp

@@ -71,7 +71,7 @@ class neutron::deps {
   # Support packages need to be installed in the install phase, but we don't
   # put them in the chain above because we don't want any false dependencies
   # between packages with the neutron-package tag and the neutron-support-package
-  # tag.  Note: the package resources here will have a 'before' relationshop on
+  # tag.  Note: the package resources here will have a 'before' relationship on
   # the neutron::install::end anchor.  The line between neutron-support-package and
   # neutron-package should be whether or not neutron services would need to be
   # restarted if the package state was changed.
@@ -80,7 +80,7 @@ class neutron::deps {
   -> Anchor['neutron::install::end']
 
   # ml2 plugin packages should be install after we start actual configuration,
-  # because the configuraiton for ml2 plugin base should be applied before
+  # because the configuration for ml2 plugin base should be applied before
   # ml2 plugin packages are installed
   Anchor['neutron::install::begin']
   -> Package<| tag == 'neutron-plugin-ml2-package'|>

manifests/healthcheck.pp

@@ -14,12 +14,12 @@
 #   Defaults to $::os_service_default
 #
 # [*disable_by_file_path*]
-#   (Optional) Check the presense of a file to determine if an application
+#   (Optional) Check the presence of a file to determine if an application
 #   is running on a port.
 #   Defaults to $::os_service_default
 #
 # [*disable_by_file_paths*]
-#   (Optional) Check the presense of a file to determine if an application
+#   (Optional) Check the presence of a file to determine if an application
 #   is running on a port. Expects a "port:path" list of strings.
 #   Defaults to $::os_service_default
 #

manifests/init.pp

@@ -172,12 +172,12 @@
 # [*kombu_reconnect_delay*]
 #   (optional) The amount of time to wait before attempting to reconnect
 #   to MQ provider. This is used in some cases where you may need to wait
-#   for the provider to propery premote the master before attempting to
+#   for the provider to properly promote the master before attempting to
 #   reconnect. See https://review.opendev.org/#/c/76686
 #   Defaults to $::os_service_default
 #
 # [*kombu_missing_consumer_retry_timeout*]
-#   (Optional) How long to wait a missing client beforce abandoning to send it
+#   (Optional) How long to wait a missing client before abandoning to send it
 #   its replies. This value should not be longer than rpc_response_timeout.
 #   (integer value)
 #   Defaults to $::os_service_default
@@ -190,7 +190,7 @@
 #
 # [*kombu_compression*]
 #   (optional) Possible values are: gzip, bz2. If not set compression will not
-#   be used. This option may notbe available in future versions. EXPERIMENTAL.
+#   be used. This option may not be available in future versions. EXPERIMENTAL.
 #   (string value)
 #   Defaults to $::os_service_default
 #
@@ -255,11 +255,11 @@
 #   Defaults to $::os_service_default.
 #
 # [*use_ssl*]
-#   (optinal) Enable SSL on the API server
+#   (optional) Enable SSL on the API server
 #   Defaults to $::os_service_default
 #
 # [*cert_file*]
-#   (optinal) certificate file to use when starting api server securely
+#   (optional) certificate file to use when starting api server securely
 #   defaults to $::os_service_default
 #
 # [*key_file*]

manifests/keystone/auth.pp

@@ -60,7 +60,7 @@
 #   Defaults to 'RegionOne'.
 #
 # [*public_url*]
-#   (0ptional) The endpoint's public url.
+#   (Optional) The endpoint's public url.
 #   This url should *not* contain any trailing '/'.
 #   Defaults to 'http://127.0.0.1:9696'
 #

manifests/plugins/ml2/cisco/vts.pp

@@ -29,7 +29,7 @@
 # Defaults to $::os_service_default
 #
 # [*vts_retry_count*]
-# (optional) Numer of retries for synchronization with VTS.
+# (optional) Number of retries for synchronization with VTS.
 # Defaults to $::os_service_default
 #
 # [*vts_vmmid*]

manifests/plugins/ml2/mellanox/mlnx_sdn_assist.pp

@@ -31,7 +31,7 @@
 #
 # [*bind_normal_ports_physnets*]
 # (optional) A list of physnets in which binding of normal
-# ports is allowed. This option is used in  conjuction
+# ports is allowed. This option is used in  conjunction
 # with bind_normal_ports.
 # The list must be a subset of physical_networks
 # Defaults to []

manifests/plugins/ml2/ovn.pp

@@ -49,7 +49,7 @@
 #   Defaults to $::os_service_default
 #
 # [*ovsdb_retry_max_interval*]
-#   (optional) Max intervla in seconds between each retry to get the OVN NB
+#   (optional) Max interval in seconds between each retry to get the OVN NB
 #   and SB IDLs.
 #   Defaults to $::os_service_default
 #

manifests/server.pp

@@ -121,7 +121,7 @@
 #   Defaults to $::os_service_default
 #
 # [*dhcp_load_type*]
-#   (Optional) The resource type whos load is being reported by the agent.
+#   (Optional) The resource type whose load is being reported by the agent.
 #   The expected values are either 'networks', 'subnets', 'ports'.
 #   Defaults to $::os_service_default
 #
@@ -405,7 +405,7 @@ class neutron::server (
       } elsif $service_name == 'httpd' {
         fail('Use api_service_name and rpc_service_name to run api service by httpd')
       } else {
-        warning('Support for arbitaly service name is deprecated')
+        warning('Support for arbitrary service name is deprecated')
         # backward compatibility so operators can customize the service name.
         service { 'neutron-server':
           ensure     => $service_ensure,

spec/classes/neutron_agents_l3_spec.rb

@@ -152,7 +152,7 @@ describe 'neutron::agents::l3' do
         params.merge!(:extensions => 'fip_qos,gateway_ip_qos,port_forwarding')
       end
 
-      it 'configures extentions' do
+      it 'configures extensions' do
         should contain_neutron_l3_agent_config('agent/extensions').with_value('fip_qos,gateway_ip_qos,port_forwarding')
       end
     end
@@ -162,7 +162,7 @@ describe 'neutron::agents::l3' do
         params.merge!(:extensions => ['fip_qos', 'gateway_ip_qos', 'port_forwarding'])
       end
 
-      it 'configures extentions' do
+      it 'configures extensions' do
         should contain_neutron_l3_agent_config('agent/extensions').with_value('fip_qos,gateway_ip_qos,port_forwarding')
       end
     end

spec/classes/neutron_agents_ml2_linuxbridge_spec.rb

@@ -68,7 +68,7 @@ describe 'neutron::agents::ml2::linuxbridge' do
         end
       end
 
-      it 'does not configre VXLAN tunneling' do
+      it 'does not configure VXLAN tunneling' do
         should contain_neutron_agent_linuxbridge('vxlan/enable_vxlan').with_value(false)
         should contain_neutron_agent_linuxbridge('vxlan/local_ip').with_ensure('absent')
         should_not contain_neutron_agent_linuxbridge('vxlan/vxlan_group')

spec/classes/neutron_server_notifications_ironic_spec.rb

@@ -58,7 +58,7 @@ describe 'neutron::server::notifications::ironic' do
         )
       end
 
-      it 'should configure neutron server with overrided parameters' do
+      it 'should configure neutron server with overridden parameters' do
         should contain_neutron_config('ironic/auth_type').with_value('password')
         should contain_neutron_config('ironic/user_domain_name').with_value('Default_2')
         should contain_neutron_config('ironic/username').with_value('joe')
@@ -80,7 +80,7 @@ describe 'neutron::server::notifications::ironic' do
         )
       end
 
-      it 'should configure the valid_interfaces parameter with a commma-separated string' do
+      it 'should configure the valid_interfaces parameter with a comma-separated string' do
         should contain_neutron_config('ironic/valid_interfaces').with_value('internal,public')
       end
     end

spec/classes/neutron_server_notifications_nova_spec.rb

@@ -56,7 +56,7 @@ describe 'neutron::server::notifications::nova' do
         )
       end
 
-      it 'should configure neutron server with overrided parameters' do
+      it 'should configure neutron server with overridden parameters' do
         should contain_neutron_config('DEFAULT/notify_nova_on_port_status_changes').with_value(false)
         should contain_neutron_config('DEFAULT/notify_nova_on_port_data_changes').with_value(false)
         should contain_neutron_config('nova/auth_type').with_value('password')

spec/classes/neutron_server_notifications_spec.rb

@@ -40,7 +40,7 @@ describe 'neutron::server::notifications' do
         )
       end
 
-      it 'should configure neutron server with overrided parameters' do
+      it 'should configure neutron server with overridden parameters' do
         should contain_neutron_config('DEFAULT/send_events_interval').with_value('10')
         should contain_neutron_config('DEFAULT/http_retries').with_value(3)
       end

spec/classes/neutron_server_placement_spec.rb

@@ -50,7 +50,7 @@ describe 'neutron::server::placement' do
         )
       end
 
-      it 'should configure neutron server with overrided parameters' do
+      it 'should configure neutron server with overridden parameters' do
         should contain_neutron_config('placement/auth_type').with_value('password')
         should contain_neutron_config('placement/project_domain_name').with_value('Default_2')
         should contain_neutron_config('placement/project_name').with_value('alt_services')

spec/unit/provider/neutron_api_uwsgi_config/ini_setting_spec.rb

@@ -2,7 +2,7 @@
 # these tests are a little concerning b/c they are hacking around the
 # modulepath, so these tests will not catch issues that may eventually arise
 # related to loading these plugins.
-# I could not, for the life of me, figure out how to programatcally set the modulepath
+# I could not, for the life of me, figure out how to programmatically set the modulepath
 require 'spec_helper'
 provider_class = Puppet::Type.type(:neutron_api_uwsgi_config).provider(:ini_setting)
 describe provider_class do