Remove the ovsdb_interface parameter

... because it was deprecated during the Ussuri cycle[1] and has had
no effect since then.

[1] 3568ccf3d7

Change-Id: Ib28b1ffd27db28daf6724193bf2717edbe53526d

manifests/agents/ml2/ovs.pp

@@ -199,13 +199,6 @@
 #  final egress tables direct output flows for unicast traffic. (boolean value)
 #  Defaults to $::os_service_default
 #
-# DEPRECATED
-#
-# [*ovsdb_interface*]
-#   (optional) The interface for interacting with the OVSDB
-#   Allowed values: vsctl, native
-#   Defaults to undef
-#
 class neutron::agents::ml2::ovs (
   $package_ensure                = 'present',
   $enabled                       = true,
@@ -244,8 +237,6 @@ class neutron::agents::ml2::ovs (
   $resource_provider_bandwidths  = [],
   $resource_provider_hypervisors = [],
   $explicitly_egress_direct      = $::os_service_default,
-  # DEPRECATED
-  $ovsdb_interface               = undef,
 ) {
 
   include neutron::deps
@@ -345,15 +336,6 @@ class neutron::agents::ml2::ovs (
     'ovs/resource_provider_hypervisors': value => $resource_provider_hypervisors_real;
   }
 
-  # TODO(tobias.urdin): Remove in V release.
-  if $ovsdb_interface != undef {
-    warning('ovsdb_interface is deprecated and has no effect')
-  }
-  neutron_agent_ovs {
-    'ovs/ovsdb_interface': ensure => absent;
-    'ovs/of_interface': ensure => absent;
-  }
-
   neutron_agent_ovs {
     'agent/polling_interval':               value => $polling_interval;
     'agent/l2_population':                  value => $l2_population;

releasenotes/notes/remove-ovsdb_interface-3d367bcc90efae16.yaml

@@ -0,0 +1,5 @@
+---
+upgrade:
+  - |
+    The ``neutron::agents::ml2::ovs::ovsdb_interface`` parameter has been
+    removed.