openstack/puppet-neutron
Code Issues Proposed changes

Add the ability to configure ovn-remote-probe-interval

Browse Source 
This parameter sets inactive probe interval of the JSON
session from ovn-metadata to the OVN SB database.
By default this it is 5s which not be sufficient in
loaded systems or during high control-plane activity spikes,
leading to unnecessary reconnections to OVSDB server.
Now it is extended by default to 1 min and it
is configurable.

Change-Id: Id2bbddfa664fe3ba43992ab8721ef8117475df94
This commit is contained in:
Flavio Fernandes 2019-11-21 15:47:03 -05:00
parent 2b1d8b6be8
commit c6b3800f7d
3 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
manifests/agents/ovn_metadata.pp
View File

@ -105,7 +105,11 @@
# (optional) Whether to set only the specified config options # (optional) Whether to set only the specified config options
# in the metadata config. # in the metadata config.
# Defaults to false. # Defaults to false.
#
# [*ovn_remote_probe_interval*]
# (optional) Set probe interval, based on user configuration, value is in ms
# Defaults to 60000
#
class neutron::agents::ovn_metadata ( class neutron::agents::ovn_metadata (
$shared_secret, $shared_secret,
$package_ensure = 'present', $package_ensure = 'present',
@ -133,6 +137,7 @@ class neutron::agents::ovn_metadata (
$root_helper_daemon = $::os_service_default, $root_helper_daemon = $::os_service_default,
$state_path = '/var/lib/neutron', $state_path = '/var/lib/neutron',
$purge_config = false, $purge_config = false,
$ovn_remote_probe_interval = $::os_service_default,
) { ) {
include ::neutron::deps include ::neutron::deps
@ -164,6 +169,7 @@ class neutron::agents::ovn_metadata (
'ovn/ovn_sb_private_key': value => $ovn_sb_private_key; 'ovn/ovn_sb_private_key': value => $ovn_sb_private_key;
'ovn/ovn_sb_certificate': value => $ovn_sb_certificate; 'ovn/ovn_sb_certificate': value => $ovn_sb_certificate;
'ovn/ovn_sb_ca_cert': value => $ovn_sb_ca_cert; 'ovn/ovn_sb_ca_cert': value => $ovn_sb_ca_cert;
'ovn/ovn_remote_probe_interval': value => $ovn_remote_probe_interval;
} }
if $::neutron::params::ovn_metadata_agent_package { if $::neutron::params::ovn_metadata_agent_package {

9
releasenotes/notes/ovn_metadata_remote_probe_interval-b46a8a8cb3533276.yaml Normal file
View File

@ -0,0 +1,9 @@
---
features:
- |
This parameter sets inactive probe interval of the JSON session
from ovn-metadata to the OVN SB database. By default this it
is 5s which not be sufficient in loaded systems or during high
control-plane activity spikes, leading to unnecessary reconnections
to OVSDB server. Now it is extended by default to 1 min and it is
configurable by param OVNRemoteProbeInterval.

1
spec/classes/neutron_agents_ovn_metadata_spec.rb
View File

@ -67,6 +67,7 @@ describe 'neutron::agents::ovn_metadata' do
should contain_ovn_metadata_agent_config('ovs/ovsdb_connection_timeout').with(:value => '<SERVICE DEFAULT>') should contain_ovn_metadata_agent_config('ovs/ovsdb_connection_timeout').with(:value => '<SERVICE DEFAULT>')
should contain_ovn_metadata_agent_config('ovs/ovsdb_connection').with(:value => params[:ovsdb_connection]) should contain_ovn_metadata_agent_config('ovs/ovsdb_connection').with(:value => params[:ovsdb_connection])
should contain_ovn_metadata_agent_config('ovn/ovn_sb_connection').with(:value => '<SERVICE DEFAULT>') should contain_ovn_metadata_agent_config('ovn/ovn_sb_connection').with(:value => '<SERVICE DEFAULT>')
should contain_ovn_metadata_agent_config('ovn/ovn_remote_probe_interval').with(:value => '<SERVICE DEFAULT>')
end end
end end