Deprecate prevent_arp_spoofing option

This option was deprecated in Mitaka but was not announced. [0]
So its deprecation starts in Newton.

[0] - https://review.openstack.org/#/c/300311/

Change-Id: Iea9ac6a11030911bcd359ff4d17593535bcea173

manifests/agents/ml2/ovs.pp

@@ -105,10 +105,6 @@
 #   mappings provided as part of the $bridge_mappings parameters.
 #   Defaults to true
 #
-# [*prevent_arp_spoofing*]
-#   (optional) Enable or not ARP Spoofing Protection
-#   Defaults to $::os_service_default
-#
 # [*extensions*]
 #   (optional) Extensions list to use
 #   Defaults to $::os_service_default
@@ -139,6 +135,12 @@
 #   in the ovs config.
 #   Defaults to false.
 #
+# === Deprecated Parameters
+#
+# [*prevent_arp_spoofing*]
+#   (optional) Enable or not ARP Spoofing Protection
+#   Defaults to $::os_service_default
+#
 class neutron::agents::ml2::ovs (
   $package_ensure             = 'present',
   $enabled                    = true,
@@ -159,13 +161,14 @@ class neutron::agents::ml2::ovs (
   $enable_distributed_routing = $::os_service_default,
   $drop_flows_on_start        = false,
   $manage_vswitch             = true,
-  $prevent_arp_spoofing       = $::os_service_default,
   $int_peer_patch_port        = $::os_service_default,
   $tun_peer_patch_port        = $::os_service_default,
   $datapath_type              = $::os_service_default,
   $vhostuser_socket_dir       = $::os_service_default,
   $ovsdb_interface            = $::os_service_default,
   $purge_config               = false,
+  # DEPRECATED PARAMETERS
+  $prevent_arp_spoofing       = $::os_service_default,
 ) {
 
   include ::neutron::params
@@ -187,6 +190,10 @@ class neutron::agents::ml2::ovs (
     fail('A value of $ovsdb_interface is incorrect. The allowed values are ovs-ofctl and native')
   }
 
+  if ! is_service_default ($prevent_arp_spoofing) {
+    warning('The prevent_arp_spoofing parameter is deprecated and will be removed in Ocata release')
+  }
+
   Neutron_agent_ovs<||> ~> Service['neutron-ovs-agent-service']
 
   resources { 'neutron_agent_ovs':

releasenotes/notes/newton-deprecate-prevent-arp-spoofing-71ca70de4ba94b8b.yaml

@@ -0,0 +1,4 @@
+---
+deprecations:
+  - The option prevent_arp_spoofing has been deprecated
+    and will be removed in Ocata release.