ccac02b917
This commit makes the following changes, mostly to specs to get them passing on Puppet 4.x: removes redefinition of $name because it is now a reserved word and redundant in Puppet 3.x, cleans up the use of Puppet's old behavior of implicitly converting String to Integers since Puppet 4.x is pretty strictly typed, sets facts required for doing flow control and comparison, fixes implicit use of empty string that is assumed to be the same as false by updating tests that inject empty string into params to represent a value not being provide by a user to false instead. Closes-bug: #1447620 Change-Id: Ibb651f26f33549dbe564dc88167b8f578a03fd77
133 lines
5.0 KiB
Ruby
133 lines
5.0 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe 'neutron::agents::metadata' do
|
|
|
|
let :pre_condition do
|
|
"class { 'neutron': rabbit_password => 'passw0rd' }"
|
|
end
|
|
|
|
let :params do
|
|
{ :package_ensure => 'present',
|
|
:debug => false,
|
|
:enabled => true,
|
|
:auth_url => 'http://localhost:35357/v2.0',
|
|
:auth_insecure => false,
|
|
:auth_region => 'RegionOne',
|
|
:auth_tenant => 'services',
|
|
:auth_user => 'neutron',
|
|
:auth_password => 'password',
|
|
:metadata_ip => '127.0.0.1',
|
|
:metadata_port => '8775',
|
|
:metadata_protocol => 'http',
|
|
:metadata_backlog => '4096',
|
|
:shared_secret => 'metadata-secret'
|
|
}
|
|
end
|
|
|
|
let :default_facts do
|
|
{ :operatingsystem => 'default',
|
|
:operatingsystemrelease => 'default',
|
|
:processorcount => '2'
|
|
}
|
|
end
|
|
|
|
shared_examples_for 'neutron metadata agent' do
|
|
|
|
it { is_expected.to contain_class('neutron::params') }
|
|
|
|
it 'configures neutron metadata agent service' do
|
|
is_expected.to contain_service('neutron-metadata').with(
|
|
:name => platform_params[:metadata_agent_service],
|
|
:enable => params[:enabled],
|
|
:ensure => 'running',
|
|
:require => 'Class[Neutron]'
|
|
)
|
|
end
|
|
|
|
context 'with manage_service as false' do
|
|
before :each do
|
|
params.merge!(:manage_service => false)
|
|
end
|
|
it 'should not start/stop service' do
|
|
is_expected.to contain_service('neutron-metadata').without_ensure
|
|
end
|
|
end
|
|
|
|
it 'configures metadata_agent.ini' do
|
|
is_expected.to contain_neutron_metadata_agent_config('DEFAULT/debug').with(:value => params[:debug])
|
|
is_expected.to contain_neutron_metadata_agent_config('DEFAULT/auth_url').with(:value => params[:auth_url])
|
|
is_expected.to contain_neutron_metadata_agent_config('DEFAULT/auth_insecure').with(:value => params[:auth_insecure])
|
|
is_expected.to contain_neutron_metadata_agent_config('DEFAULT/auth_ca_cert').with_ensure('absent')
|
|
is_expected.to contain_neutron_metadata_agent_config('DEFAULT/auth_region').with(:value => params[:auth_region])
|
|
is_expected.to contain_neutron_metadata_agent_config('DEFAULT/admin_tenant_name').with(:value => params[:auth_tenant])
|
|
is_expected.to contain_neutron_metadata_agent_config('DEFAULT/admin_user').with(:value => params[:auth_user])
|
|
is_expected.to contain_neutron_metadata_agent_config('DEFAULT/admin_password').with(:value => params[:auth_password])
|
|
is_expected.to contain_neutron_metadata_agent_config('DEFAULT/admin_password').with_secret( true )
|
|
is_expected.to contain_neutron_metadata_agent_config('DEFAULT/nova_metadata_ip').with(:value => params[:metadata_ip])
|
|
is_expected.to contain_neutron_metadata_agent_config('DEFAULT/nova_metadata_port').with(:value => params[:metadata_port])
|
|
is_expected.to contain_neutron_metadata_agent_config('DEFAULT/nova_metadata_protocol').with(:value => params[:metadata_protocol])
|
|
is_expected.to contain_neutron_metadata_agent_config('DEFAULT/metadata_workers').with(:value => facts[:processorcount])
|
|
is_expected.to contain_neutron_metadata_agent_config('DEFAULT/metadata_backlog').with(:value => params[:metadata_backlog])
|
|
is_expected.to contain_neutron_metadata_agent_config('DEFAULT/metadata_proxy_shared_secret').with(:value => params[:shared_secret])
|
|
is_expected.to contain_neutron_metadata_agent_config('DEFAULT/cache_url').with(:value => 'memory://?default_ttl=5')
|
|
end
|
|
end
|
|
|
|
shared_examples_for 'neutron metadata agent with auth_insecure and auth_ca_cert set' do
|
|
let :params do
|
|
{ :auth_ca_cert => '/some/cert',
|
|
:auth_insecure => true,
|
|
:auth_password => 'blah',
|
|
:shared_secret => '42'
|
|
}
|
|
end
|
|
|
|
it 'configures certificate' do
|
|
is_expected.to contain_neutron_metadata_agent_config('DEFAULT/auth_ca_cert').with_value('/some/cert')
|
|
is_expected.to contain_neutron_metadata_agent_config('DEFAULT/auth_insecure').with_value('true')
|
|
end
|
|
end
|
|
|
|
context 'on Debian platforms' do
|
|
let :facts do
|
|
default_facts.merge(
|
|
{ :osfamily => 'Debian' }
|
|
)
|
|
end
|
|
|
|
let :platform_params do
|
|
{ :metadata_agent_package => 'neutron-metadata-agent',
|
|
:metadata_agent_service => 'neutron-metadata-agent' }
|
|
end
|
|
|
|
it 'installs neutron metadata agent package' do
|
|
is_expected.to contain_package('neutron-metadata').with(
|
|
:ensure => params[:package_ensure],
|
|
:name => platform_params[:metadata_agent_package],
|
|
:tag => 'openstack'
|
|
)
|
|
end
|
|
|
|
it_configures 'neutron metadata agent'
|
|
it_configures 'neutron metadata agent with auth_insecure and auth_ca_cert set'
|
|
|
|
end
|
|
|
|
context 'on Red Hat platforms' do
|
|
let :facts do
|
|
default_facts.merge(
|
|
{ :osfamily => 'RedHat' }
|
|
)
|
|
end
|
|
|
|
let :platform_params do
|
|
{ :metadata_agent_service => 'neutron-metadata-agent' }
|
|
end
|
|
|
|
it_configures 'neutron metadata agent'
|
|
it_configures 'neutron metadata agent with auth_insecure and auth_ca_cert set'
|
|
|
|
end
|
|
|
|
end
|