puppet-neutron/spec/classes/neutron_plugins_ml2_spec.rb

#
# Copyright (C) 2013 eNovance SAS <licensing@enovance.com>
#
# Author: Emilien Macchi <emilien.macchi@enovance.com>
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
#      http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# Unit tests for neutron::plugins::ml2 class
#

require 'spec_helper'

describe 'neutron::plugins::ml2' do

  let :pre_condition do
    "class { 'neutron':
      rabbit_password => 'passw0rd',
      core_plugin     => 'neutron.plugins.ml2.plugin.Ml2Plugin' }"
  end

  let :default_params do
    { :type_drivers          => ['local', 'flat', 'vlan', 'gre', 'vxlan'],
      :tenant_network_types  => ['local', 'flat', 'vlan', 'gre', 'vxlan'],
      :mechanism_drivers     => ['openvswitch', 'linuxbridge'],
      :flat_networks         => ['*'],
      :network_vlan_ranges   => ['10:50'],
      :tunnel_id_ranges      => ['20:100'],
      :vxlan_group           => '224.0.0.1',
      :vni_ranges            => ['10:100'],
      :enable_security_group => false }
  end

  let :params do
    {}
  end

  shared_examples_for 'neutron plugin ml2' do
    let :p do
      default_params.merge(params)
    end

    it { should contain_class('neutron::params') }

    it 'configure neutron.conf' do
        should contain_neutron_config('DEFAULT/core_plugin').with_value('neutron.plugins.ml2.plugin.Ml2Plugin')
    end

    it 'configures ml2_conf.ini' do
      should contain_neutron_plugin_ml2('ml2/type_drivers').with_value(p[:type_drivers].join(','))
      should contain_neutron_plugin_ml2('ml2/tenant_network_types').with_value(p[:tenant_network_types].join(','))
      should contain_neutron_plugin_ml2('ml2/mechanism_drivers').with_value(p[:mechanism_drivers].join(','))
      should contain_neutron_plugin_ml2('securitygroup/firewall_driver').with_value('neutron.agent.firewall.NoopFirewallDriver')
    end

    it 'installs ml2 package (if any)' do
      if platform_params.has_key?(:ml2_server_package)
        should contain_package('neutron-plugin-ml2').with(
          :name   => platform_params[:ml2_server_package],
          :ensure => 'present'
        )
        should contain_package('neutron-plugin-ml2').with_before(/Neutron_plugin_ml2\[.+\]/)
      end

    end

    it 'configures ovs plugin' do
      should_not contain_neutron_plugin_ovs('agent/l2_population').with('value' => true)
    end

    it 'configures linux bridge plugin' do
      should_not contain_neutron_plugin_linuxbridge('vxlan/enable_vxlan').with('value' => true)
      should_not contain_neutron_plugin_linuxbridge('vxlan/l2_population').with('value' => true)
    end

    context 'configure ml2 with bad driver value' do
      before :each do
       params.merge!(:type_drivers => ['foobar'])
      end
      it 'should fails to configure ml2 because foobar is not a valid driver' do
          expect { subject }.to raise_error(Puppet::Error, /type_driver unknown./)
      end
    end

    context 'when using flat driver' do
      before :each do
        params.merge!(:flat_networks => ['eth1', 'eth2'])
      end
      it 'should configure flat_networks' do
        should contain_neutron_plugin_ml2('ml2_type_flat/flat_networks').with_value(p[:flat_networks].join(','))
      end
    end

    context 'when using gre driver with valid values' do
      before :each do
        params.merge!(:tunnel_id_ranges => ['0:20', '40:60'])
      end
      it 'should configure gre_networks with valid ranges' do
        should contain_neutron_plugin_ml2('ml2_type_gre/tunnel_id_ranges').with_value(p[:tunnel_id_ranges].join(','))
      end
    end

    context 'when using gre driver with invalid values' do
      before :each do
       params.merge!(:tunnel_id_ranges => ['0:20', '40:100000000'])
      end
      it 'should fails to configure gre_networks because of too big range' do
          expect { subject }.to raise_error(Puppet::Error, /tunnel id ranges are to large./)
      end
    end

    context 'when using vlan driver with valid values' do
      before :each do
        params.merge!(:network_vlan_ranges => ['1:20', '400:4094'])
      end
      it 'should configure vlan_networks with 1:20 and 400:4094 VLAN ranges' do
        should contain_neutron_plugin_ml2('ml2_type_vlan/network_vlan_ranges').with_value(p[:network_vlan_ranges].join(','))
      end
    end

     context 'when using vlan driver with invalid vlan id' do
       before :each do
        params.merge!(:network_vlan_ranges => ['1:20', '400:4099'])
       end
       it 'should fails to configure vlan_networks because of 400:4099 VLAN range' do
           expect { subject }.to raise_error(Puppet::Error, /vlan id are invalid./)
       end
     end

     context 'when using vlan driver with invalid vlan range' do
       before :each do
         params.merge!(:network_vlan_ranges => ['2938:1'])
       end
       it 'should fails to configure network_vlan_ranges with 2938:1 range' do
           expect { subject }.to raise_error(Puppet::Error, /vlan ranges are invalid./)
       end
     end

     context 'when using vxlan driver with valid values' do
       before :each do
         params.merge!(:vni_ranges => ['40:300', '500:1000'], :vxlan_group => '224.1.1.1')
       end
       it 'should configure vxlan_networks with 224.1.1.1 vxlan group' do
         should contain_neutron_plugin_ml2('ml2_type_vxlan/vni_ranges').with_value(p[:vni_ranges].join(','))
         should contain_neutron_plugin_ml2('ml2_type_vxlan/vxlan_group').with_value(p[:vxlan_group])
       end
     end

     context 'when using vxlan driver with invalid vxlan group' do
       before :each do
         params.merge!(:vxlan_group => '192.1.1.1')
       end
       it 'should fails to configure vxlan_group with 192.1.1.1 vxlan group' do
           expect { subject }.to raise_error(Puppet::Error, /is not valid for vxlan_group./)
       end
     end

     context 'when using vxlan driver with invalid vni_range' do
       before :each do
         params.merge!(:vni_ranges => ['2938:1'])
       end
       it 'should fails to configure vni_ranges with 2938:1 range' do
           expect { subject }.to raise_error(Puppet::Error, /vni ranges are invalid./)
       end
     end

     context 'when using l2population with ovs' do
       before :each do
         params.merge!(:mechanism_drivers => ['openvswitch','l2population'])
       end
       it 'should set l2_population flag as true' do
         should contain_neutron_plugin_ovs('agent/l2_population').with_value('true')
       end
     end

     context 'when using l2population with linuxbridge' do
       before :each do
         params.merge!(:mechanism_drivers => ['linuxbridge','l2population'])
       end
       it 'should set l2_population flag as true' do
         should contain_neutron_plugin_linuxbridge('vxlan/enable_vxlan').with_value('true')
         should contain_neutron_plugin_linuxbridge('vxlan/l2_population').with_value('true')
       end
     end

     context 'when enabling security group' do
       before :each do
         params.merge!(:enable_security_group => true)
       end
       it 'should set firewall_driver to true' do
         should contain_neutron_plugin_ml2('securitygroup/firewall_driver').with('value' => true)
       end
     end
  end

  context 'on Debian platforms' do
    let :facts do
      { :osfamily => 'Debian' }
    end

    let :platform_params do
      {}
    end

    it_configures 'neutron plugin ml2'
  end

  context 'on RedHat platforms' do
    let :facts do
      { :osfamily => 'RedHat' }
    end

    let :platform_params do
      { :ml2_server_package => 'openstack-neutron-ml2' }
    end

    it_configures 'neutron plugin ml2'
  end

end