openstack/puppet-nova
Code Issues Proposed changes

Use ensure_packages to install utilities

Browse Source 
* Remove nested declaration of nova::utilities::install

Change-Id: I232f8aae8889e448710157966de61510d7420c63
This commit is contained in:
Mathieu Gagné
2013-08-07 22:35:11 -04:00
parent 5c960aa967
commit 0903bb1615
2 changed files with 19 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
manifests/utilities.pp
View File

@@ -1,14 +1,6 @@
# unzip swig screen parted curl euca2ools - extra packages # unzip swig screen parted curl euca2ools - extra packages
class nova::utilities { class nova::utilities {
define nova::utilities::install(){
if !defined(Package[$title]){
package { $title:
ensure => present
}
}
}
if $::osfamily == 'Debian' { if $::osfamily == 'Debian' {
$pkgs = ['unzip', 'screen', 'parted', 'curl', 'euca2ools'] ensure_packages(['unzip', 'screen', 'parted', 'curl', 'euca2ools'])
nova::utilities::install{$pkgs:}
} }
} }

18
spec/classes/nova_utilities_spec.rb Normal file
View File

@@ -0,0 +1,18 @@
require 'spec_helper'
describe 'nova::utilities' do
describe 'on debian platforms' do
let :facts do
{ :osfamily => 'Debian' }
end
it 'installes utilities' do
should contain_package('unzip').with_ensure('present')
should contain_package('screen').with_ensure('present')
should contain_package('parted').with_ensure('present')
should contain_package('curl').with_ensure('present')
should contain_package('euca2ools').with_ensure('present')
end
end
end