nova_flavor: Refactor is_public

Change-Id: I9f84d784aeb26a8d0bd92c7e7aef6e44cc44ee5e
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>

lib/puppet/type/nova_flavor.rb

@@ -119,18 +119,14 @@ Puppet::Type.newtype(:nova_flavor) do
   newproperty(:is_public) do
     desc "Whether the flavor is public or not. Default true"
     newvalues(/(y|Y)es/, /(n|N)o/, /(t|T)rue/, /(f|F)alse/, true, false)
-    defaultto(true)
-    munge do |v|
-      if v.is_a?(String)
-        if v =~ /^(y|Y)es$/
+    defaultto(:true)
+
+    munge do |value|
+      case value.to_s.downcase
+      when 'true', 'yes'
         :true
-        elsif v =~ /^(n|N)o$/
+      else
         :false
-        else
-          v.to_s.downcase.to_sym
-        end
-      else
-        v.to_s.downcase.to_sym
       end
     end
   end