openstack/puppet-nova
Code Issues Proposed changes

Validate ensure parameter for package resources

Browse Source 
The minimum version of puppetlabs-stdlib has been bumped globally, so
now we can use the common type definition.

Change-Id: Ib817f869377b39de21fbd1cba8ca265f1a5ac67e
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>
This commit is contained in:
Takashi Kajinami
2025-09-23 21:35:21 +09:00
parent 2984b808dc
commit 56f8a011c6
16 changed files with 99 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/api.pp
View File

@@ -139,7 +139,7 @@ class nova::api (
Boolean $enabled = true, Boolean $enabled = true,
Boolean $manage_service = true, Boolean $manage_service = true,
$api_paste_config = 'api-paste.ini', $api_paste_config = 'api-paste.ini',
$ensure_package = 'present', Stdlib::Ensure::Package $ensure_package = 'present',
Boolean $sync_db = true, Boolean $sync_db = true,
Boolean $sync_db_api = true, Boolean $sync_db_api = true,
Boolean $db_online_data_migrations = false, Boolean $db_online_data_migrations = false,

2
manifests/client.pp
View File

@@ -9,7 +9,7 @@
# Defaults to 'present' # Defaults to 'present'
# #
class nova::client ( class nova::client (
$ensure = 'present' Stdlib::Ensure::Package $ensure = 'present',
) { ) {
include nova::deps include nova::deps
include nova::params include nova::params

2
manifests/compute.pp
View File

@@ -265,7 +265,7 @@
class nova::compute ( class nova::compute (
Boolean $enabled = true, Boolean $enabled = true,
Boolean $manage_service = true, Boolean $manage_service = true,
$ensure_package = 'present', Stdlib::Ensure::Package $ensure_package = 'present',
Boolean $vnc_enabled = true, Boolean $vnc_enabled = true,
Boolean $spice_enabled = false, Boolean $spice_enabled = false,
$vncserver_proxyclient_address = $facts['os_service_default'], $vncserver_proxyclient_address = $facts['os_service_default'],

2
manifests/compute/ironic.pp
View File

@@ -13,7 +13,7 @@
# Defaults to 'ironic.IronicDriver' # Defaults to 'ironic.IronicDriver'
# #
class nova::compute::ironic ( class nova::compute::ironic (
$ensure_package = 'present', Stdlib::Ensure::Package $ensure_package = 'present',
$compute_driver = 'ironic.IronicDriver', $compute_driver = 'ironic.IronicDriver',
) { ) {
include nova::deps include nova::deps

2
manifests/compute/libvirt.pp
View File

@@ -244,7 +244,7 @@
# Defaults to undef # Defaults to undef
# #
class nova::compute::libvirt ( class nova::compute::libvirt (
$ensure_package = 'present', Stdlib::Ensure::Package $ensure_package = 'present',
Nova::VirtType $virt_type = 'kvm', Nova::VirtType $virt_type = 'kvm',
String[1] $vncserver_listen = '127.0.0.1', String[1] $vncserver_listen = '127.0.0.1',
Boolean $migration_support = false, Boolean $migration_support = false,

2
manifests/compute/libvirt/services.pp
View File

@@ -58,7 +58,7 @@
# Defaults to false # Defaults to false
# #
class nova::compute::libvirt::services ( class nova::compute::libvirt::services (
$ensure_package = 'present', Stdlib::Ensure::Package $ensure_package = 'present',
$libvirt_service_name = $nova::params::libvirt_service_name, $libvirt_service_name = $nova::params::libvirt_service_name,
$virtlock_service_name = $nova::params::virtlock_service_name, $virtlock_service_name = $nova::params::virtlock_service_name,
$virtlog_service_name = $nova::params::virtlog_service_name, $virtlog_service_name = $nova::params::virtlog_service_name,

2
manifests/compute/libvirt_guests.pp
View File

@@ -69,7 +69,7 @@
# #
class nova::compute::libvirt_guests ( class nova::compute::libvirt_guests (
Boolean $enabled = false, Boolean $enabled = false,
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
Enum['start', 'ignore'] $on_boot = 'ignore', Enum['start', 'ignore'] $on_boot = 'ignore',
Enum['suspend', 'shutdown'] $on_shutdown = 'shutdown', Enum['suspend', 'shutdown'] $on_shutdown = 'shutdown',
Optional[Integer[0]] $start_delay = undef, Optional[Integer[0]] $start_delay = undef,

4
manifests/compute/rbd.pp
View File

@@ -112,8 +112,8 @@ class nova::compute::rbd (
$libvirt_rbd_destroy_volume_retries = $facts['os_service_default'], $libvirt_rbd_destroy_volume_retries = $facts['os_service_default'],
Boolean $ephemeral_storage = true, Boolean $ephemeral_storage = true,
Boolean $manage_ceph_client = true, Boolean $manage_ceph_client = true,
$ceph_client_ensure = 'present', Stdlib::Ensure::Package $ceph_client_ensure = 'present',
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
Boolean $manage_libvirt_secret = true, Boolean $manage_libvirt_secret = true,
) { ) {
include nova::deps include nova::deps

2
manifests/conductor.pp
View File

@@ -30,7 +30,7 @@
class nova::conductor ( class nova::conductor (
Boolean $enabled = true, Boolean $enabled = true,
Boolean $manage_service = true, Boolean $manage_service = true,
$ensure_package = 'present', Stdlib::Ensure::Package $ensure_package = 'present',
$workers = $facts['os_workers'], $workers = $facts['os_workers'],
$enable_new_services = $facts['os_service_default'], $enable_new_services = $facts['os_service_default'],
) { ) {

2
manifests/generic_service.pp
View File

@@ -35,7 +35,7 @@ define nova::generic_service (
$service_name, $service_name,
Boolean $enabled = true, Boolean $enabled = true,
Boolean $manage_service = true, Boolean $manage_service = true,
$ensure_package = 'present' Stdlib::Ensure::Package $ensure_package = 'present',
) { ) {
include nova::deps include nova::deps
include nova::params include nova::params

2
manifests/init.pp
View File

@@ -352,7 +352,7 @@
# Defaults to $facts['os_service_default'] # Defaults to $facts['os_service_default']
# #
class nova ( class nova (
$ensure_package = 'present', Stdlib::Ensure::Package $ensure_package = 'present',
$default_transport_url = $facts['os_service_default'], $default_transport_url = $facts['os_service_default'],
$rpc_response_timeout = $facts['os_service_default'], $rpc_response_timeout = $facts['os_service_default'],
$long_rpc_timeout = $facts['os_service_default'], $long_rpc_timeout = $facts['os_service_default'],

2
manifests/scheduler.pp
View File

@@ -69,7 +69,7 @@
class nova::scheduler ( class nova::scheduler (
Boolean $enabled = true, Boolean $enabled = true,
Boolean $manage_service = true, Boolean $manage_service = true,
$ensure_package = 'present', Stdlib::Ensure::Package $ensure_package = 'present',
$workers = $facts['os_workers'], $workers = $facts['os_workers'],
$max_attempts = $facts['os_service_default'], $max_attempts = $facts['os_service_default'],
$discover_hosts_in_cells_interval = $facts['os_service_default'], $discover_hosts_in_cells_interval = $facts['os_service_default'],

2
manifests/serialproxy.pp
View File

@@ -29,7 +29,7 @@ class nova::serialproxy (
Boolean $manage_service = true, Boolean $manage_service = true,
$serialproxy_host = $facts['os_service_default'], $serialproxy_host = $facts['os_service_default'],
$serialproxy_port = $facts['os_service_default'], $serialproxy_port = $facts['os_service_default'],
$ensure_package = 'present' Stdlib::Ensure::Package $ensure_package = 'present',
) { ) {
include nova::deps include nova::deps
include nova::params include nova::params

2
manifests/spicehtml5proxy.pp
View File

@@ -33,7 +33,7 @@ class nova::spicehtml5proxy (
Boolean $manage_service = true, Boolean $manage_service = true,
$host = '0.0.0.0', $host = '0.0.0.0',
$port = '6082', $port = '6082',
$ensure_package = 'present' Stdlib::Ensure::Package $ensure_package = 'present',
) { ) {
include nova::deps include nova::deps
include nova::params include nova::params

2
manifests/vncproxy.pp
View File

@@ -67,7 +67,7 @@ class nova::vncproxy (
String[1] $host = '0.0.0.0', String[1] $host = '0.0.0.0',
Stdlib::Port $port = 6080, Stdlib::Port $port = 6080,
String $vncproxy_path = '/vnc_auto.html', String $vncproxy_path = '/vnc_auto.html',
$ensure_package = 'present', Stdlib::Ensure::Package $ensure_package = 'present',
Boolean $allow_noauth = true, Boolean $allow_noauth = true,
Boolean $allow_vencrypt = false, Boolean $allow_vencrypt = false,
$vencrypt_key = undef, $vencrypt_key = undef,

2
manifests/wsgi/apache_metadata.pp
View File

@@ -157,7 +157,7 @@ class nova::wsgi::apache_metadata (
$wsgi_process_display_name = undef, $wsgi_process_display_name = undef,
$threads = 1, $threads = 1,
$priority = 10, $priority = 10,
$ensure_package = 'present', Stdlib::Ensure::Package $ensure_package = 'present',
$access_log_file = undef, $access_log_file = undef,
$access_log_pipe = undef, $access_log_pipe = undef,
$access_log_syslog = undef, $access_log_syslog = undef,