From 6bffa3a961274036540a1f3554936373c163fa7e Mon Sep 17 00:00:00 2001
From: Emilien Macchi <emilien@redhat.com>
Date: Wed, 20 Apr 2016 12:22:03 -0400
Subject: [PATCH] Change scheduler configurations to use entrypoints

Update defaults values for scheduler_driver and scheduler_host_manager
to match with upstream values in Nova.

It was configured in Devstack:
https://github.com/openstack-dev/devstack/commit/b298e57c9f44081767c726a36d60caca66f604aa

And old values don't work anymore since:
https://github.com/openstack/nova/commit/7f1ff4b226177dac8edc520c4b83a8b800b68cae

Change-Id: Idbbae5281d429edb95783cdde3d45804ddaeace1
Closes-Bug: #1572467
---
 manifests/scheduler.pp                                        | 4 ++--
 manifests/scheduler/filter.pp                                 | 4 ++--
 .../notes/scheduler_entrypoints-467a5083d8f65e3d.yaml         | 4 ++++
 spec/classes/nova_scheduler_filter_spec.rb                    | 2 +-
 spec/classes/nova_scheduler_spec.rb                           | 2 +-
 5 files changed, 10 insertions(+), 6 deletions(-)
 create mode 100644 releasenotes/notes/scheduler_entrypoints-467a5083d8f65e3d.yaml

diff --git a/manifests/scheduler.pp b/manifests/scheduler.pp
index 64f66006d..63e8f2b77 100644
--- a/manifests/scheduler.pp
+++ b/manifests/scheduler.pp
@@ -18,13 +18,13 @@
 #
 # [*scheduler_driver*]
 #   (optional) Default driver to use for the scheduler
-#   Defaults to 'nova.scheduler.filter_scheduler.FilterScheduler'
+#   Defaults to 'filter_scheduler'
 #
 class nova::scheduler(
   $enabled          = true,
   $manage_service   = true,
   $ensure_package   = 'present',
-  $scheduler_driver = 'nova.scheduler.filter_scheduler.FilterScheduler',
+  $scheduler_driver = 'filter_scheduler',
 ) {
 
   include ::nova::deps
diff --git a/manifests/scheduler/filter.pp b/manifests/scheduler/filter.pp
index 061ee4f7d..befa7d49f 100644
--- a/manifests/scheduler/filter.pp
+++ b/manifests/scheduler/filter.pp
@@ -6,7 +6,7 @@
 #
 # [*scheduler_host_manager*]
 #   (optional) The scheduler host manager class to use
-#   Defaults to 'nova.scheduler.host_manager.HostManager'
+#   Defaults to 'host_manager'
 #
 # [*scheduler_max_attempts*]
 #   (optional) Maximum number of attempts to schedule an instance
@@ -65,7 +65,7 @@
 #   Defaults to false
 #
 class nova::scheduler::filter (
-  $scheduler_host_manager              = 'nova.scheduler.host_manager.HostManager',
+  $scheduler_host_manager              = 'host_manager',
   $scheduler_max_attempts              = '3',
   $scheduler_host_subset_size          = '1',
   $cpu_allocation_ratio                = '16.0',
diff --git a/releasenotes/notes/scheduler_entrypoints-467a5083d8f65e3d.yaml b/releasenotes/notes/scheduler_entrypoints-467a5083d8f65e3d.yaml
new file mode 100644
index 000000000..a264f40fe
--- /dev/null
+++ b/releasenotes/notes/scheduler_entrypoints-467a5083d8f65e3d.yaml
@@ -0,0 +1,4 @@
+---
+upgrade:
+  - Change default values for scheduler_driver and scheduler_host_manager to match
+    defaults values in Nova, so now we use entrypoints.
diff --git a/spec/classes/nova_scheduler_filter_spec.rb b/spec/classes/nova_scheduler_filter_spec.rb
index 857f4b008..ed7d27f92 100644
--- a/spec/classes/nova_scheduler_filter_spec.rb
+++ b/spec/classes/nova_scheduler_filter_spec.rb
@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe 'nova::scheduler::filter' do
 
-  it { is_expected.to contain_nova_config('DEFAULT/scheduler_host_manager').with_value('nova.scheduler.host_manager.HostManager') }
+  it { is_expected.to contain_nova_config('DEFAULT/scheduler_host_manager').with_value('host_manager') }
   it { is_expected.to contain_nova_config('DEFAULT/scheduler_max_attempts').with_value('3') }
   it { is_expected.to contain_nova_config('DEFAULT/scheduler_host_subset_size').with_value('1') }
   it { is_expected.to contain_nova_config('DEFAULT/cpu_allocation_ratio').with_value('16.0') }
diff --git a/spec/classes/nova_scheduler_spec.rb b/spec/classes/nova_scheduler_spec.rb
index fe9b22c64..34873482e 100644
--- a/spec/classes/nova_scheduler_spec.rb
+++ b/spec/classes/nova_scheduler_spec.rb
@@ -20,7 +20,7 @@ describe 'nova::scheduler' do
       :ensure    => 'running'
     )}
 
-    it { is_expected.to contain_nova_config('DEFAULT/scheduler_driver').with_value('nova.scheduler.filter_scheduler.FilterScheduler') }
+    it { is_expected.to contain_nova_config('DEFAULT/scheduler_driver').with_value('filter_scheduler') }
 
     context 'with manage_service as false' do
       let :params do