From 931cadff4e2ee5c4ef7e7d2b7fe7fbb9b527ffe5 Mon Sep 17 00:00:00 2001
From: Takashi Kajinami <kajinamit@oss.nttdata.com>
Date: Sat, 27 Sep 2025 23:50:08 +0900
Subject: [PATCH] Import base parameter types for ::policy

Import the parameter types from openstacklib::policy so that parameter
types are validated at module level, instead of internal resource
call.

Also remove the tag which is no longer necessary after dependency
refactoring.

Change-Id: Idb81b55435c9b36ae0d6b67c126f22f60161f388
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>
---
 manifests/policy.pp              | 15 +++++++--------
 spec/classes/nova_policy_spec.rb |  2 --
 2 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/manifests/policy.pp b/manifests/policy.pp
index 68c574932..033cd2bb9 100644
--- a/manifests/policy.pp
+++ b/manifests/policy.pp
@@ -46,13 +46,13 @@
 #    Defaults to false.
 #
 class nova::policy (
-  $enforce_scope        = $facts['os_service_default'],
-  $enforce_new_defaults = $facts['os_service_default'],
-  Hash $policies        = {},
-  $policy_path          = '/etc/nova/policy.yaml',
-  $policy_default_rule  = $facts['os_service_default'],
-  $policy_dirs          = $facts['os_service_default'],
-  Boolean $purge_config = false,
+  $enforce_scope                    = $facts['os_service_default'],
+  $enforce_new_defaults             = $facts['os_service_default'],
+  Openstacklib::Policies $policies  = {},
+  Stdlib::Absolutepath $policy_path = '/etc/nova/policy.yaml',
+  $policy_default_rule              = $facts['os_service_default'],
+  $policy_dirs                      = $facts['os_service_default'],
+  Boolean $purge_config             = false,
 ) {
   include nova::deps
   include nova::params
@@ -64,7 +64,6 @@ class nova::policy (
     file_group   => $nova::params::group,
     file_format  => 'yaml',
     purge_config => $purge_config,
-    tag          => 'nova',
   }
 
   create_resources('openstacklib::policy', { $policy_path => $policy_parameters })
diff --git a/spec/classes/nova_policy_spec.rb b/spec/classes/nova_policy_spec.rb
index 5bf61030f..ac8f3647c 100644
--- a/spec/classes/nova_policy_spec.rb
+++ b/spec/classes/nova_policy_spec.rb
@@ -33,7 +33,6 @@ describe 'nova::policy' do
           :file_group   => 'nova',
           :file_format  => 'yaml',
           :purge_config => false,
-          :tag          => 'nova',
         )
         is_expected.to contain_oslo__policy('nova_config').with(
           :enforce_scope        => false,
@@ -64,7 +63,6 @@ describe 'nova::policy' do
           :file_group   => 'nova',
           :file_format  => 'yaml',
           :purge_config => true,
-          :tag          => 'nova',
         )
         is_expected.to contain_oslo__policy('nova_config').with(
           :enforce_scope        => false,