openstack/puppet-nova
Code Issues Proposed changes

Debian api_uwsgi_config: Switch to :ini_setting

Browse Source 
On each puppet run, I'm seeing:
value changed ['12'] to '12' (corrective)

Therefore, this patch switches from :openstackconfig to :ini_setting
to make runs indenpotant.

Change-Id: I2bd2a61263db8d7e54397ab85b4c51b79644adf2
This commit is contained in:
Thomas Goirand
2021-04-20 17:03:48 +02:00
parent 1599c882d5
commit 98f286cd7b
4 changed files with 6 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/puppet/provider/nova_api_metadata_uwsgi_config/openstackconfig.rb → lib/puppet/provider/nova_api_metadata_uwsgi_config/ini_setting.rb
View File

@@ -1,6 +1,6 @@
Puppet::Type.type(:nova_api_metadata_uwsgi_config).provide( Puppet::Type.type(:nova_api_metadata_uwsgi_config).provide(
:openstackconfig, :ini_setting,
:parent => Puppet::Type.type(:openstack_config).provider(:ruby) :parent => Puppet::Type.type(:openstack_config).provider(:ini_setting)
) do ) do
def self.file_path def self.file_path

4
lib/puppet/provider/nova_api_uwsgi_config/openstackconfig.rb → lib/puppet/provider/nova_api_uwsgi_config/ini_setting.rb
View File

@@ -1,6 +1,6 @@
Puppet::Type.type(:nova_api_uwsgi_config).provide( Puppet::Type.type(:nova_api_uwsgi_config).provide(
:openstackconfig, :ini_setting,
:parent => Puppet::Type.type(:openstack_config).provider(:ruby) :parent => Puppet::Type.type(:openstack_config).provider(:ini_setting)
) do ) do
def self.file_path def self.file_path

13
spec/unit/provider/nova_api_metadata_uwsgi_config/openstackconfig_spec.rb → spec/unit/provider/nova_api_metadata_uwsgi_config/ini_setting_spec.rb
View File

@@ -14,19 +14,8 @@ $LOAD_PATH.push(
'inifile', 'inifile',
'lib') 'lib')
) )
$LOAD_PATH.push(
File.join(
File.dirname(__FILE__),
'..',
'..',
'..',
'fixtures',
'modules',
'openstacklib',
'lib')
)
require 'spec_helper' require 'spec_helper'
provider_class = Puppet::Type.type(:nova_api_metadata_uwsgi_config).provider(:openstackconfig) provider_class = Puppet::Type.type(:nova_api_metadata_uwsgi_config).provider(:ini_setting)
describe provider_class do describe provider_class do
it 'should default to the default setting when no other one is specified' do it 'should default to the default setting when no other one is specified' do

13
spec/unit/provider/nova_api_uwsgi_config/openstackconfig_spec.rb → spec/unit/provider/nova_api_uwsgi_config/ini_setting_spec.rb
View File

@@ -14,19 +14,8 @@ $LOAD_PATH.push(
'inifile', 'inifile',
'lib') 'lib')
) )
$LOAD_PATH.push(
File.join(
File.dirname(__FILE__),
'..',
'..',
'..',
'fixtures',
'modules',
'openstacklib',
'lib')
)
require 'spec_helper' require 'spec_helper'
provider_class = Puppet::Type.type(:nova_api_uwsgi_config).provider(:openstackconfig) provider_class = Puppet::Type.type(:nova_api_uwsgi_config).provider(:ini_setting)
describe provider_class do describe provider_class do
it 'should default to the default setting when no other one is specified' do it 'should default to the default setting when no other one is specified' do