openstack/puppet-nova
Code Issues Proposed changes

Use undef for non boolean values

Browse Source 
'undef' is the preferred value for non boolean parameters. Switching
to undef allows us to more easily implement parameter types later.

Change-Id: I994a33ecf3f5020617e1acfb50c0a81ae1c1aa45
This commit is contained in:
Takashi Kajinami 2024-07-10 22:25:48 +09:00
parent 5369ab9ac0
commit e39e873a03
3 changed files with 11 additions and 11 deletions

4
manifests/compute.pp

@ -36,7 +36,7 @@
#
# [*vncproxy_host*]
# (optional) The host of the VNC proxy server
# Defaults to false
# Defaults to undef
#
# [*vncproxy_protocol*]
# (optional) The protocol to communicate with the VNC proxy server
@ -269,7 +269,7 @@ class nova::compute (
Boolean $vnc_enabled = true,
Boolean $spice_enabled = false,
$vncserver_proxyclient_address = '127.0.0.1',
$vncproxy_host = false,
$vncproxy_host = undef,
$vncproxy_protocol = 'http',
$vncproxy_port = '6080',
$vncproxy_path = '/vnc_auto.html',

4
manifests/compute/spice.pp

@ -19,7 +19,7 @@
#
# [*proxy_host*]
# (optional) Host for the html5 console proxy
# Defaults to false
# Defaults to undef
#
# [*proxy_port*]
# (optional) Port for the html5 console proxy
@ -37,7 +37,7 @@ class nova::compute::spice(
Boolean $agent_enabled = true,
$server_listen = $facts['os_service_default'],
$server_proxyclient_address = '127.0.0.1',
$proxy_host = false,
$proxy_host = undef,
$proxy_protocol = 'http',
$proxy_port = '6082',
$proxy_path = '/spice_auto.html',

14
manifests/init.pp

@ -167,7 +167,7 @@
#
# [*use_ssl*]
# (optional) Enable SSL on the API server
# Defaults to false, not set
# Defaults to false
#
# [*enabled_ssl_apis*]
# (optional) List of APIs to SSL enable
@ -175,15 +175,15 @@
#
# [*cert_file*]
# (optional) Certificate file to use when starting API server securely
# Defaults to false, not set
# Defaults to undef
#
# [*key_file*]
# (optional) Private key file to use when starting API server securely
# Defaults to false, not set
# Defaults to undef
#
# [*ca_file*]
# (optional) CA certificate file to use to verify connecting clients
# Defaults to false, not set
# Defaults to undef
#
# [*nova_public_key*]
# (optional) Install public key in .ssh/authorized_keys for the 'nova' user.
@ -355,9 +355,9 @@ class nova(
$rootwrap_config = '/etc/nova/rootwrap.conf',
Boolean $use_ssl = false,
Array[String[1]] $enabled_ssl_apis = ['metadata', 'osapi_compute'],
$ca_file = false,
$cert_file = false,
$key_file = false,
$ca_file = undef,
$cert_file = undef,
$key_file = undef,
Nova::SshKey $nova_public_key = undef,
Nova::SshKey $nova_private_key = undef,
$ssl_only = $facts['os_service_default'],