diff --git a/playbooks/run-libraries-unit-tests.yaml b/playbooks/run-libraries-unit-tests.yaml index d9199746d..f8fe3f1be 100644 --- a/playbooks/run-libraries-unit-tests.yaml +++ b/playbooks/run-libraries-unit-tests.yaml @@ -9,6 +9,13 @@ fi # TODO(tobias-urdin): Remove when we dont pin rspec-puppet export RSPEC_PUPPET_VERSION='{{ rspec_puppet_version }}' + # NOTE(aschultz): rspec-puppet 2.4+ has strict variables enabled + # which causes test failures. The problem is that the puppet modules + # have never worked with strict_variables = true due to backwards + # compatibility & import ordering. Since this has not been true, + # lets disable it in the unit testing for now. Perhaps some day + # we will be able to turn this back to true. + export STRICT_VARIABLES=no ./run_unit_tests.sh executable: /bin/bash chdir: '{{ ansible_user_dir }}/workspace' diff --git a/playbooks/run-unit-tests.yaml b/playbooks/run-unit-tests.yaml index d375af6e5..f8bfb3f63 100644 --- a/playbooks/run-unit-tests.yaml +++ b/playbooks/run-unit-tests.yaml @@ -8,6 +8,13 @@ fi # TODO(tobias-urdin): Remove when we dont pin rspec-puppet export RSPEC_PUPPET_VERSION='{{ rspec_puppet_version }}' + # NOTE(aschultz): rspec-puppet 2.4+ has strict variables enabled + # which causes test failures. The problem is that the puppet modules + # have never worked with strict_variables = true due to backwards + # compatibility & import ordering. Since this has not been true, + # lets disable it in the unit testing for now. Perhaps some day + # we will be able to turn this back to true. + export STRICT_VARIABLES=no mkdir .bundled_gems export GEM_HOME=`pwd`/.bundled_gems ruby <