openstack/puppet-swift
Code Issues Proposed changes

Fix incorrect comments about updating region/zone of a device

Browse Source 
Updating region/zone of a device is actually implemented and supported
in swift, while puppet-swift doesn't support that operation yet.
This patch updates error messages when an operator tries to update
region/zone of a device, so that they notice more clearly that the
cause exists in puppet-swift, not in swift.

Change-Id: I7c7f633630ac52578a0cf6beb2033465a16bd251
This commit is contained in:
Takashi Kajinami 2020-05-10 00:37:40 +09:00
parent 7481ffaad5
commit 26c8746d7b
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/puppet/provider/swift_ring_builder.rb
View File

@ -203,16 +203,15 @@ class Puppet::Provider::SwiftRingBuilder < Puppet::Provider
end end
def region=(region) def region=(region)
raise(Puppet::Error, "Changing the region of a device is not possible.") raise(Puppet::Error, "Changing the region of a device is not yet supported.")
end end
def zone def zone
ring[resource[:name]][:zone] ring[resource[:name]][:zone]
end end
# TODO - is updating the zone supported?
def zone=(zone) def zone=(zone)
Puppet.warning('Setting zone is not yet supported, I am not even sure if it is supported') raise(Puppet::Error, "Changing the zone of a device is not yet supported.")
end end
def weight def weight