From d76efc7787bdf8a840f41453edf3b2aa3386efc2 Mon Sep 17 00:00:00 2001
From: Takashi Kajinami <tkajinam@redhat.com>
Date: Thu, 29 Sep 2022 08:52:46 +0900
Subject: [PATCH] Remove deprecated trove::guestagent::control_exchange

The parameter was deprecated long ago[1] and has had no effect.

[1] 7cb103c17ff121de8f852988f356386fcf4229f1

Change-Id: I1e7f54ae462e72866d03a2ea7f00e656e68db513
---
 manifests/guestagent.pp                              | 12 +-----------
 ...guestagent-control_exchange-a890e7661cb40151.yaml |  5 +++++
 2 files changed, 6 insertions(+), 11 deletions(-)
 create mode 100644 releasenotes/notes/remove-guestagent-control_exchange-a890e7661cb40151.yaml

diff --git a/manifests/guestagent.pp b/manifests/guestagent.pp
index ce5ba31c..dc7ed387 100644
--- a/manifests/guestagent.pp
+++ b/manifests/guestagent.pp
@@ -74,10 +74,6 @@
 #
 #  DEPRECATED PARAMETERS
 #
-# [*control_exchange*]
-#   (Optional) Moved to init.pp. The default exchange to scope topics.
-#   Defaults to undef.
-#
 # [*backup_aes_cbc_key*]
 #   (optional) Default OpenSSL aes_cbc key
 #   Defaults to undef
@@ -98,8 +94,7 @@ class trove::guestagent(
   $root_grant              = $::os_service_default,
   $root_grant_option       = $::os_service_default,
   $default_password_length = $::os_service_default,
-  #Deprecated
-  $control_exchange        = undef,
+  # DEPRECATED PARAMETERS
   $backup_aes_cbc_key      = undef,
 ) inherits trove {
 
@@ -107,11 +102,6 @@ class trove::guestagent(
   include trove::params
   include trove::guestagent::service_credentials
 
-  if $control_exchange {
-    warning("control_exchange parameter is deprecated. Please use \
-trove::control_exchange instead.")
-  }
-
   if $backup_aes_cbc_key != undef {
     warning('The parameter backup_aes_cbc_key is deprecated for removal')
   }
diff --git a/releasenotes/notes/remove-guestagent-control_exchange-a890e7661cb40151.yaml b/releasenotes/notes/remove-guestagent-control_exchange-a890e7661cb40151.yaml
new file mode 100644
index 00000000..cd7ffa70
--- /dev/null
+++ b/releasenotes/notes/remove-guestagent-control_exchange-a890e7661cb40151.yaml
@@ -0,0 +1,5 @@
+---
+upgrade:
+  - |
+    The deprecated ``trove::guestagent::control_exchange`` parameter has been
+    removed.