67 Commits

Author SHA1 Message Date
Takashi Kajinami
1f273d3b4e replace validate_legacy with proper data types
the validate_legacy function is marked for deprecation in
v9.0.0 from puppetlabs-stdlib.

This also adds validations about some boolean parameters.

Change-Id: I57e0321eab18b66c00e364bb3b4346bb06591286
2023-06-21 10:22:59 +09:00
Takashi Kajinami
505c5dbbe4 Replace legacy facts and use fact hash
... because the latest lint no longer allows usage of legacy facts and
top scope fact.

This also fixes the wrong wsgi script name introduced by [1] to fix
broken litmus jobs.

[1] d7a1ea5fb7632e58a69f7dead32c28f1a9419a2e

Change-Id: Idb7d655242ccd6f785ea4dfbb94d8ff3ad961b03
2023-03-02 13:53:25 +09:00
Takashi Kajinami
019c9b1a43 Deprecate support for [DEFAULT] default_password_length
This option was deprecated[1] in favor of the datastore-specific
options.

[1] f4cbaf6ccd3c6de14837fcf9532e44de1265bdf6

Change-Id: I4f89dcc5f70e03e210d038e80adba3002c5dc9c9
2023-02-20 20:07:01 +09:00
Takashi Kajinami
12131677e9 Support mysql/mariadb options
This change introduces the new class to manage [mysql] options and
[mariadb] options so that users can configure behavior of the guest
agent to launch and manage mysql instances and mariadb instances.

This also introduces support for options to manage container registry
used to pull container images.

Change-Id: Ic7b1d555cf2090f7278980edf226ddf318be489f
2023-02-20 20:02:56 +09:00
Takashi Kajinami
d76efc7787 Remove deprecated trove::guestagent::control_exchange
The parameter was deprecated long ago[1] and has had no effect.

[1] 7cb103c17ff121de8f852988f356386fcf4229f1

Change-Id: I1e7f54ae462e72866d03a2ea7f00e656e68db513
2022-09-29 08:54:05 +09:00
Zuul
e6686c48a9 Merge "guestagent: Deprecate the backup_aes_cbc_key parameter" 2022-03-18 09:29:05 +00:00
Zuul
b732428800 Merge "guestagent: Fix reference to trove::* parameters" 2022-03-18 09:29:02 +00:00
Takashi Kajinami
4c6e5c9d76 Disable trove-guestagent service by default
The trove-guestagent service should be run in instances instead of
OpenStack hosts. This change disables the service by default because
we expect these modules are used to deploy hosts, and we don't expect
any use case where this puppet module is used to build the trove guest
image.

Closes-Bug: #1965228
Closes-Bug: #1485397
Change-Id: I57aa6ecd008f1a7a271e7baafc95cd75bf700f54
2022-03-17 15:23:59 +09:00
Takashi Kajinami
977c0dc0e5 guestagent: Deprecate the backup_aes_cbc_key parameter
... because it was deprecated since Victoria cycle[1].

[1] bd2b256a377a5648586ec4a5d51edd58dd88a620

Change-Id: I4c068890a6d60434ee419167428a6fd0507ba919
2022-03-17 10:40:39 +09:00
Takashi Kajinami
2b4efd122f guestagent: Fix reference to trove::* parameters
The trove::guestagent class requires reference to trove::* parameters.
This change ensures the base trove class is present.

Change-Id: I741d8a11f22302f807af71bd6c02e8c321470a98
2022-03-17 10:37:45 +09:00
Takashi Kajinami
967522885a Clean up deprecated keystone v2 parameters
... and automated detection of auth_url parameter.

These were deprecated during the Ussuri cycle[1].

[1] 1d3bffd18b903aba95e5590b3c8444334d21a656

Depends-on: https://review.opendev.org/823886
Change-Id: I8304a0fd3bcabaf236a03c98f368b35842c7bff1
2022-03-11 05:17:03 +00:00
Takashi Kajinami
f1c11c68d5 Use single trove.conf for api, conductor and taskmanager
Previously puppet-trove creates separate config files for each service
but these individual files have been removed from Trove by [1].

This change follows that decision and merge these three files into
the single trove.conf file.

[1] https://review.opendev.org/679043

Change-Id: I23c01acd9439335abb706f2528684d4ec473247d
2022-03-07 23:56:02 +00:00
ZhongShengping
8cee8b5eca Deprecate allow_insecure_clients option
The allow_insecure_clients has been deprecated[1].

[1]https://review.opendev.org/#/c/417629/

Change-Id: Ibc83b18732269ce72ae51cbd5218e1ce772ae6a8
Closes-Bug: #1902158
2020-11-02 15:33:44 +08:00
Takashi Kajinami
1d3bffd18b Use service credential parameters to define keystone v3 auth
Change-Id: I67ac8b41365e1d6f90b8982659b9fd52744d2ad7
2020-05-06 21:36:00 +09:00
Tobias Urdin
a053d4e86e Convert all class usage to relative names
Change-Id: Ic7b8f4e584e3f1ed1d5c6c568cc6caf67493cdda
2019-12-08 23:24:12 +01:00
ZhongShengping
818193f578 Introduce the new rabbit_heartbeat_in_pthread option
oslo.messaging RabbitMQ driver have now a new option that allow user to
run the RabbitMQ heartbeat over a native python thread.

These change allow user to use this new option.

Change-Id: Ia2e54453058080f12963dedb18249faa5c9b2424
Closes-Bug: #1840868
2019-08-21 14:24:26 +08:00
Tobias Urdin
08f3eca1ee Remove deprecated rabbit params in guestagent
This revemos the deprecated options rabbit_host,
rabbit_hosts and rabbit_port params in the
trove::guestagent class.

Changes the guestagent config file to use the
transport_url instead of the rabbit options. [1]

[1] https://review.openstack.org/#/c/609981/

Change-Id: I2f102eb15fe59459ab1eed2e4cf87ad3c54d5c78
2018-10-21 18:05:41 +02:00
ZhongShengping
2a99e642d8 Remove deprecated ensure_package option
Change-Id: I4d667ea525c9b7a48d8175b37c1cdfb55543ed39
2018-03-29 12:01:15 +08:00
ZhongShengping
ccf6a66e1f Add kombu_failover_strategy option
Adds the kombu_failover_strategy option for configuring
oslo.messaging.rabbit. This will determines how the next RabbitMQ node
is chosen in case the one we are currently connected to becomes
unavailable.

Change-Id: If59b301e533a509051876ed88f410c5101425ec2
Closes-Bug: #1748353
2018-02-09 15:05:28 +08:00
Alfredo Moralejo
aa57603fb4 Force trove_auth_url to point to the v3 api URL
After removing keystone API v2, trove requires that
trove_auth_url parameter has the v3 URL. Note that
versionless url is not valid for trove_auth_url so
this patch enforces v3 url even when auth_url is
not versioned.

Additionally, the default value for auth_url parameter
has been updated to point to v3.

Change-Id: I8d0e200958c813101d72e180c6da8343b5fcae6e
2017-10-20 09:55:39 +02:00
Andrew Smith
6e1a56adb1 Deprecate oslo.messaging rpc_backend option parameter
Oslo.messaging uses the transport_url to represent the rpc and
notification messaging driver to use and its full configuration. The
rpc_backend configuration option is deprecated for removal and
should not gate oslo.messaging driver configuration options.

This patch:
* deprecate rpc_backend
* remove conditional check
* update spec tests
* add release note

Change-Id: Idbd5c231d85a0f4d249dabd14bc829844ee3e83d
2017-07-27 12:14:53 -04:00
ZhongShengping
3cf985f57e Inconsistent package_ensure parameter name
The parameter name used to enforce package state is inconsistent across
manifests and modules. I settle on package_ensure since it's already
widely used.

Change-Id: I887e924d184d9b25c33b5fe617d82f170d0cee34
Closes-Bug: #1668732
2017-03-09 09:25:07 +08:00
ZhongShengping
370c0bf8fa Add rpc_response_timeout option
Add rpc_response_timeout to configure seconds time for waiting
for a response from a call.

Change-Id: Ib107713d8b2cc137e11c3d478f14f8a4f4d034a3
2017-02-08 11:35:26 +08:00
Shaik Apsar
ca075e0a9c Add backup_aes_cbc_key parameter
This patch will provide an option for configuring
custom value to the backup_aes-cbc_key parameter
in guestagent configuration file.

Closes-Bug: #1659875

Change-Id: I51a8176c7df4ee80fcf999c37143842f2fdc69ad
2017-01-27 15:01:50 -05:00
Alex Schultz
8bf2f8c394 Deprecate rabbitmq connection parameters
The rabbitmq connection parameters have been deprecated in favor of the
transport_url setting.

Change-Id: I901eee39ae7da6164320f908a2719b8e35d46172
Related-Bug: #1625198
2016-11-09 07:56:02 -07:00
Jenkins
dfe7564169 Merge "Remove verbose" 2016-10-24 18:47:25 +00:00
Jenkins
0c14143f40 Merge "Fix documentation for log_dir parameter" 2016-10-22 04:04:31 +00:00
Alexey Deryugin
3cb02d8768 Make swift_service_type configurable in guestagent.conf
Change-Id: Id167b0dcf68fc6d9b211ecb9c6acbfaf4b1afead
Closes-Bug: #1569658
2016-10-11 16:31:21 +03:00
Mykyta Karpin
39062e3ac9 Fix documentation for log_dir parameter
Change-Id: Id7bbb1aa48c282269d1dffe0bc1ccd7afd1bf6f5
Partial-Bug: #1600294
2016-10-10 17:31:27 +03:00
Iury Gregory Melo Ferreira
01e4cea5d2 Remove verbose
Since we are in Ocata we should remove the
verbose option that was deprecated

Change-Id: I2b35fe30e4e5049b15e6cc58b81c8b202db56191
2016-09-27 19:46:42 -03:00
Alex Schultz
9ebd92afbe Update log_file documentation
log_file should be set to $::os_service_default and not to the boolean
false because the boolean false gets interpreted as a file name.

Change-Id: Ie52ea5bbd5e921aeede7a5b3c532c20574728bc2
2016-09-08 17:49:22 -06:00
Jenkins
b3df42b803 Merge "Add transport_url parameters for oslo.messaging" 2016-06-28 15:33:25 +00:00
Shaik Apsar
d24a11c35d Option to specify the trove guestagent log file.
Change-Id: Ifaf124933bca6b64d6a2d5225a5f67e58058e26f
Closes-Bug: #1506835
2016-06-28 13:21:59 +00:00
Andrew Smith
7cb103c17f Add transport_url parameters for oslo.messaging
This commit adds the transport_url parameters for oslo.messaging. The
url is of the form:

  transport://user:pass@host1:port[,hostN:portN]/virtual_host

Where the transport scheme specifies the rpc or notification backend
as one of rabbit, amqp, zmq, etc. Oslo.messaging is deprecating the
host, port, and auth configuration options [1]. All drivers will get
these options via the transport_url.

This patch:
* use oslo::messaging::default resource
* use oslo::messaging::notifications resource
* add parameters for transport_url(s)
* correct config file for amqp backend
* update spec tests
* add feature release note

[1] https://review.openstack.org/#/c/317285/

Change-Id: I8d0132f23aa05ed267ff2d88bce61ce9f20160f5
2016-06-28 13:17:26 +00:00
Yuan Xiaohua
5dc2d3359e Add Users/DBs related parameters to guestagent class
This patch is aim to add following params in guestagent class:
  - root_grant
  - root_grant_option
  - default_password_length

Change-Id: Iaeed4194b7b9ae895c3a04eb2ed2991fa6984636
Closes-Bug: #1570281
2016-06-21 14:29:26 +08:00
Shaik Apsar
6c9f6eba03 Allow guestagent to use unique rabbit_use_ssl param.
In some environments, Trove guests will talk to rabbit via
external VIP using SSL connection and trove services will
communicate to rabbit without ssl from the management network.

Change-Id: Ib5cd00cf92e4e2c23fbed2fd64420a07b0a46f88
Closes-Bug: #1585783
2016-06-08 18:36:02 +00:00
Iury Gregory Melo Ferreira
a498d302b7 Revert "Trove Deprecations"
This commit partially reverts original commit.

use_syslog option is not deprecated and still actual.

This reverts commit 700ddfd674a817c190916890a4a74f82ed82d3c1

Change-Id: Ie7515a45abeb3b0b4a7833bd19a32fbab759765a
2016-05-31 12:19:24 -03:00
Iury Gregory Melo Ferreira
2d5ee453cf Trove Deprecations
Deprecation of parameters listed in Mitaka during Newton cycle [1]

[1] http://docs.openstack.org/mitaka/config-reference/tables/conf-changes/trove.html

Change-Id: I700ddfd674a817c190916890a4a74f82ed82d3c1
2016-05-27 12:34:18 -03:00
Iury Gregory Melo Ferreira
8246a80558 Deprecate verbose option in logging
Option "verbose" from group "DEFAULT" is deprecated for removal.
The parameter has no effect.
Deprecated verbose in all classes
Remove verbose in README
Remove verbose from tests.
If this option is not set explicitly, there is no such warning.

Change-Id: Iedbc3ea8824fdef8e1e5434d8be9463704c0579a
2016-05-18 13:34:00 -03:00
Jenkins
364cd54b74 Merge "Introduce support for oslo.messaging amqp driver configuration" 2016-05-17 16:34:04 +00:00
Jenkins
25ed088b87 Merge "Use oslo module for logging" 2016-05-13 20:59:35 +00:00
Alexey Deryugin
8d7be7ac23 Use oslo module for logging
Additonal changes:

  * switch logging related parameters to $::os_service_default
    as they are used in oslo::log
  * update unit tests

Change-Id: I1884387b438e3885986d031f95ba323e57aac7ab
2016-05-13 18:43:04 +03:00
Andrew Smith
52371ee818 Introduce support for oslo.messaging amqp driver configuration
This commit adds support for the oslo.messaging amqp rpc_backend
which enables the AMQP 1.0 driver. A proposed feature for the
Newton oslo.messaging release is an update to the AMQP 1.0 driver
to support a stateless messaging interconnect for RPC traffic [1].

This patch:
* use oslo::messaging::amqp resource
* add new parameters for the oslo_messaging_amqp driver
* update spec tests for amqp as alternate rpc_backend
* add feature release note

[1] https://blueprints.launchpad.net/oslo.messaging/+spec/amqp-dispatch-router

Change-Id: I8306c56e86f2f8a8d6da1ecbf5eab674e6b1e8bf
2016-05-12 16:13:30 -04:00
Matt Fischer
ed529e5a5a default swift_url to SERVICE_DEFAULT
If swift_url is unset, Trove will set it using the Keystone catalog.
Therefore we will default the swift_url setting to use SERVICE_DEFAULT,
so that out of the box configs will use the Keystone catalog.

Change-Id: I7a3fe361ca41fbee9f353be6e2306c1a5c7f7097
2016-05-11 10:18:47 -06:00
Matt Fischer
f3519c4825 Correct name of guestagent config option
Change-Id: Icfc9d799dba50913a644402f765017038dbc8e29
Closes-Bug: #1580005
2016-05-10 07:55:34 -06:00
Jenkins
ae8ac0b340 Merge "Allow guestagent to use different rabbit params" 2016-05-10 00:28:15 +00:00
ZhongShengping
692f8b0835 Use oslo module for configuration
Oslo module has the control_exchange parameters,
so use oslo module(oslo::messaging::default) to configure it.

Change-Id: Ica1ce84fc143708e76ae334c1a0d7e091bb974f2
2016-05-07 14:57:59 +08:00
Matt Fischer
57b14b0158 Allow guestagent to use different rabbit params
In some environments, Trove guests will talk to rabbit via a different
gateway or VIP and possibly using a different port. This might be done
for security or separation reasons. This change allows the guestagent's
rabbit host(s) and port information to be different than that from the
main cluster.

Change-Id: I2107edd579073d81496821a8ecf23a3c2039b75d
2016-05-06 09:44:15 -06:00
Alexey Deryugin
24839ec63f Use oslo module for messaging (rabbit) configuration
Additonal changes:

  * switch messaging related parameters to $::os_service_default
    as they are used in oslo::messaging_rabbit define
  * update unit tests

Change-Id: I3f7800f78132fa4c6c639753327ff63cf337c285
2016-04-22 15:45:13 +00:00
Denis Egorenko
3352d44262 Totally drop Qpid support
Qpid was removed in Mitaka from Oslo Messaging, so now we can
drop it in manifests.

Change-Id: Ie33f82b278bdb685cf1c78b704725eb03be1a19e
2016-04-18 14:11:52 +03:00