openstack/puppet-vitrage
Code Issues Proposed changes

Do not validate database_connection format

Browse Source 
Currently we validate database_connection in 2 layers, each puppet
modules and puppet-oslo, however this makes it difficult to maintain
validation pattern because we always need to fix both.
This patch removes the validation from each puppet modules so that
we need to maitain only one place, puppet-oslo to update validation
logic.

Change-Id: I68988e35e1011aad10d76c8230138b24f8e41fba
This commit is contained in:
Takashi Kajinami 2020-08-31 17:58:05 +09:00
parent 60ac48a459
commit 3593e83c61
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
manifests/db.pp
View File

@ -69,9 +69,6 @@ class vitrage::db (
warning('The database_min_pool_size parameter is deprecated, and will be removed in a future release.')
}
validate_legacy(Oslo::Dbconn, 'validate_re', $database_connection,
['^(sqlite|mysql(\+pymysql)?|postgresql):\/\/(\S+:\S+@\S+\/\S+)?'])
oslo::db { 'vitrage_config':
connection => $database_connection,
connection_recycle_time => $database_connection_recycle_time,