openstack/python-novaclient
Code Issues Proposed changes

Enable check for E129

Browse Source 
E129 visually indented line with same indent as next logical line

Change-Id: I438bf0d9de7f61ab65e753169c9a8007e84b215a
This commit is contained in:
Andrey Kurilin 2014-09-24 23:55:54 +03:00
parent ae6c39397e
commit 3065afd6c0
8 changed files with 31 additions and 29 deletions
novaclient
v1_1
shell.py
v3
shell.py
tox.ini

9
novaclient/v1_1/shell.py

@ -156,7 +156,8 @@ def _boot(cs, args):
max_count = 1
# Don't let user mix num_instances and max_count/min_count.
if (args.num_instances is not None and
args.min_count is None and args.max_count is None):
args.min_count is None and
args.max_count is None):
if args.num_instances < 1:
raise exceptions.CommandError(_("num_instances should be >= 1"))
max_count = args.num_instances
@ -173,10 +174,10 @@ def _boot(cs, args):
if args.max_count < 1:
raise exceptions.CommandError(_("max_count should be >= 1"))
max_count = args.max_count
if (args.min_count is not None and args.max_count is not None and
if (args.min_count is not None and
args.max_count is not None and
args.min_count > args.max_count):
raise exceptions.CommandError(_(
"min_count should be <= max_count"))
raise exceptions.CommandError(_("min_count should be <= max_count"))
flavor = _find_flavor(cs, args.flavor)

9
novaclient/v3/shell.py

@ -88,7 +88,8 @@ def _boot(cs, args):
max_count = 1
# Don't let user mix num_instances and max_count/min_count.
if (args.num_instances is not None and
args.min_count is None and args.max_count is None):
args.min_count is None and
args.max_count is None):
if args.num_instances < 1:
raise exceptions.CommandError("num_instances should be >= 1")
max_count = args.num_instances
@ -105,10 +106,10 @@ def _boot(cs, args):
if args.max_count < 1:
raise exceptions.CommandError("max_count should be >= 1")
max_count = args.max_count
if (args.min_count is not None and args.max_count is not None and
if (args.min_count is not None and
args.max_count is not None and
args.min_count > args.max_count):
raise exceptions.CommandError(
"min_count should be <= max_count")
raise exceptions.CommandError("min_count should be <= max_count")
flavor = _find_flavor(cs, args.flavor)

2
tox.ini

@ -42,7 +42,7 @@ downloadcache = ~/cache/pip
# reason: removed in hacking (https://review.openstack.org/#/c/101701/)
#
# Additional checks are also ignored on purpose: F811, F821
ignore = E124,E128,E129,F811,F821,H402,H404,H405,H904
ignore = E124,E128,F811,F821,H402,H404,H405,H904
show-source = True
exclude=.venv,.git,.tox,dist,*openstack/common*,*lib/python*,*egg,build,doc/source/conf.py