openstack/python-novaclient
Code Issues Proposed changes

Fixed unit tests.

Browse Source
This commit is contained in:
Josh Kearney 2011-06-24 13:22:20 -05:00
parent ff87b8c449
commit 518ca43ef7
3 changed files with 4 additions and 3 deletions

1
novaclient/shell.py

@ -477,6 +477,7 @@ class OpenStackShell(object):
@arg('image_type', metavar='<image_type>', default='snapshot', help='daily, weekly or snapshot (default)') @arg('image_type', metavar='<image_type>', default='snapshot', help='daily, weekly or snapshot (default)')
@arg('--rotation', @arg('--rotation',
default=None, default=None,
type=int,
metavar='<rotation>', metavar='<rotation>',
help="Number of backups to retain. (for image-type daily or weekly)") help="Number of backups to retain. (for image-type daily or weekly)")
@arg('--name', @arg('--name',

2
tests/fakeserver.py

@ -336,7 +336,7 @@ class FakeClient(OpenStackClient):
def post_images(self, body, **kw): def post_images(self, body, **kw):
assert_equal(body.keys(), ['image']) assert_equal(body.keys(), ['image'])
assert_has_keys(body['image'], required=['serverId', 'name']) assert_has_keys(body['image'], required=['serverId', 'name', 'image_type', 'rotation'])
return (202, self.get_images_1()[1]) return (202, self.get_images_1()[1])
def delete_images_1(self, **kw): def delete_images_1(self, **kw):

4
tests/test_shell.py

@ -192,10 +192,10 @@ def test_image_list():
def test_image_create(): def test_image_create():
shell('image-create sample-server new-image') shell('image-create sample-server snapshot --name new-image')
assert_called( assert_called(
'POST', '/images', 'POST', '/images',
{'image': {'name': 'new-image', 'serverId': 1234}} {'image': {'name': 'new-image', 'serverId': 1234, 'image_type': 'snapshot', 'rotation': None}}
) )