openstack/python-novaclient
Code Issues Proposed changes

Fixed the subcommand error message for nova shell.

Browse Source 
Previously we were giving advice like this:

"Try 'nova volume-show help' for more information."

Bad advice -- that doesn't work. Now when there's a subcommand
specified we make a proper suggestion:

"Try 'nova help volume-show' for more information."

Change-Id: I6ef49f9e4e1b67074f51ab442abd4a196d437b00
This commit is contained in:
Andrew Bogott 2012-03-26 12:07:21 -05:00
parent 9485608cef
commit 565d144611
1 changed files with 6 additions and 2 deletions

8
novaclient/shell.py

@ -55,8 +55,12 @@ class NovaClientArgumentParser(argparse.ArgumentParser):
self.print_usage(sys.stderr)
#FIXME(lzyeval): if changes occur in argparse.ArgParser._check_value
choose_from = ' (choose from'
self.exit(2, "error: %s\nTry '%s help' for more information.\n" %
(message.split(choose_from)[0], self.prog))
progparts = self.prog.partition(' ')
self.exit(2, "error: %(errmsg)s\nTry '%(mainp)s help %(subp)s'"
" for more information.\n" %
{'errmsg': message.split(choose_from)[0],
'mainp': progparts[0],
'subp': progparts[2]})
class OpenStackComputeShell(object):