openstack/python-novaclient
Code Issues Proposed changes

Replace assertEqual(None, *) with assertIsNone in tests

Browse Source 
Replace assertEqual(None, *) with assertIsNone in tests to have
more clear messages in case of failure.

Change-Id: I6deee90c31adf61d80e2678a5f29ba9e187281c9
This commit is contained in:
zhang-jinnan 2014-02-17 20:09:28 +08:00
parent 7cf73f1942
commit 93f9e68ca2
2 changed files with 2 additions and 2 deletions

2
novaclient/tests/test_client.py

@ -205,7 +205,7 @@ class ClientTest(utils.TestCase):
def test_get_password_none(self):
cs = novaclient.client.HTTPClient("user", None, "", "")
self.assertEqual(cs._get_password(), None)
self.assertIsNone(cs._get_password())
def test_get_password_func(self):
cs = novaclient.client.HTTPClient("user", None, "", "")

2
novaclient/tests/v1_1/test_floating_ips.py

@ -41,7 +41,7 @@ class FloatingIPsTest(utils.TestCase):
def test_create_floating_ip(self):
fl = cs.floating_ips.create()
cs.assert_called('POST', '/os-floating-ips')
self.assertEqual(fl.pool, None)
self.assertIsNone(fl.pool)
self.assertIsInstance(fl, floating_ips.FloatingIP)
def test_create_floating_ip_with_pool(self):