openstack/python-novaclient
Code Issues Proposed changes

Update hosts API action calls (startup etc.)

Browse Source 
These calls are now implemented as normal
POST os-hosts/{host_name}/action requests.

Change-Id: I8cd401e3b4e552c6787d1f984041ad3c345e6eca
This commit is contained in:
Alessio Ababilov 2013-01-10 20:49:22 +04:00
parent 4410339a45
commit b5f3307e80
4 changed files with 11 additions and 22 deletions

5
novaclient/v1_1/hosts.py

@ -58,8 +58,9 @@ class HostManager(base.ManagerWithFind):
def host_action(self, host, action):
"""Performs an action on a host."""
url = "/os-hosts/%s/%s" % (host, action)
return self._create(url, None, "host")
body = {action: None}
url = '/os-hosts/%s/action' % host
return self.api.client.post(url, body=body)
def list_all(self, zone=None):
url = '/os-hosts'

13
tests/v1_1/fakes.py

@ -1159,17 +1159,8 @@ class FakeHTTPClient(base_client.HTTPClient):
'status': 'enabled',
'maintenance_mode': 'on_maintenance'}})
def post_os_hosts_sample_host_startup(self, **kw):
return (200, {}, {'host': {'host_name': 'sample_host',
'power_action': 'startup'}})
def post_os_hosts_sample_host_reboot(self, **kw):
return (200, {}, {'host': {'host_name': 'sample_host',
'power_action': 'reboot'}})
def post_os_hosts_sample_host_shutdown(self, **kw):
return (200, {}, {'host': {'host_name': 'sample_host',
'power_action': 'shutdown'}})
def post_os_hosts_sample_host_action(self, **kw):
return (202, {}, None)
def put_os_hosts_sample_host(self, body, **kw):
result = {'host_name': 'dummy'}

9
tests/v1_1/test_hosts.py

@ -50,17 +50,14 @@ class HostsTest(utils.TestCase):
def test_host_startup(self):
host = cs.hosts.get('sample_host')[0]
result = host.startup()
cs.assert_called('POST', '/os-hosts/sample_host/startup')
self.assertTrue(isinstance(result, hosts.Host))
cs.assert_called('POST', '/os-hosts/sample_host/action', {'startup': None})
def test_host_reboot(self):
host = cs.hosts.get('sample_host')[0]
result = host.reboot()
cs.assert_called('POST', '/os-hosts/sample_host/reboot')
self.assertTrue(isinstance(result, hosts.Host))
cs.assert_called('POST', '/os-hosts/sample_host/action', {'reboot': None})
def test_host_shutdown(self):
host = cs.hosts.get('sample_host')[0]
result = host.shutdown()
cs.assert_called('POST', '/os-hosts/sample_host/shutdown')
self.assertTrue(isinstance(result, hosts.Host))
cs.assert_called('POST', '/os-hosts/sample_host/action', {'shutdown': None})

6
tests/v1_1/test_shell.py

@ -634,15 +634,15 @@ class ShellTest(utils.TestCase):
def test_host_startup(self):
self.run_command('host-action sample-host --action startup')
self.assert_called('POST', '/os-hosts/sample-host/startup')
self.assert_called('POST', '/os-hosts/sample-host/action', {'startup': None})
def test_host_shutdown(self):
self.run_command('host-action sample-host --action shutdown')
self.assert_called('POST', '/os-hosts/sample-host/shutdown')
self.assert_called('POST', '/os-hosts/sample-host/action', {'shutdown': None})
def test_host_reboot(self):
self.run_command('host-action sample-host --action reboot')
self.assert_called('POST', '/os-hosts/sample-host/reboot')
self.assert_called('POST', '/os-hosts/sample-host/action', {'reboot': None})
def test_coverage_start(self):
self.run_command('coverage-start')