openstack/python-novaclient
Code Issues Proposed changes

100% test coverage for security groups and rules

Browse Source 
This patch achieves full test coverage for security_group and
security_group_rules by:

- Fixing the arguments used in test_invalid_parameters_create
- Testing the __str__ and delete methods of SecurityGroupRule
- Adding a test for the ___str__ method of SecurityGroup

Change-Id: I9cfbc68761f158754aa4b339238d29cc587c91e1
This commit is contained in:
Emanuele Rocca 2013-05-24 19:04:37 +02:00
parent c34c371e96
commit ff85bd4025
2 changed files with 16 additions and 6 deletions

21
novaclient/tests/v1_1/test_security_group_rules.py

@ -49,11 +49,20 @@ class SecurityGroupRulesTest(utils.TestCase):
def test_invalid_parameters_create(self):
self.assertRaises(exceptions.CommandError,
cs.security_group_rules.create, "secgrouprulecreate",
1, "invalid", 1, 65535, "10.0.0.0/16")
cs.security_group_rules.create,
1, "invalid_ip_protocol", 1, 65535, "10.0.0.0/16", 101)
self.assertRaises(exceptions.CommandError,
cs.security_group_rules.create, "secgrouprulecreate",
1, "tcp", "invalid", 65535, "10.0.0.0/16")
cs.security_group_rules.create,
1, "tcp", "invalid_from_port", 65535, "10.0.0.0/16", 101)
self.assertRaises(exceptions.CommandError,
cs.security_group_rules.create, "secgrouprulecreate",
1, "tcp", 1, "invalid", "10.0.0.0/16")
cs.security_group_rules.create,
1, "tcp", 1, "invalid_to_port", "10.0.0.0/16", 101)
def test_security_group_rule_str(self):
sg = cs.security_group_rules.create(1, "tcp", 1, 65535, "10.0.0.0/16")
self.assertEquals('1', str(sg))
def test_security_group_rule_del(self):
sg = cs.security_group_rules.create(1, "tcp", 1, 65535, "10.0.0.0/16")
sg.delete()
cs.assert_called('DELETE', '/os-security-group-rules/1')

1
novaclient/tests/v1_1/test_security_groups.py

@ -29,6 +29,7 @@ class SecurityGroupsTest(utils.TestCase):
sg = cs.security_groups.get(1)
cs.assert_called('GET', '/os-security-groups/1')
self.assertTrue(isinstance(sg, security_groups.SecurityGroup))
self.assertEquals('1', str(sg))
def test_delete_security_group(self):
sg = cs.security_groups.list()[0]