openstack/python-openstackclient
Code Issues Proposed changes

identity: Use previous naming for 'application credential show' fields

Browse Source 
We changed these in change Iba3fee2672d32266623c6f367beaabe84bd3d24e but
the '-c/--column' option provided by cliff currently requires an
explicit match on column names. Change them back for now. We can revert
this when cliff is a little bit cleverer.

Change-Id: I6b4f1b793dc383856bfdf9a01514381be3cd2bf1
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Related-bug: #2076212
This commit is contained in:
Stephen Finucane 2024-08-07 17:00:23 +01:00
parent a59262e44d
commit 0e731cd22f
3 changed files with 41 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
openstackclient/identity/v3/application_credential.py
View File

@ -186,15 +186,15 @@ class CreateApplicationCredential(command.ShowOne):
application_credential['roles'] = msg
columns = (
'ID',
'Name',
'Description',
'Project ID',
'Roles',
'Unrestricted',
'Access Rules',
'Expires At',
'Secret',
'id',
'name',
'description',
'project_id',
'roles',
'unrestricted',
'access_rules',
'expires_at',
'secret',
)
return (
columns,
@ -337,14 +337,14 @@ class ShowApplicationCredential(command.ShowOne):
app_cred['roles'] = msg
columns = (
'ID',
'Name',
'Description',
'Project ID',
'Roles',
'Unrestricted',
'Access Rules',
'Expires At',
'id',
'name',
'description',
'project_id',
'roles',
'unrestricted',
'access_rules',
'expires_at',
)
return (
columns,

14
openstackclient/tests/functional/identity/v3/test_application_credential.py
View File

@ -21,13 +21,13 @@ from openstackclient.tests.functional.identity.v3 import common
class ApplicationCredentialTests(common.IdentityTests):
APPLICATION_CREDENTIAL_FIELDS = [
'ID',
'Name',
'Project ID',
'Description',
'Roles',
'Expires At',
'Unrestricted',
'id',
'name',
'project_id',
'description',
'roles',
'expires_at',
'unrestricted',
]
APPLICATION_CREDENTIAL_LIST_HEADERS = [
'ID',

34
openstackclient/tests/unit/identity/v3/test_application_credential.py
View File

@ -31,15 +31,15 @@ from openstackclient.tests.unit.identity.v3 import fakes as identity_fakes
class TestApplicationCredentialCreate(identity_fakes.TestIdentityv3):
columns = (
'ID',
'Name',
'Description',
'Project ID',
'Roles',
'Unrestricted',
'Access Rules',
'Expires At',
'Secret',
'id',
'name',
'description',
'project_id',
'roles',
'unrestricted',
'access_rules',
'expires_at',
'secret',
)
def setUp(self):
@ -413,14 +413,14 @@ class TestApplicationCredentialShow(identity_fakes.TestIdentityv3):
)
collist = (
'ID',
'Name',
'Description',
'Project ID',
'Roles',
'Unrestricted',
'Access Rules',
'Expires At',
'id',
'name',
'description',
'project_id',
'roles',
'unrestricted',
'access_rules',
'expires_at',
)
self.assertEqual(collist, columns)
datalist = (