openstack/python-openstackclient
Code Issues Proposed changes

Don't create empty quota set requests

Browse Source 
The way that getattr is called with the None default you will always
create a compute_kwargs dictionary with key: None values. This means
that we will always send these empty requests to the servers.

Change so that only actually changed values end up in the quota set
requests and get sent.

Change-Id: I33bc3f4e1a8013ec672e995648d27513064baf26
Closes-Bug: #1451640
This commit is contained in:
Jamie Lennox 2015-05-05 12:43:12 +10:00
parent b50ff9d3c5
commit 179ed18c30
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
openstackclient/common/quota.py
View File

@ -97,8 +97,9 @@ class SetQuota(command.Command):
compute_kwargs = {} compute_kwargs = {}
for k, v in COMPUTE_QUOTAS.items(): for k, v in COMPUTE_QUOTAS.items():
if v in parsed_args: value = getattr(parsed_args, v, None)
compute_kwargs[k] = getattr(parsed_args, v, None) if value is not None:
compute_kwargs[k] = value
volume_kwargs = {} volume_kwargs = {}
for k, v in VOLUME_QUOTAS.items(): for k, v in VOLUME_QUOTAS.items():