openstack/python-openstackclient
Code Issues Proposed changes

Merge "Use assertItemsEqual() instead of assertListEqual()"

Browse Source
This commit is contained in:
Jenkins 2016-03-14 16:09:49 +00:00 committed by Gerrit Code Review
commit 2f6b48e039
1 changed files with 2 additions and 10 deletions

12
openstackclient/tests/common/test_parseractions.py

@ -91,11 +91,7 @@ class TestMultiKeyValueAction(utils.TestCase):
{'req1': 'aaa', 'req2': 'bbb'},
{'req1': '', 'req2': ''},
]
# Need to sort the lists before comparing them
key = lambda x: x['req1']
expect.sort(key=key)
actual.sort(key=key)
self.assertListEqual(expect, actual)
self.assertItemsEqual(expect, actual)
def test_empty_required_optional(self):
self.parser.add_argument(
@ -119,11 +115,7 @@ class TestMultiKeyValueAction(utils.TestCase):
{'req1': 'aaa', 'req2': 'bbb'},
{'req1': '', 'req2': ''},
]
# Need to sort the lists before comparing them
key = lambda x: x['req1']
expect.sort(key=key)
actual.sort(key=key)
self.assertListEqual(expect, actual)
self.assertItemsEqual(expect, actual)
def test_error_values_with_comma(self):
self.assertRaises(