openstack/python-openstackclient
Code Issues Proposed changes

Merge "Batch up minor cleanups for release"

Browse Source
This commit is contained in:
Zuul 2019-06-06 23:19:12 +00:00 committed by Gerrit Code Review
commit 57dec524c8
5 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openstackclient/tests/functional/network/v2/test_floating_ip.py
View File

@ -83,7 +83,7 @@ class FloatingIpTests(common.NetworkTests):
raise raise
pass pass
else: else:
# break and no longer retry if create sucessfully # break and no longer retry if create successfully
break break
@classmethod @classmethod

4
openstackclient/tests/functional/network/v2/test_subnet_pool.py
View File

@ -266,7 +266,7 @@ class SubnetPoolTests(common.NetworkTagTests):
# pool. The error appears to be in a lower layer, # pool. The error appears to be in a lower layer,
# once that is fixed add a test for subnet pool unset # once that is fixed add a test for subnet pool unset
# --default-quota. # --default-quota.
# The unset command of --pool-prefixes also doesnt work # The unset command of --pool-prefixes also doesn't work
# right now. It would be fixed in a separate patch once # right now. It would be fixed in a separate patch once
# the lower layer is fixed. # the lower layer is fixed.
# cmd_output = self.openstack( # cmd_output = self.openstack(
@ -319,7 +319,7 @@ class SubnetPoolTests(common.NetworkTagTests):
raise raise
pass pass
else: else:
# Break and no longer retry if create is sucessful # Break and no longer retry if create is successful
break break
return cmd_output, pool_prefix return cmd_output, pool_prefix

4
releasenotes/notes/bug-1633582-df2bee534c2da7fc.yaml
View File

@ -2,8 +2,8 @@
deprecations: deprecations:
- | - |
``volume transfer request accept`` has been changed to move the ``auth-key`` ``volume transfer request accept`` has been changed to move the ``auth-key``
positional argument to a requried option ``--auth-key``. This leaves positional argument to a required option ``--auth-key``. This leaves
the transfer request ID as the only positional arguemnt, as per the the transfer request ID as the only positional argument, as per the
OpenStackClient command format. The old format is still functional, but is OpenStackClient command format. The old format is still functional, but is
deprecated and will be removed in the next major release. deprecated and will be removed in the next major release.
fixes: fixes:

2
releasenotes/notes/bug-27882-402ced7ffe930058.yaml
View File

@ -2,4 +2,4 @@
fixes: fixes:
- | - |
The ``--limit`` option of the ``image list`` command was previously ignored. The ``--limit`` option of the ``image list`` command was previously ignored.
[Bug `https://storyboard.openstack.org/#!/story/2004314`] [Bug `2004314 <https://storyboard.openstack.org/#!/story/2004314>`_]

2
releasenotes/source/pre_20_releases.rst
View File

@ -347,7 +347,7 @@ Pre-2.0 Releases
``--proto ICMP`` is selected. ``--proto ICMP`` is selected.
Bug `1443963 <https://bugs.launchpad.net/bugs/1443963>`_ Bug `1443963 <https://bugs.launchpad.net/bugs/1443963>`_
* Correctly pass ``--location`` arguemnt in ``image create`` command. * Correctly pass ``--location`` argument in ``image create`` command.
Bug `1445460 <https://bugs.launchpad.net/bugs/1445460>`_ Bug `1445460 <https://bugs.launchpad.net/bugs/1445460>`_
* Correctly handle use of ``role`` commands for project admins. Using IDs will * Correctly handle use of ``role`` commands for project admins. Using IDs will