openstack/python-openstackclient
Code Issues Proposed changes

Replace assertEqual(None, *) with assertIsNone(*)

Browse Source 
This patch is going to replace assertEqual(None, *) with
assertIsNone(*) in unit test code to have more clear messages
in case of failure.

Change-Id: I6f85498347e8fc7cad5ea7afb832b9acda7daafc
This commit is contained in:
Xi Yang
2015-12-25 13:14:33 +08:00
parent d1311f9742
commit 8210ba7a55
1 changed files with 1 additions and 1 deletions

2
openstackclient/tests/common/test_parseractions.py

@ -101,7 +101,7 @@ class TestKeyValueAction(utils.TestCase):
# There should be no red or blue # There should be no red or blue
expect = {'green': '100%'} expect = {'green': '100%'}
self.assertDictEqual(expect, actual) self.assertDictEqual(expect, actual)
self.assertEqual(None, failhere) self.assertIsNone(failhere)
class TestNonNegativeAction(utils.TestCase): class TestNonNegativeAction(utils.TestCase):