openstack/python-openstackclient
Code Issues Proposed changes

Provide fallback prompt function for current osc-lib

Browse Source 
Leaving the pw_func uninitialize in osc-lib turned out to be a
bad idea as the test to prompt in setup_auth() doesn't check
for a callback of None.

Also, release note

Change-Id: I8f875fa8a942d02a040238359ee22c603a4e5956
This commit is contained in:
Dean Troyer 2016-08-29 18:14:26 -05:00
parent c5f8f761de
commit 84c83fc3ae
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
openstackclient/common/clientmanager.py
View File

@ -20,6 +20,7 @@ import pkg_resources
import sys import sys
from osc_lib import clientmanager from osc_lib import clientmanager
from osc_lib import shell
LOG = logging.getLogger(__name__) LOG = logging.getLogger(__name__)
@ -48,6 +49,8 @@ class ClientManager(clientmanager.ClientManager):
super(ClientManager, self).__init__( super(ClientManager, self).__init__(
cli_options=cli_options, cli_options=cli_options,
api_version=api_version, api_version=api_version,
# TODO(dtroyer): Remove this when osc-lib 1.2 is released
pw_func=shell.prompt_for_password,
) )
# TODO(dtroyer): For compatibility; mark this for removal when plugin # TODO(dtroyer): For compatibility; mark this for removal when plugin

5
releasenotes/notes/bug-1617384-55c88207115e2a5b.yaml Normal file
View File

@ -0,0 +1,5 @@
---
fixes:
- |
Fix prompting for password issue introduced in release 3.0.0
[Bug `1617384 <https://bugs.launchpad.net/bugs/1617384>`_]