From a7a0d0c61a6a88e044b781bbc4903cdcfc919e55 Mon Sep 17 00:00:00 2001 From: Vijendra Soni Date: Fri, 11 Nov 2016 20:01:05 +0530 Subject: [PATCH] Sort list images by name by default Set the default key and dir for openstack image list, if no command line argument passed Changing sort_key to name(old value: created_at) Change-Id: I6c61f6e5a04824d655ccf43477afcec9652101df Closes-Bug: #1639231 --- doc/source/command-objects/image.rst | 2 +- openstackclient/image/v1/image.py | 3 ++- openstackclient/image/v2/image.py | 3 ++- releasenotes/notes/bug-1639231-21823768bd54170a.yaml | 6 ++++++ 4 files changed, 11 insertions(+), 3 deletions(-) create mode 100644 releasenotes/notes/bug-1639231-21823768bd54170a.yaml diff --git a/doc/source/command-objects/image.rst b/doc/source/command-objects/image.rst index 842eab8d8a..84e6baa500 100644 --- a/doc/source/command-objects/image.rst +++ b/doc/source/command-objects/image.rst @@ -221,7 +221,7 @@ List available images .. option:: --sort [:] - Sort output by selected keys and directions(asc or desc) (default: asc), + Sort output by selected keys and directions(asc or desc) (default: name:asc), multiple keys and directions can be specified separated by comma .. option:: --limit diff --git a/openstackclient/image/v1/image.py b/openstackclient/image/v1/image.py index 5f669c6412..26ce1aac90 100644 --- a/openstackclient/image/v1/image.py +++ b/openstackclient/image/v1/image.py @@ -350,8 +350,9 @@ class ListImage(command.Lister): parser.add_argument( '--sort', metavar="[:]", + default='name:asc', help=_("Sort output by selected keys and directions(asc or desc) " - "(default: asc), multiple keys and directions can be " + "(default: name:asc), multiple keys and directions can be " "specified separated by comma"), ) return parser diff --git a/openstackclient/image/v2/image.py b/openstackclient/image/v2/image.py index 0712e09c07..2edec9db2d 100644 --- a/openstackclient/image/v2/image.py +++ b/openstackclient/image/v2/image.py @@ -447,8 +447,9 @@ class ListImage(command.Lister): parser.add_argument( '--sort', metavar="[:]", + default='name:asc', help=_("Sort output by selected keys and directions(asc or desc) " - "(default: asc), multiple keys and directions can be " + "(default: name:asc), multiple keys and directions can be " "specified separated by comma"), ) parser.add_argument( diff --git a/releasenotes/notes/bug-1639231-21823768bd54170a.yaml b/releasenotes/notes/bug-1639231-21823768bd54170a.yaml new file mode 100644 index 0000000000..740a0dd1b8 --- /dev/null +++ b/releasenotes/notes/bug-1639231-21823768bd54170a.yaml @@ -0,0 +1,6 @@ +--- +features: + - | + The ``image list`` command will now sort by name in ascending order by + default. ``--sort`` option will have the default value of ``name:asc``. + [Bug `1639231 `_]