openstack/python-openstackclient
Code Issues Proposed changes

Merge "Be robust on import plugin module"

Browse Source
This commit is contained in:
Zuul 2017-11-08 05:17:21 +00:00 committed by Gerrit Code Review
commit b230ba73cd
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
openstackclient/common/clientmanager.py
View File

@ -134,7 +134,13 @@ def get_plugin_modules(group):
for ep in pkg_resources.iter_entry_points(group): for ep in pkg_resources.iter_entry_points(group):
LOG.debug('Found plugin %r', ep.name) LOG.debug('Found plugin %r', ep.name)
__import__(ep.module_name) try:
__import__(ep.module_name)
except Exception:
sys.stderr.write(
"WARNING: Failed to import plugin %r.\n" % ep.name)
continue
module = sys.modules[ep.module_name] module = sys.modules[ep.module_name]
mod_list.append(module) mod_list.append(module)
init_func = getattr(module, 'Initialize', None) init_func = getattr(module, 'Initialize', None)