openstack/python-openstackclient
Code Issues Proposed changes

Fix SSL/TLS verification for network commands

Browse Source 
The network commands ignored the --insecure and --os-cacert
options and OS_CACERT environment variable which prevented
them from properly completing SSL/TLS verification. This
resulted in the network commands failing with
"An SSL error occurred."

Change-Id: I15167631ef58335e1476c16b828b079e3b0f13c1
Closes-Bug: #1560157
This commit is contained in:
Richard Theis 2016-04-07 16:35:38 -05:00
parent 9f2e7039e1
commit b5f10f43eb
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
openstackclient/network/client.py
View File

@ -31,7 +31,8 @@ API_VERSIONS = {
def make_client(instance): def make_client(instance):
"""Returns a network proxy""" """Returns a network proxy"""
conn = connection.Connection(authenticator=instance.session.auth) conn = connection.Connection(authenticator=instance.session.auth,
verify=instance.session.verify)
LOG.debug('Connection: %s', conn) LOG.debug('Connection: %s', conn)
LOG.debug('Network client initialized using OpenStack SDK: %s', LOG.debug('Network client initialized using OpenStack SDK: %s',
conn.network) conn.network)

7
releasenotes/notes/bug-1560157-bce572f58b43efa1.yaml Normal file
View File

@ -0,0 +1,7 @@
---
fixes:
- Fixed SSL/TLS verification for Network v2 commands. The commands
were ignoring the ``--insecure`` and ``--os-cacert`` options and
the ``OS_CACERT`` environment variable which caused them to fail
with ``An SSL error occurred.`` when authenticating using SSL/TLS.
[Bug `1560157 <https://bugs.launchpad.net/python-openstackclient/+bug/1560157>`_]