openstack/python-openstackclient
Code Issues Proposed changes

" openstack server image create " doesn't print proper info

Browse Source 
After creating a snapshot of a running instance, a print out similar
to server create is expected, but it prints out something like "_info"
which is nothing related to created image. _prep_image_detail method
is added to /compute/v2/server.py to enable the priting, while running
the test properly.

Change-Id: I4b06be959768bcdaafd9aa8df497490958bee649
Closes-Bug:1551586
This commit is contained in:
Mohan Muppidi 2016-03-01 07:13:09 +00:00
parent 7039cd3447
commit e354d17d2c
1 changed files with 19 additions and 5 deletions

24
openstackclient/compute/v2/server.py

@ -161,6 +161,23 @@ def _prep_server_detail(compute_client, server):
return info
def _prep_image_detail(image_client, image_id):
"""Prepare the detailed image dict for printing
:param image_client: an image client instance
:param image_id: id of image created
:rtype: a dict of image details
"""
info = utils.find_resource(
image_client.images,
image_id,
)
# Glance client V2 doesn't have _info attribute
# The following condition deals with it.
return getattr(info, "_info", info)
def _show_progress(progress):
if progress:
sys.stdout.write('\rProgress: %s' % progress)
@ -622,12 +639,9 @@ class CreateServerImage(command.ShowOne):
sys.stdout.write(_('\nError creating server snapshot'))
raise SystemExit
image = utils.find_resource(
image_client.images,
image_id,
)
image = _prep_image_detail(image_client, image_id)
return zip(*sorted(six.iteritems(image._info)))
return zip(*sorted(six.iteritems(image)))
class DeleteServer(command.Command):