From f4629331134c40599f9baf908a391460b74d2767 Mon Sep 17 00:00:00 2001
From: Slawek Kaplonski <skaplons@redhat.com>
Date: Tue, 23 Nov 2021 21:56:56 +0100
Subject: [PATCH] Allow unset port's host_id

It is supported by Neutron and needs to be done like that when e.g.
admin wants to unbound port from the host.

Task: #44043
Story: #2009705
Change-Id: I08f1bb40f4dc72cfa7c62feeb5f513455de0ca45
---
 openstackclient/network/v2/port.py                        | 8 ++++++++
 openstackclient/tests/unit/network/v2/test_port.py        | 5 ++++-
 .../add-option-to-unset-port-host-c76de9b1d2addf9a.yaml   | 5 +++++
 3 files changed, 17 insertions(+), 1 deletion(-)
 create mode 100644 releasenotes/notes/add-option-to-unset-port-host-c76de9b1d2addf9a.yaml

diff --git a/openstackclient/network/v2/port.py b/openstackclient/network/v2/port.py
index 132c384a0e..8f79b80b0b 100644
--- a/openstackclient/network/v2/port.py
+++ b/openstackclient/network/v2/port.py
@@ -969,6 +969,12 @@ class UnsetPort(common.NeutronUnsetCommandWithExtraArgs):
             action='store_true',
             help=_("Clear existing NUMA affinity policy")
         )
+        parser.add_argument(
+            '--host',
+            action='store_true',
+            default=False,
+            help=_("Clear host binding for the port.")
+        )
 
         _tag.add_tag_option_to_parser_for_unset(parser, _('port'))
 
@@ -1026,6 +1032,8 @@ class UnsetPort(common.NeutronUnsetCommandWithExtraArgs):
             attrs['data_plane_status'] = None
         if parsed_args.numa_policy:
             attrs['numa_affinity_policy'] = None
+        if parsed_args.host:
+            attrs['binding:host_id'] = None
 
         attrs.update(
             self._parse_extra_properties(parsed_args.extra_properties))
diff --git a/openstackclient/tests/unit/network/v2/test_port.py b/openstackclient/tests/unit/network/v2/test_port.py
index 5f2a12836a..c8540ba057 100644
--- a/openstackclient/tests/unit/network/v2/test_port.py
+++ b/openstackclient/tests/unit/network/v2/test_port.py
@@ -1923,6 +1923,7 @@ class TestUnsetPort(TestPort):
             'subnet=042eb10a-3a18-4658-ab-cf47c8d03152,ip-address=1.0.0.0',
             '--binding-profile', 'Superman',
             '--qos-policy',
+            '--host',
             self._testport.name,
         ]
         verifylist = [
@@ -1931,6 +1932,7 @@ class TestUnsetPort(TestPort):
                 'ip-address': '1.0.0.0'}]),
             ('binding_profile', ['Superman']),
             ('qos_policy', True),
+            ('host', True)
         ]
 
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
@@ -1941,7 +1943,8 @@ class TestUnsetPort(TestPort):
                 'subnet_id': '042eb10a-3a18-4658-ab-cf47c8d03152',
                 'ip_address': '0.0.0.1'}],
             'binding:profile': {'batman': 'Joker'},
-            'qos_policy_id': None
+            'qos_policy_id': None,
+            'binding:host_id': None
         }
         self.network.update_port.assert_called_once_with(
             self._testport, **attrs)
diff --git a/releasenotes/notes/add-option-to-unset-port-host-c76de9b1d2addf9a.yaml b/releasenotes/notes/add-option-to-unset-port-host-c76de9b1d2addf9a.yaml
new file mode 100644
index 0000000000..0aa0476050
--- /dev/null
+++ b/releasenotes/notes/add-option-to-unset-port-host-c76de9b1d2addf9a.yaml
@@ -0,0 +1,5 @@
+---
+features:
+  - |
+    Add possibility to unbind Neutron's port from the host by unsetting its
+    host_id.