openstack/python-openstackclient
Code Issues Proposed changes

Refactor: Abstract columns out in TestFlavorList to avoid redundant code.

Browse Source 
The columns has been set in each test case of TestFlavorList, which is not
necessary. This patch abstract it out and remove all redundant code.

Change-Id: Ideb2872f073755ac251bd603fd906410ea86c4ef
Implements: blueprint improve-flavor-unit-tes
This commit is contained in:
Tang Chen 2015-11-28 14:05:20 +08:00
parent 8d523266fc
commit f9ca752177
1 changed files with 20 additions and 53 deletions

73
openstackclient/tests/compute/v2/test_flavor.py

@ -47,6 +47,21 @@ class TestFlavor(compute_fakes.TestComputev2):
class TestFlavorList(TestFlavor):
columns = (
'ID',
'Name',
'RAM',
'Disk',
'Ephemeral',
'VCPUs',
'Is Public',
)
columns_long = columns + (
'Swap',
'RXTX Factor',
'Properties'
)
def setUp(self):
super(TestFlavorList, self).setUp()
@ -85,16 +100,7 @@ class TestFlavorList(TestFlavor):
**kwargs
)
collist = (
'ID',
'Name',
'RAM',
'Disk',
'Ephemeral',
'VCPUs',
'Is Public',
)
self.assertEqual(collist, columns)
self.assertEqual(self.columns, columns)
datalist = ((
compute_fakes.flavor_id,
compute_fakes.flavor_name,
@ -130,16 +136,7 @@ class TestFlavorList(TestFlavor):
**kwargs
)
collist = (
'ID',
'Name',
'RAM',
'Disk',
'Ephemeral',
'VCPUs',
'Is Public',
)
self.assertEqual(collist, columns)
self.assertEqual(self.columns, columns)
datalist = ((
compute_fakes.flavor_id,
compute_fakes.flavor_name,
@ -175,16 +172,7 @@ class TestFlavorList(TestFlavor):
**kwargs
)
collist = (
'ID',
'Name',
'RAM',
'Disk',
'Ephemeral',
'VCPUs',
'Is Public',
)
self.assertEqual(collist, columns)
self.assertEqual(self.columns, columns)
datalist = ((
compute_fakes.flavor_id,
compute_fakes.flavor_name,
@ -220,16 +208,7 @@ class TestFlavorList(TestFlavor):
**kwargs
)
collist = (
'ID',
'Name',
'RAM',
'Disk',
'Ephemeral',
'VCPUs',
'Is Public',
)
self.assertEqual(collist, columns)
self.assertEqual(self.columns, columns)
datalist = ((
compute_fakes.flavor_id,
compute_fakes.flavor_name,
@ -265,19 +244,7 @@ class TestFlavorList(TestFlavor):
**kwargs
)
collist = (
'ID',
'Name',
'RAM',
'Disk',
'Ephemeral',
'VCPUs',
'Is Public',
'Swap',
'RXTX Factor',
'Properties'
)
self.assertEqual(collist, columns)
self.assertEqual(self.columns_long, columns)
datalist = ((
compute_fakes.flavor_id,
compute_fakes.flavor_name,