From 15c9576817c5925ebf89835a2c35b7b7524d4e57 Mon Sep 17 00:00:00 2001
From: Tang Chen <chen.tang@easystack.cn>
Date: Fri, 6 May 2016 19:55:50 +0800
Subject: [PATCH] Trivial: Remove unuseful comments for assertRaise() checking
"Missing required args should bail here" is not understandable
and not necessary. The code is obvious enough. And some of the
comments are misused because of code copy. So remove them.
Change-Id: I031395f2c882386c7a708db5cf4eee75393dc639
---
openstackclient/tests/compute/v2/test_server.py | 1 -
openstackclient/tests/network/v2/test_floating_ip.py | 2 --
openstackclient/tests/network/v2/test_network.py | 3 ---
openstackclient/tests/network/v2/test_router.py | 8 --------
openstackclient/tests/network/v2/test_subnet_pool.py | 2 --
5 files changed, 16 deletions(-)
diff --git a/openstackclient/tests/compute/v2/test_server.py b/openstackclient/tests/compute/v2/test_server.py
index 17681672b5..2e74545746 100644
--- a/openstackclient/tests/compute/v2/test_server.py
+++ b/openstackclient/tests/compute/v2/test_server.py
@@ -146,7 +146,6 @@ class TestServerCreate(TestServer):
('server_name', self.new_server.name),
]
- # Missing required args should bail here
self.assertRaises(utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
diff --git a/openstackclient/tests/network/v2/test_floating_ip.py b/openstackclient/tests/network/v2/test_floating_ip.py
index 3e261fb5ef..f9ccfe1c74 100644
--- a/openstackclient/tests/network/v2/test_floating_ip.py
+++ b/openstackclient/tests/network/v2/test_floating_ip.py
@@ -88,7 +88,6 @@ class TestCreateFloatingIPNetwork(TestFloatingIPNetwork):
arglist = []
verifylist = []
- # Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@@ -314,7 +313,6 @@ class TestCreateFloatingIPCompute(TestFloatingIPCompute):
arglist = []
verifylist = []
- # Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
diff --git a/openstackclient/tests/network/v2/test_network.py b/openstackclient/tests/network/v2/test_network.py
index 9c521a23c3..1269b0a101 100644
--- a/openstackclient/tests/network/v2/test_network.py
+++ b/openstackclient/tests/network/v2/test_network.py
@@ -112,7 +112,6 @@ class TestCreateNetworkIdentityV3(TestNetwork):
arglist = []
verifylist = []
- # Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@@ -599,7 +598,6 @@ class TestShowNetwork(TestNetwork):
arglist = []
verifylist = []
- # Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@@ -916,7 +914,6 @@ class TestShowNetworkCompute(TestNetworkCompute):
arglist = []
verifylist = []
- # Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
diff --git a/openstackclient/tests/network/v2/test_router.py b/openstackclient/tests/network/v2/test_router.py
index ead919b283..655e86c95e 100644
--- a/openstackclient/tests/network/v2/test_router.py
+++ b/openstackclient/tests/network/v2/test_router.py
@@ -47,7 +47,6 @@ class TestAddPortToRouter(TestRouter):
arglist = []
verifylist = []
- # Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@@ -88,7 +87,6 @@ class TestAddSubnetToRouter(TestRouter):
arglist = []
verifylist = []
- # Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@@ -154,7 +152,6 @@ class TestCreateRouter(TestRouter):
arglist = []
verifylist = []
- # Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@@ -335,7 +332,6 @@ class TestRemovePortFromRouter(TestRouter):
arglist = []
verifylist = []
- # Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@@ -375,7 +371,6 @@ class TestRemoveSubnetFromRouter(TestRouter):
arglist = []
verifylist = []
- # Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@@ -475,7 +470,6 @@ class TestSetRouter(TestRouter):
('distributed', False),
]
- # Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@@ -534,7 +528,6 @@ class TestSetRouter(TestRouter):
('clear_routes', True),
]
- # Argument parse failing should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@@ -591,7 +584,6 @@ class TestShowRouter(TestRouter):
arglist = []
verifylist = []
- # Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
diff --git a/openstackclient/tests/network/v2/test_subnet_pool.py b/openstackclient/tests/network/v2/test_subnet_pool.py
index 7797e4d053..de12c9e9df 100644
--- a/openstackclient/tests/network/v2/test_subnet_pool.py
+++ b/openstackclient/tests/network/v2/test_subnet_pool.py
@@ -109,7 +109,6 @@ class TestCreateSubnetPool(TestSubnetPool):
arglist = []
verifylist = []
- # Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)
@@ -624,7 +623,6 @@ class TestShowSubnetPool(TestSubnetPool):
arglist = []
verifylist = []
- # Missing required args should bail here
self.assertRaises(tests_utils.ParserException, self.check_parser,
self.cmd, arglist, verifylist)