2486 Commits

Author SHA1 Message Date
Jenkins
f48f9398b8 Merge "Add fixed keypair create functional test" 2016-03-31 02:47:00 +00:00
Jenkins
f3b58238dd Merge "Add unit tests for compute v2 aggregate" 2016-03-30 23:23:57 +00:00
Jenkins
01b2a0c49f Merge "Add "aggregate unset" to osc" 2016-03-30 23:21:37 +00:00
Jenkins
a73926556f Merge "Fix subnet pool prefix length option" 2016-03-30 22:10:30 +00:00
Jenkins
e666a8ab74 Merge "Aggregate object should be "grouping of compute hosts"" 2016-03-30 21:41:30 +00:00
Dean Troyer
029654b9a8 Add fixed keypair create functional test
This adds a test case to exercise the --public-key option of
the 'keypair create' command.  It is a follow-on to
I7a299a542d9df543bff43d3ea1e7907fc8c5f640 that fixed a key file
read bug.

Change-Id: Id78c1c7ece02f619aca69dc397185fc426b92306
2016-03-30 15:58:42 -05:00
Richard Theis
9174bc0f02 Fix subnet pool prefix length option
Fix the --min-prefix-length, --max-prefix-length and
--default-prefix-length options for the "os subnet pool create" and
"os subnet pool set" commands. Using these options caused the
commands to fail with "HttpException: Bad Request" because unrecognized
attributes were passed to the REST API.

No release note was added since these commands are new and haven't
been released.

Change-Id: I2f765750f79dc91d6c1f5962f699fbf2ee38657a
Closes-Bug: #1564004
2016-03-30 13:28:31 -05:00
Sheel Rana
63c57eb56e Wrong param type in compute-service.rst
compute-service.rst file uses 'describe' for below
optional parameters

1. --long
2. --service <service>
3. --host <host>

This patchset changes type of these argument to option.

Change-Id: Ifd57bdf058efaeaa6cb43a7d4a60ee61ddb8de14
Closes-bug:#1563700
2016-03-30 14:45:41 +00:00
Jenkins
9e7f0cf1a5 Merge "Remove unused method 'from_response'" 2016-03-29 16:33:04 +00:00
Jenkins
8233b923f1 Merge "Docs cleanup: volume type" 2016-03-29 13:22:10 +00:00
Wenzhi Yu
848d5312ff Remove unused method 'from_response'
'openstackclient.common.exceptions.from_response' method is never called
in openstackclient code base, so we should remove it.

Change-Id: I04254a4e66863942e6c273d77bbd66ce2ce7804c
Related-Bug: #1559072
2016-03-29 17:28:24 +08:00
Rui Chen
b2e47b6228 Aggregate object should be "grouping of compute hosts"
The describe of Compute "aggregate" in command-objects and commands
documents use "a grouping of servers", but exactly that should be a
grouping of compute hosts. "server" object in OSC is a virtual machine
instance, and server group should be "grouping of servers".

Change-Id: Ib034fed15f11fc3e756985b3131a9922129ed6bf
Closes-Bug: #1563172
Related-Bug: #1542171
2016-03-29 12:01:31 +08:00
Jenkins
62a6a497bd Merge "Docs cleanup: volume command help" 2016-03-29 02:20:01 +00:00
Dean Troyer
a3a2a7e9f0 Docs cleanup: volume command help
This formats the volume command help text consistent with the rest of OSC,
adds some reference targets and some explanation text to some commands.

No functional changes have been made, only cosmetic/help output.

Change-Id: Ib86ec3ca58bdea5f33078ced3ec3583b2be0e89a
2016-03-28 18:25:58 -05:00
Jenkins
0a760e2d87 Merge "Added functional tests for 'service provider' v3 commands" 2016-03-28 20:54:59 +00:00
Dean Troyer
b4402a0468 Docs cleanup: volume type
Clean up volume type command help, add volume type show to doc, sort
command classes in v1/volume_type.py.

Change-Id: I1f8e5c047d9c08f5704fc23cfb694f23d32e3caf
2016-03-28 14:33:24 -05:00
Dean Troyer
9d65abcaa6 Docs cleanup: sort subnet commands
Change-Id: I43c0052ec5ed2e94b203a0befc4b39d3522d4e9c
2016-03-28 13:08:07 -05:00
Richard Theis
c5b58a47b0 Refactor security group rule list to use SDK
Refactored the 'os security group rule list' command to use the
SDK when neutron is enabled, but continue to use the nova client
when nova network is enabled.

In addition, a release note was added to document the features
and fixes resulting from this refactor.

Change-Id: I24d04b720102ed1c60776e1ca67d4ca20e31b663
Partial-Bug: #1519512
Implements: blueprint neutron-client
2016-03-28 12:25:51 -05:00
Jenkins
5f55e99d46 Merge "Support security group name for --src-group" 2016-03-28 15:57:31 +00:00
Kristi Nikolla
add0e10026 Added functional tests for 'service provider' v3 commands
'identity provider' commands had functional tests but 'service
provider' commands did not. Added the tests in a similar way to
how it is done it test_idp.

Change-Id: Id4b24ef7d34db65c6b0260c89327ec9be683284d
2016-03-28 10:06:35 -04:00
Jenkins
d5596862b1 Merge "Refactor security group rule create to use SDK" 2016-03-28 09:16:23 +00:00
Rui Chen
e1e68809ae Add unit tests for compute v2 aggregate
This patch add the complete unit tests to cover compute v2
aggregate object.

Change-Id: Ifcf9248eabb5ca3ee5ca01c5843e96ba681c3b5a
Closes-Bug: #1560832
2016-03-26 18:43:46 +08:00
Jenkins
ef1faf7792 Merge "Subnet: Add "subnet set" command using SDK" 2016-03-25 15:47:15 +00:00
Rui Chen
4cbcd02a57 Add "aggregate unset" to osc
Support "aggregate unset" command in order to
remove the property of aggregate object in OSC.

Change-Id: I49645135586362f0fd251f5e4a4c03eff273d9e9
Closes-Bug: #1559866
2016-03-24 10:33:23 +08:00
reedip
2b95e363d3 Subnet: Add "subnet set" command using SDK
This patch adds "subnet set" command to osc using sdk.

Implements: blueprint neutron-client

Closes-bug: #1542363

Change-Id: Id3b7f4b9190b4d73ca3ae423321a65f94a6da62e
2016-03-24 02:21:40 +00:00
Tang Chen
860dbc132d [Floating IP] Neutron support for "ip floating create" command
This patch adds --subnet, --port, --floating-ip-address
and --fixed-ip-address options only. Project related options
will be added in another patch because it relates to identity
v2 and v3, which will make the unit tests too complicated in
one single patch.

Change-Id: I3cce4404a114ff128b74e4596f0e847be2846b17
Partial-Bug: 1519502
Related-to: blueprint neutron-client
2016-03-24 09:07:25 +08:00
Richard Theis
2109bce85a Support security group name for --src-group
Support security group name for the "--src-group" option on the
"os security group rule create" command.

Change-Id: Ic23d0671dad77566269c9a588644c8d774368733
Closes-Bug: #1540656
2016-03-23 10:05:08 -05:00
Richard Theis
d906507962 Refactor security group rule create to use SDK
Refactored the 'os security group rule create' command to use the
SDK when neutron is enabled, but continue to use the nova client
when nova network is enabled.

Added a release note for the change in security group rules output
due to Network v2.

Change-Id: I8c6c99d5272ff5d410a449f73d198d834c5cd96e
Partial-Bug: #1519512
Implements: blueprint neutron-client
2016-03-23 09:56:01 -05:00
Jenkins
4b4349ee68 Merge "Fix "server unset" document issue" 2016-03-23 13:35:49 +00:00
Tang Chen
3e0e1f8c41 Trivial: Fix typo in common/limits.py
Change-Id: I3040cc69512df50459960f96b862de55804068ac
2016-03-23 16:04:21 +08:00
Rui Chen
ee621509be Fix "server unset" document issue
Fix "--property" option describe issue in "server unset"
document, and update the help message to keep consistent.

Change-Id: I68022a187e83fad6320365400ad2a1b0c8cf9a61
2016-03-23 14:45:04 +08:00
Tang Chen
41853985bb Use assert_called_once_with() instead of assert_called_with()
If one API is only called once, we'd better use assert_called_once_with()
to check the call.

Change-Id: Id05055bb90592d218826732259ed84fc366734ce
2016-03-22 10:08:51 +08:00
reedip
9e42daa577 Add Subnet add/remove support to router
The following patch adds the support for
"router add subnet" and "router remove subnet"
to the OSC as a part of migration of Neutron's
CLI commands.

Partial-Bug: #1546849
Implements: blueprint neutron-client-advanced-router
Change-Id: Ia3770c41026194bdb1543d4e67446f81936d44d1
2016-03-22 01:55:19 +00:00
Jenkins
98dc781e94 Merge "Remove superfluous variable assignment statements" 2016-03-21 21:33:06 +00:00
Jenkins
a48de855d0 Merge "Improve error for token issue command without auth" 2016-03-21 21:20:48 +00:00
Jenkins
59ffee26a6 Merge "Image API v2: make volume_type optional" 2016-03-21 21:20:25 +00:00
Kyrylo Romanenko
526f2f9f77 Remove superfluous variable assignment statements
wait and interval are already defaulted in the function signature

Change-Id: I66317a24f8327c464343ac13fc0126c34915eeda
2016-03-21 19:32:11 +00:00
Kyrylo Romanenko
0a65e8df70 Style fix for one line docstring according to flake8
Change-Id: I639819a5b1d8a476cdd8b340b8c339754f471048
2016-03-21 18:32:44 +02:00
reedip
8ecdc57ea6 Add "router remove port" to osc
This patch proposes the migration of port
deletion of Neutron's "router-interface-delete"
to OSC's "router remove port".

Change-Id: Ifceabce080aacac9f6410c809fcc097760e0c5ee
Partial-Bug: #1546849
Implements: blueprint neutron-client-advanced-router
2016-03-21 02:08:16 +00:00
reedip
2e94f2803f Add "router add port" to osc
This patch proposes the migration of port addition of
Neutron's "router-interface-add" to OSC's "router add port".

Change-Id: I3a8a76d384caa32975f8e77f50f3cf3c3be13786
Closes-Bug: #1546849
Depends-On: I9783bc4ccceae3d361dce52d51483ef2187920a9
Implements: blueprint neutron-client-advanced-router
2016-03-21 02:07:21 +00:00
OpenStack Proposal Bot
236e74d46f Updated from global requirements
Change-Id: Icaa101bded765c81774d73d84d552d41e40fec72
2016-03-20 15:47:37 +00:00
Nicolas Simonds
1d1c7a0631 Image API v2: make volume_type optional
It is perfectly valid for a Cinder volume to have a volume_type of
"none", so don't make the Image API v2 require that one be set.

Change-Id: I1a6da8d791fa0ae67cac46eec81bcbcb420729c3
Closes-Bug: #1559344
2016-03-18 16:08:30 -07:00
timothy-symanczyk
15edb2f61a Improve error for token issue command without auth
Currently when you perform the 'token issue' command with
the admin_token, the error is a nonsense python error. This
commit changes it to be user-friendly.

Change-Id: I5cc92c342e3f83e099354cd04301c7b8d8d2dabc
Closes-Bug: #1547721
2016-03-18 15:44:02 -07:00
Jenkins
f9f6abe564 Merge "Fix keypair create --public-key" 2016-03-18 20:55:57 +00:00
Jenkins
ad3af0ef69 Merge "Functional tests for openstackclient help messages" 2016-03-18 20:20:05 +00:00
Richard Theis
91eeacd89e Devref: Document OSC interfaces available to plugins
This devref documents the OSC interfaces are officially available
for plugins to implement commands and related unit tests. It also
covers requirements for plugins.

Change-Id: I68caa188e389e400fa9f5fd38f32c76cdd3e0986
2016-03-18 13:23:10 -05:00
Dean Troyer
21e414d860 Fix keypair create --public-key
Commit Id702ccaad239b916340bb17014d1ede0a28aaec9 changed the keypair
create --public-key to use io.open but incorrectly reads the file
in binary mode, which causes JSON serialization to fail.

The unit tests mock out io.ioen (the reason for adding it in the first
place actually) so any testing for this specific problem would have to
be done in functional tests...yet to come.

Closes-bug: 1559125
Change-Id: I7a299a542d9df543bff43d3ea1e7907fc8c5f640
2016-03-18 17:48:36 +00:00
Kyrylo Romanenko
89182c4825 Functional tests for openstackclient help messages
Add tests for list and description for Server commands:
 - Check server commands in main help message.
 - Check list of server-related commands only.
Commands:
  server add security group,
  server add volume,
  server create,
  server delete,
  server dump create,
  server image create,
  server list,
  server lock,
  server migrate,
  server pause,
  server reboot,
  server rebuild,
  server remove security group,
  server remove volume,
  server rescue,
  server resize,
  server resume,
  server set,
  server shelve,
  server show,
  server ssh,
  server start,
  server stop,
  server suspend,
  server unlock,
  server unpause,
  server unrescue,
  server unset,
  server unshelve.

Change-Id: Ib4bf9ab0264fb482d36cf5688c0f939bcd2cb6d8
2016-03-18 18:28:24 +02:00
reedip
3ccc4f7d06 Trivial-Fix : Add a ' to the choices documentation
Change-Id: Ic2023e91602fa23512bc5cc9c6a395f2311adb1a
2016-03-18 06:25:31 +00:00
Jenkins
1f72384f69 Merge "update docs with status of plugins" 2016-03-18 01:38:45 +00:00