2704 Commits

Author SHA1 Message Date
Sindhu Devale
763c8c5670 "floating ip set/unset port" for OSC
Implements Neutron feature of floating ip associate/disassociate
into OpenStack Client.

Previously, network.find_ip() function only supported to
search floating ip by UUID. Hence, _find_floating_ip()
function is used in floating_ip.py, to search fip both by UUID
and ip_address. [1] adds the ability to find fip object using both UUID
and ip_address. This functionality however, won't be available until
the SDK is released. Hence, we continue to use _find_floating_ip()
method, which was cleaned up by [2] to remove the use of ip_cache.
Once, the SDK is released, we will remove all the usage of
_find_floating_ip() method and instead only use network.find_ip().

[1] https://review.openstack.org/#/c/449879/2
[2] https://review.openstack.org/#/c/447938/

Change-Id: I6c5222287c46ca42365917d2deae70bdb626347
Co-Authored-By: Reedip<reedip.banerjee@nectechnologies.in>
Co-Authored-By: RuiChen<chenrui.momo@gmail.com>
Closes-Bug: #1560297
2017-04-05 16:12:40 +00:00
Reedip
0e42ea3ae3 Structure FindFloatingIP() to work without ip_cache
Currently we have an ip_cache returned from _find_floating_ip() which
is generally ignored as it is not always required.

This patch removes the need of ip_cache in _find_floating_ip().

Co-Authored-By: Sindhu Devale<sindhu.devale@intel.com>

Change-Id: I8b92271185f82f275fa73adad03e9dad70be70e4
2017-04-04 16:27:24 +00:00
Jenkins
8a1f4b6592 Merge "Introduce neutron flavor associate, disassociate to OSC" 2017-04-04 02:38:59 +00:00
Jenkins
279066b67c Merge "Change noauth strategy for plugin loading" 2017-04-03 21:50:39 +00:00
Jenkins
d0f368ba0e Merge "Enable to add/remove port to/from a server" 2017-04-03 20:51:20 +00:00
Jenkins
e2cd971a03 Merge "Fix block-device-mapping when volume_size is empty" 2017-04-03 19:49:42 +00:00
Jenkins
6251d7d82a Merge "Add help commands withouth auth in functional" 2017-04-03 18:55:31 +00:00
Cedric Brandily
21510ac1a9 Enable to add/remove port to/from a server
This change enables to add/remove a specific port to/from a server using
the new commands:

 openstack server add port <vm> <port>
 openstack server remove port <vm> <port>

Closes-Bug: #1678137
Change-Id: I6ee57df089235ccc1fb9d38316bd484956b1134d
2017-04-03 20:19:40 +02:00
Shashank Kumar Shankar
b51310a4bb Introduce neutron flavor associate, disassociate to OSC
This patch introduces network flavor associate and disassociate to
OSC. The following neutron equivalent commands are implemented in OSC:

    - neutron flavor-associate
    - neutron flavor-disassociate

Change-Id: Icba4dbf7300a36353142586359059cd6784049dc
2017-04-03 17:02:03 +00:00
Rui Chen
341f07582e Add help commands withouth auth in functional
A special scenairo is that users want to check the commands
help message, but don't set authentication info at all. Add
a related functional test case to cover it.

Change-Id: I7b09701df24d6f6dfcf369f89212f72e753be6e4
2017-04-03 16:27:25 +00:00
Jens Rosenboom
61cde9c8e8 Fix block-device-mapping when volume_size is empty
The Nova API responds with an validation error when a bdm is submitted
containing an empty volume_size. So instead omit that attribute when it
is empty.

Change-Id: Iba905fca8c440a03e828c20922f3b813bba3fa3a
Closes-Bug: 1677236
2017-04-03 11:26:35 +00:00
Jenkins
67a4b812c6 Merge "doc: Correct Sphinx warnings" 2017-04-01 21:08:43 +00:00
Jenkins
6591154488 Merge "Remove log translations" 2017-03-31 04:22:31 +00:00
Jenkins
ca06a09d4d Merge "Fix volume transfers request commands" 2017-03-28 17:33:25 +00:00
Stephen Finucane
70170656fd doc: Correct Sphinx warnings
- Fix option-describe typos
- Correct option and envvar markup, for commands that are using the
  reference form instead of the definition form or are marking up
  option arguments as options
- Avoid duplicate commands
- Fix some invalid docstrings
- Fix some invalid indentation
- Disable the murano plugin, which has invalid docs
- Correct issues with- and track the network-topology spec
- Include API modules in docs

Change-Id: I3d5ed5e872540fe13f3e4bd5e9335829dc9a5226
2017-03-28 16:41:54 +01:00
Dean Troyer
1c3cb0a3b5 Change noauth strategy for plugin loading
Don't do it.

os-client-config's plugin loading has been causing this pain for a long
time, removing the KSC hack-around in o-c-c unmasked this again.  So when
auth is not reuired, just don't let o-c-c do any plugin loading at all.

Ever.

Of course, this shouldn't be in OSC either, but we have to do this until
the equivalent fix lands in osc-lib, is released and makes it into the
global requirements minimum version.

Depends-on: Ie68c82f7b073012685f0513b615ab1bf00bc0c3a
Change-Id: Ifdf65f3bb90fb923947a2cbe80a881d71a3fee56
2017-03-27 19:58:40 -05:00
Jenkins
dd81ca0692 Merge "Simplify logic around option lists in port set" 2017-03-27 17:33:23 +00:00
Dean Troyer
709eac73fb Fix volume transfers request commands
* Fix volume transfer request accept to actually not crash when
  trying to call Volume API.
* Fix volume transfer request accept syntax to have only one
  positional argument, which is the ID of the resource in the command
* Change the output column order in volume transfer request list to
  have ID followed by Name then the remaining columns.

Closes-bug: 1633582
Change-Id: I5cc005f039d171cc70859f60e7fe649b09ead229
2017-03-27 12:31:42 -05:00
Jenkins
2a64a64046 Merge "OSC Extension Show" 2017-03-23 20:30:15 +00:00
Sindhu Devale
832b2591cf OSC Extension Show
Implement Neutron feature of Extension Show into
OpenStack Client.

Change-Id: Ifecb794838cb3bf8c2466d178345349db3cd4003
Implements: blueprint extension-show
2017-03-22 16:39:19 +00:00
Jenkins
b5d707eb7b Merge "Support to add/remove multi users for "group add/remove user"" 2017-03-21 17:20:48 +00:00
yfzhao
535def3447 Remove log translations
Log messages are no longer being translated. This removes all use of
the _LE, _LI, and _LW translation markers to simplify logging and to
avoid confusion with new contributions.

Change-Id: I504de69b2e64250740ebcab432042a16f966fdbe
Closes-Bug: #1674584
2017-03-21 17:23:09 +08:00
Jenkins
2fdd4ff2f6 Merge "Fix Trivial Changes in [1]" 2017-03-21 08:29:27 +00:00
Jenkins
6329c04297 Merge "OSC Quota List" 2017-03-21 03:56:05 +00:00
Jenkins
efc570dae2 Merge "OSC Network Flavor Profile" 2017-03-21 03:32:47 +00:00
Reedip
8e2bc9cb9c Fix Trivial Changes in [1]
[1] had some trivial changes in the main code, which
are being put forward in this patch, to consider future scenarios.

[1]: I77a933f4b3ce875c63cef5b6a32aee78fd844b03

TrivialFix

Change-Id: I8e8fbb194cd319e5605f09c94ae09e952d0961b1
2017-03-21 02:43:24 +00:00
Huanxuan Ao
ef5a7caf85 Support to add/remove multi users for "group add/remove user"
Similar delete commands in OSC, we can also support add/remove
multi users for one specified group, this review implement it.

Change-Id: I8ccf99d4ee83a18778fa3ff5c0a42bc7c6ff21fb
Implements: bp support-multi-add-remove
2017-03-21 10:39:42 +08:00
Jenkins
49e866174f Merge "Enable to specify which vm fixed-ip to publish" 2017-03-21 01:55:51 +00:00
Jenkins
fe3bbf63a8 Merge "Jsonify meter and meter rule functional tests" 2017-03-21 01:50:17 +00:00
Dean Troyer
82a86d2d58 Simplify logic around option lists in port set
Use a common pattern to handle option pairs --XYZ and --no-XYZ for managing
lists of attributes. This pattern looks at the presence of the option
in parsed_args first and branches as necessary.

Some specific steps are included for the SDK Network resources to reliably
set the 'dirty' flag for changed attributes via one or both of the following:
* iterate over lists of original resource attributes to force the creation
  of a new list object
* use [].extend() rather than += to add to the existing list (substitute
  {}.update() for dicts)

Change-Id: I0c3f9a52ffe1ae2b5b230cb13d6376dd9131aaf9
2017-03-20 16:55:48 -05:00
Cedric Brandily
f5527877bb Enable to specify which vm fixed-ip to publish
This change enables to specify which vm fixed-ip will be associated to a
floating ip using:

 openstack server add floating ip <vm> <fip> --fixed-ip-address <ip>

Closes-Bug: #1624524
Change-Id: I2ddb68c5873bfed7293b0e661d1adbe111681136
2017-03-20 22:33:51 +01:00
Jenkins
3e621c9a9c Merge "Introduce Neutron DHCP agent commands to OSC" 2017-03-20 21:31:53 +00:00
Jenkins
f16513aaf2 Merge "Make MAC address of port updatable" 2017-03-20 20:53:22 +00:00
Shashank Kumar Shankar
f4fd8f6e31 Introduce Neutron DHCP agent commands to OSC
This patch introduces neutron dhcp-agent related commands to OpenStack
client.

The equivalent neutron commands implemented in OSC:

neutron: dhcp-agent-list-hosting-net
OSC: network agent list --network

neutron: dhcp-agent-network-add
OSC: network agent add network

neutron: dhcp-agent-network-remove
OSC: network agent remove network

neutron: net-list-on-dhcp-agent
OSC: network list --agent

Change-Id: I77a933f4b3ce875c63cef5b6a32aee78fd844b03
2017-03-20 15:02:09 -04:00
Jenkins
9a1efd41c8 Merge "Non-Admin can't list own projects" 2017-03-20 17:58:38 +00:00
Jenkins
97a4ac471a Merge "Add extra filtering options to qos policy list" 2017-03-20 17:58:32 +00:00
Jenkins
495d013431 Merge "Adds missing flavor information in the server list long command" 2017-03-20 17:57:38 +00:00
Nakul Dahiwade
7ef1e9ea96 OSC Network Flavor Profile
Implement Neutron feature of Network Flavor Profile
into OpenstackClient
This patch implements the following commands:
network flavor profile create
network flavor profile delete
network flavor profile list
network flavor profile show
network flavor profile set

SDK Version needed: 0.9.9

Change-Id: Ie6fe5e53122cfb2eda8d326851d54562739a8386
Partially-Implements: blueprint neutron-client-flavors
2017-03-20 16:24:27 +00:00
Bence Romsics
f1345dc06f Make MAC address of port updatable
openstackclient does not allow the update of a port's MAC address.
However this is possible in neutron API (though by default policy
it is an admin-only operation). Allow it in openstackclient too.

Change-Id: Ibd9e0a6fbd1d0d461b8a8daee24dbb7c3f929df6
Closes-Bug: #1670707
2017-03-20 15:40:48 +00:00
adrian-turjak
49f6032b69 Non-Admin can't list own projects
Due to a default Keystone policy until Newtown,
and the use of resource_find, non-admins are unable
to list their own projects.

This patch bypasses this problem while also introducing better
UX for non-admins wishing to get their project list.

'openstack project list' retains the default of 'list all projects'
but on a forbidden error will default instead to 'list my projects'.
This way for non-admins 'list my projects' feels like the default
without breaking the expected admin default.

Adding the '--my-projects' option allows admins to easily list their
own projects or allows non-admins to be explicit and bypass the
forbidden error fallback.

Change-Id: I1021276f69fbbf28e13e17c4e567d932fce7ed8b
Closes-Bug: #1627555
2017-03-20 14:40:56 +13:00
Jenkins
5490654788 Merge "Refactor ServerTests and ServerEventTests functional test classes" 2017-03-16 18:48:04 +00:00
Jenkins
6d33798252 Merge "Functional test for ip_availability" 2017-03-16 16:31:42 +00:00
Jenkins
6cae88fa2b Merge "Add a validation about options for server migrate command" 2017-03-16 15:52:50 +00:00
Jenkins
c1503492cd Merge "Fix "security group list" command to display project ID properly" 2017-03-16 13:02:17 +00:00
Jenkins
3d4750cdc8 Merge "Narrow expected responses for CheckUserInGroup" 2017-03-16 13:02:02 +00:00
Jenkins
9184e19288 Merge "Add sort support to project list" 2017-03-16 13:01:56 +00:00
Jenkins
66246561d8 Merge "Switch to use cleanup method in functional test" 2017-03-16 13:01:49 +00:00
Jenkins
b6f51cdfa0 Merge "Add the bgp agent type to network agent command" 2017-03-16 08:58:49 +00:00
Colleen Murphy
853ea5ab59 Narrow expected responses for CheckUserInGroup
When checking whether a given user is in a given group, keystone will
return a 404 Not Found if all went well but the user was not in the
group. It may also return a 403 if the user and the group are in
different backends, which would also mean that the user was not in the
group[1]. Any other 400 response is a client error and any 500 response
is a server error to which the user should be alerted.

Without this patch, openstackclient treats any exception as a valid "not
found" and may end up hiding server errors. This patch reduces the
caught exceptions to 403 and 404 responses and treats everything else as
an error.

[1] https://developer.openstack.org/api-ref/identity/v3/?expanded=check-whether-user-belongs-to-group-detail#check-whether-user-belongs-to-group

Closes-bug: #1672634

Change-Id: Id3f3b2409b7cee480ee3c19b6d6c3070599ffe8f
2017-03-14 09:23:19 +01:00
lvjiawei
9fd3dba11e Add extra filtering options to qos policy list
The patch adds filtering "--project", "--project-domain",
"--share", "--no-share" options to qos policy list.

Change-Id: I5c012fb27fb952f736ddc9fbc54ef6da4d0af5e0
Partially-Implements: blueprint network-commands-options
2017-03-14 13:04:47 +08:00