2512 Commits

Author SHA1 Message Date
Cedric Brandily
e2e9c49cd9 Correct addCleanup use in functests
This change replaces in many identity functests the pattern:

 raw_resource = create_resource(...)
 check(raw_resource)
 self.addCleanup(delete_resource, ...)
 ...

by the pattern:

 raw_resource = create_resource(...)
 self.addCleanup(delete_resource, ...)
 check(raw_resource)
 ...

which ensures that cleanup is defined and called after the test even if
check(resource) fails.

Change-Id: I4da541b7552d06eaffafda446e389bb552422cda
2016-04-06 20:43:21 +02:00
Cedric Brandily
3a8320a1d7 Support client certificate/key
This change enables to specify a client certificate/key with:
 * usual CLI options (--os-cert/--os-key)
 * usual environment variables ($OS_CERT/$OS_KEY)
 * os-client-config

Change-Id: Ibeaaa5897ae37b37c1e91f3e47076e4e8e4a8ded
Closes-Bug: #1565112
2016-04-06 20:21:19 +02:00
reedip
1b351e1695 Add provider network options to osc network create
The following patch adds the provider network options
to OSC "network create".

Change-Id: Ib8449c00ee4b4285889588f03ddd7a686ce8f987
Partial-Bug: #1545537
2016-04-06 16:52:47 +00:00
reedip
107bc5164f Add external network options to osc network create
The following patch adds the options "--external" & "--internal"
and the suboptions to "external": "--default" & "--no-default",
to "osc network create" CLI to provide the user an option to create
a network as an external network.

Change-Id: Idf73714bb94c0610ea164131140a51848908b00b
Partial-Bug: #1545537
2016-04-06 16:01:24 +00:00
Jenkins
81e37a2dce Merge "Improve tmpfile cleanup in functests" 2016-04-06 14:10:05 +00:00
Jenkins
492aa74fed Merge "Use fixtures and addCleanup instead of tearDown" 2016-04-06 14:05:18 +00:00
Jenkins
4307fe22dc Merge "Remove unused method cleanup_tmpfile" 2016-04-06 06:13:57 +00:00
Jenkins
05495d508c Merge "Fix typos in docstrings and comments" 2016-04-06 06:07:35 +00:00
Jenkins
b1b5a2acdd Merge "Add name option to 'port set'" 2016-04-06 06:02:06 +00:00
Dao Cong Tien
67a8947ea2 Fix typos in docstrings and comments
Change-Id: Ic2dc057dca87212f715970f8325956c42f62ea9f
2016-04-06 10:30:39 +07:00
Cedric Brandily
3c82c0e62e Improve tmpfile cleanup in functests
This change replaces when possible homemade temporary file management by
tempfile.NamedTemporaryFile[1][2] and defines only when needed a cleanup
for a temporary file[2].

[1] functional/tests/compute/v2/test_keypair.py
[2] functional/tests/object/v1/test_object.py

Change-Id: I728ab96381ca9f3fd1f899dd50e5ceb5e97b9397
2016-04-06 00:40:44 +02:00
Cedric Brandily
139a45bb71 Remove unused method cleanup_tmpfile
This change removes unused cleanup_tmpfile method from functests code.

Change-Id: I5d8e7edb0e50e94a5a469ce393d411b390b4db34
2016-04-06 00:40:44 +02:00
Cedric Brandily
bad21594be Use fixtures and addCleanup instead of tearDown
Nothing ensures tearDown call as tearDown is called only if test
succeeds. This change replaces tearDown use with:

* addCleanup use to stop mocks
* EnvFixture which ensures to unmock environment thanks to useFixture.

Change-Id: I1ff422e6a7585bc48b04b8f5c4cc1e7e9ddab1bc
2016-04-05 17:57:55 +02:00
Rui Chen
4d3f996e7c Log hint when --enable present with --disable-reason
--enable and --disable-reason should be mutually exclusive in "compute
service set" command, but now when they are present at the same time,
--disable-reason would be ignored silently. Fix these and add some hints
about --disable-reason argument is ignored in this situation.

Change-Id: I43254b6bc40fcae4fd0dc3457f26fad84c267072
Closes-Bug: #1556801
2016-04-05 21:22:27 +08:00
Tang Chen
c3f6ee9570 Trivial: Rename FakehypervisorStats to FakeHypervisorStats
Change-Id: I138b1b8a3327947b8cd032d8d0c32d98548ce2ad
2016-04-05 19:43:33 +08:00
reedip
66f94dca5c Add name option to 'port set'
Port's name can be updated in NeutronClient and it is a very
good feature for a user to have the ability to rename a port.
This was missing in the openstackclient, and the same has been
added in this patch.

Change-Id: I6e712ef08ab1c0a23786c4bb6972d3e0f8f0f999
Implements: blueprint neutron-client
2016-04-05 01:35:00 +00:00
Sean Dague
97492c168f rxtx factor should be a float
The rxtx factor on compute flavors is a float in the API. OSC is
currently blocking float values.

Change-Id: Ifa9c14825f388d2821ff4b63ab8ae83fa9c8d88b
2016-04-04 16:18:31 -04:00
Hidekazu Nakamura
55b37d5e33 Don't mask authorization errors
Project show with name argument returns 'Could not find resource'
error when the user is not authorized. It should report the
authorization error instead. This patch makes that change.

Change-Id: Iac3521f8a411060b0ec9ef46c8f0e1f3551e56ae
Closes-Bug: #1511625
2016-04-01 16:44:33 -04:00
Jenkins
061037aaf1 Merge "Add default value to pool-prefix in Subnet-pool" 2016-04-01 20:38:32 +00:00
reedip
7027d915b5 Add default value to pool-prefix in Subnet-pool
If user tries to create a subnet pool without --pool-prefix,
it fails at the NeutronServer [1].
This patch tries to add a default value to the --pool-prefix
to try and resolve it.

Closes-Bug: #1564271
[1] : http://paste.openstack.org/show/492537/

Change-Id: I6cf324a5a8037048602e59c0bbfc93b40e73a74e
2016-04-01 06:51:07 +00:00
Jenkins
6db4aa24ff Merge "Devref: Options with Multiple Values" 2016-04-01 06:01:38 +00:00
Jenkins
b4c3adbd30 Merge "Follow Boolean Option rule" 2016-04-01 03:31:06 +00:00
Richard Theis
8ba257cb30 Devref: Options with Multiple Values
Add a devref for options with multiple values.

Change-Id: Ic90c2317eb6c0445d234964c5243ecc689d5f4c7
2016-03-31 08:55:56 -05:00
Richard Theis
cd96d2966f Doc: Add missing command objects
Add missing command objects that have command documentation.

Change-Id: I2a34cc632c00c7f6bcf6481e6779b79093cd6488
2016-03-31 07:27:46 -05:00
Tang Chen
a1a470693e Add --project to "subnet pool create"
This patch adds --project and --project-domain
options to "subnet pool create" command.

Change-Id: I2fe006013a194861299a9c77234a7cf988a8dad8
Partial-Bug: #1544586
2016-03-31 12:31:02 +08:00
reedip
c5c15a0135 Follow Boolean Option rule
OSC has a specific rule for handling boolean based options
in  [1]. This patch modifies the exisiting code so that it
matches the criteria that have been specified in [1].

[1]: http://docs.openstack.org/developer/python-openstackclient/command-options.html#boolean-options

Closes-Bug: #1559418
Change-Id: I182381d5579efbc75a5d3e8a91f412398abf5c3c
2016-03-31 13:06:45 +09:00
Jenkins
f48f9398b8 Merge "Add fixed keypair create functional test" 2016-03-31 02:47:00 +00:00
Jenkins
f3b58238dd Merge "Add unit tests for compute v2 aggregate" 2016-03-30 23:23:57 +00:00
Jenkins
01b2a0c49f Merge "Add "aggregate unset" to osc" 2016-03-30 23:21:37 +00:00
Jenkins
a73926556f Merge "Fix subnet pool prefix length option" 2016-03-30 22:10:30 +00:00
Jenkins
e666a8ab74 Merge "Aggregate object should be "grouping of compute hosts"" 2016-03-30 21:41:30 +00:00
Dean Troyer
029654b9a8 Add fixed keypair create functional test
This adds a test case to exercise the --public-key option of
the 'keypair create' command.  It is a follow-on to
I7a299a542d9df543bff43d3ea1e7907fc8c5f640 that fixed a key file
read bug.

Change-Id: Id78c1c7ece02f619aca69dc397185fc426b92306
2016-03-30 15:58:42 -05:00
Richard Theis
9174bc0f02 Fix subnet pool prefix length option
Fix the --min-prefix-length, --max-prefix-length and
--default-prefix-length options for the "os subnet pool create" and
"os subnet pool set" commands. Using these options caused the
commands to fail with "HttpException: Bad Request" because unrecognized
attributes were passed to the REST API.

No release note was added since these commands are new and haven't
been released.

Change-Id: I2f765750f79dc91d6c1f5962f699fbf2ee38657a
Closes-Bug: #1564004
2016-03-30 13:28:31 -05:00
Sheel Rana
63c57eb56e Wrong param type in compute-service.rst
compute-service.rst file uses 'describe' for below
optional parameters

1. --long
2. --service <service>
3. --host <host>

This patchset changes type of these argument to option.

Change-Id: Ifd57bdf058efaeaa6cb43a7d4a60ee61ddb8de14
Closes-bug:#1563700
2016-03-30 14:45:41 +00:00
Jenkins
9e7f0cf1a5 Merge "Remove unused method 'from_response'" 2016-03-29 16:33:04 +00:00
Jenkins
8233b923f1 Merge "Docs cleanup: volume type" 2016-03-29 13:22:10 +00:00
Wenzhi Yu
848d5312ff Remove unused method 'from_response'
'openstackclient.common.exceptions.from_response' method is never called
in openstackclient code base, so we should remove it.

Change-Id: I04254a4e66863942e6c273d77bbd66ce2ce7804c
Related-Bug: #1559072
2016-03-29 17:28:24 +08:00
Rui Chen
b2e47b6228 Aggregate object should be "grouping of compute hosts"
The describe of Compute "aggregate" in command-objects and commands
documents use "a grouping of servers", but exactly that should be a
grouping of compute hosts. "server" object in OSC is a virtual machine
instance, and server group should be "grouping of servers".

Change-Id: Ib034fed15f11fc3e756985b3131a9922129ed6bf
Closes-Bug: #1563172
Related-Bug: #1542171
2016-03-29 12:01:31 +08:00
Jenkins
62a6a497bd Merge "Docs cleanup: volume command help" 2016-03-29 02:20:01 +00:00
Dean Troyer
a3a2a7e9f0 Docs cleanup: volume command help
This formats the volume command help text consistent with the rest of OSC,
adds some reference targets and some explanation text to some commands.

No functional changes have been made, only cosmetic/help output.

Change-Id: Ib86ec3ca58bdea5f33078ced3ec3583b2be0e89a
2016-03-28 18:25:58 -05:00
Jenkins
0a760e2d87 Merge "Added functional tests for 'service provider' v3 commands" 2016-03-28 20:54:59 +00:00
Dean Troyer
b4402a0468 Docs cleanup: volume type
Clean up volume type command help, add volume type show to doc, sort
command classes in v1/volume_type.py.

Change-Id: I1f8e5c047d9c08f5704fc23cfb694f23d32e3caf
2016-03-28 14:33:24 -05:00
Dean Troyer
9d65abcaa6 Docs cleanup: sort subnet commands
Change-Id: I43c0052ec5ed2e94b203a0befc4b39d3522d4e9c
2016-03-28 13:08:07 -05:00
Richard Theis
c5b58a47b0 Refactor security group rule list to use SDK
Refactored the 'os security group rule list' command to use the
SDK when neutron is enabled, but continue to use the nova client
when nova network is enabled.

In addition, a release note was added to document the features
and fixes resulting from this refactor.

Change-Id: I24d04b720102ed1c60776e1ca67d4ca20e31b663
Partial-Bug: #1519512
Implements: blueprint neutron-client
2016-03-28 12:25:51 -05:00
Jenkins
5f55e99d46 Merge "Support security group name for --src-group" 2016-03-28 15:57:31 +00:00
Kristi Nikolla
add0e10026 Added functional tests for 'service provider' v3 commands
'identity provider' commands had functional tests but 'service
provider' commands did not. Added the tests in a similar way to
how it is done it test_idp.

Change-Id: Id4b24ef7d34db65c6b0260c89327ec9be683284d
2016-03-28 10:06:35 -04:00
Jenkins
d5596862b1 Merge "Refactor security group rule create to use SDK" 2016-03-28 09:16:23 +00:00
Rui Chen
e1e68809ae Add unit tests for compute v2 aggregate
This patch add the complete unit tests to cover compute v2
aggregate object.

Change-Id: Ifcf9248eabb5ca3ee5ca01c5843e96ba681c3b5a
Closes-Bug: #1560832
2016-03-26 18:43:46 +08:00
Jenkins
ef1faf7792 Merge "Subnet: Add "subnet set" command using SDK" 2016-03-25 15:47:15 +00:00
Rui Chen
4cbcd02a57 Add "aggregate unset" to osc
Support "aggregate unset" command in order to
remove the property of aggregate object in OSC.

Change-Id: I49645135586362f0fd251f5e4a4c03eff273d9e9
Closes-Bug: #1559866
2016-03-24 10:33:23 +08:00