9b51127ecc
Some delete conmmands in volumev2 did not support error handling, this patch add them and also add the unit tests for bulk deletion Change-Id: I56ade6f9c7396c78fb989547476c4d94ccd76eae
389 lines
12 KiB
Python
389 lines
12 KiB
Python
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
|
|
import mock
|
|
from mock import call
|
|
|
|
from osc_lib import exceptions
|
|
from osc_lib import utils
|
|
|
|
from openstackclient.tests.volume.v2 import fakes as volume_fakes
|
|
from openstackclient.volume.v2 import backup
|
|
|
|
|
|
class TestBackup(volume_fakes.TestVolume):
|
|
|
|
def setUp(self):
|
|
super(TestBackup, self).setUp()
|
|
|
|
self.backups_mock = self.app.client_manager.volume.backups
|
|
self.backups_mock.reset_mock()
|
|
self.volumes_mock = self.app.client_manager.volume.volumes
|
|
self.volumes_mock.reset_mock()
|
|
self.snapshots_mock = self.app.client_manager.volume.volume_snapshots
|
|
self.snapshots_mock.reset_mock()
|
|
self.restores_mock = self.app.client_manager.volume.restores
|
|
self.restores_mock.reset_mock()
|
|
|
|
|
|
class TestBackupCreate(TestBackup):
|
|
|
|
volume = volume_fakes.FakeVolume.create_one_volume()
|
|
snapshot = volume_fakes.FakeSnapshot.create_one_snapshot()
|
|
new_backup = volume_fakes.FakeBackup.create_one_backup(
|
|
attrs={'volume_id': volume.id, 'snapshot_id': snapshot.id})
|
|
|
|
columns = (
|
|
'availability_zone',
|
|
'container',
|
|
'description',
|
|
'id',
|
|
'name',
|
|
'object_count',
|
|
'size',
|
|
'snapshot_id',
|
|
'status',
|
|
'volume_id',
|
|
)
|
|
data = (
|
|
new_backup.availability_zone,
|
|
new_backup.container,
|
|
new_backup.description,
|
|
new_backup.id,
|
|
new_backup.name,
|
|
new_backup.object_count,
|
|
new_backup.size,
|
|
new_backup.snapshot_id,
|
|
new_backup.status,
|
|
new_backup.volume_id,
|
|
)
|
|
|
|
def setUp(self):
|
|
super(TestBackupCreate, self).setUp()
|
|
|
|
self.volumes_mock.get.return_value = self.volume
|
|
self.snapshots_mock.get.return_value = self.snapshot
|
|
self.backups_mock.create.return_value = self.new_backup
|
|
|
|
# Get the command object to test
|
|
self.cmd = backup.CreateBackup(self.app, None)
|
|
|
|
def test_backup_create(self):
|
|
arglist = [
|
|
"--name", self.new_backup.name,
|
|
"--description", self.new_backup.description,
|
|
"--container", self.new_backup.container,
|
|
"--force",
|
|
"--incremental",
|
|
"--snapshot", self.new_backup.snapshot_id,
|
|
self.new_backup.volume_id,
|
|
]
|
|
verifylist = [
|
|
("name", self.new_backup.name),
|
|
("description", self.new_backup.description),
|
|
("container", self.new_backup.container),
|
|
("force", True),
|
|
("incremental", True),
|
|
("snapshot", self.new_backup.snapshot_id),
|
|
("volume", self.new_backup.volume_id),
|
|
]
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
|
|
columns, data = self.cmd.take_action(parsed_args)
|
|
|
|
self.backups_mock.create.assert_called_with(
|
|
self.new_backup.volume_id,
|
|
container=self.new_backup.container,
|
|
name=self.new_backup.name,
|
|
description=self.new_backup.description,
|
|
force=True,
|
|
incremental=True,
|
|
snapshot_id=self.new_backup.snapshot_id,
|
|
)
|
|
self.assertEqual(self.columns, columns)
|
|
self.assertEqual(self.data, data)
|
|
|
|
def test_backup_create_without_name(self):
|
|
arglist = [
|
|
"--description", self.new_backup.description,
|
|
"--container", self.new_backup.container,
|
|
self.new_backup.volume_id,
|
|
]
|
|
verifylist = [
|
|
("description", self.new_backup.description),
|
|
("container", self.new_backup.container),
|
|
("volume", self.new_backup.volume_id),
|
|
]
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
|
|
columns, data = self.cmd.take_action(parsed_args)
|
|
|
|
self.backups_mock.create.assert_called_with(
|
|
self.new_backup.volume_id,
|
|
container=self.new_backup.container,
|
|
name=None,
|
|
description=self.new_backup.description,
|
|
force=False,
|
|
incremental=False,
|
|
snapshot_id=None,
|
|
)
|
|
self.assertEqual(self.columns, columns)
|
|
self.assertEqual(self.data, data)
|
|
|
|
|
|
class TestBackupDelete(TestBackup):
|
|
|
|
backups = volume_fakes.FakeBackup.create_backups(count=2)
|
|
|
|
def setUp(self):
|
|
super(TestBackupDelete, self).setUp()
|
|
|
|
self.backups_mock.get = (
|
|
volume_fakes.FakeBackup.get_backups(self.backups))
|
|
self.backups_mock.delete.return_value = None
|
|
|
|
# Get the command object to mock
|
|
self.cmd = backup.DeleteBackup(self.app, None)
|
|
|
|
def test_backup_delete(self):
|
|
arglist = [
|
|
self.backups[0].id
|
|
]
|
|
verifylist = [
|
|
("backups", [self.backups[0].id])
|
|
]
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
|
|
result = self.cmd.take_action(parsed_args)
|
|
|
|
self.backups_mock.delete.assert_called_with(
|
|
self.backups[0].id, False)
|
|
self.assertIsNone(result)
|
|
|
|
def test_backup_delete_with_force(self):
|
|
arglist = [
|
|
'--force',
|
|
self.backups[0].id,
|
|
]
|
|
verifylist = [
|
|
('force', True),
|
|
("backups", [self.backups[0].id])
|
|
]
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
|
|
result = self.cmd.take_action(parsed_args)
|
|
|
|
self.backups_mock.delete.assert_called_with(self.backups[0].id, True)
|
|
self.assertIsNone(result)
|
|
|
|
def test_delete_multiple_backups(self):
|
|
arglist = []
|
|
for b in self.backups:
|
|
arglist.append(b.id)
|
|
verifylist = [
|
|
('backups', arglist),
|
|
]
|
|
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
result = self.cmd.take_action(parsed_args)
|
|
|
|
calls = []
|
|
for b in self.backups:
|
|
calls.append(call(b.id, False))
|
|
self.backups_mock.delete.assert_has_calls(calls)
|
|
self.assertIsNone(result)
|
|
|
|
def test_delete_multiple_backups_with_exception(self):
|
|
arglist = [
|
|
self.backups[0].id,
|
|
'unexist_backup',
|
|
]
|
|
verifylist = [
|
|
('backups', arglist),
|
|
]
|
|
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
|
|
find_mock_result = [self.backups[0], exceptions.CommandError]
|
|
with mock.patch.object(utils, 'find_resource',
|
|
side_effect=find_mock_result) as find_mock:
|
|
try:
|
|
self.cmd.take_action(parsed_args)
|
|
self.fail('CommandError should be raised.')
|
|
except exceptions.CommandError as e:
|
|
self.assertEqual('1 of 2 backups failed to delete.',
|
|
str(e))
|
|
|
|
find_mock.assert_any_call(self.backups_mock, self.backups[0].id)
|
|
find_mock.assert_any_call(self.backups_mock, 'unexist_backup')
|
|
|
|
self.assertEqual(2, find_mock.call_count)
|
|
self.backups_mock.delete.assert_called_once_with(
|
|
self.backups[0].id, False
|
|
)
|
|
|
|
|
|
class TestBackupList(TestBackup):
|
|
|
|
volume = volume_fakes.FakeVolume.create_one_volume()
|
|
backups = volume_fakes.FakeBackup.create_backups(
|
|
attrs={'volume_id': volume.name}, count=3)
|
|
|
|
columns = [
|
|
'ID',
|
|
'Name',
|
|
'Description',
|
|
'Status',
|
|
'Size',
|
|
]
|
|
columns_long = columns + [
|
|
'Availability Zone',
|
|
'Volume',
|
|
'Container',
|
|
]
|
|
|
|
data = []
|
|
for b in backups:
|
|
data.append((
|
|
b.id,
|
|
b.name,
|
|
b.description,
|
|
b.status,
|
|
b.size,
|
|
))
|
|
data_long = []
|
|
for b in backups:
|
|
data_long.append((
|
|
b.id,
|
|
b.name,
|
|
b.description,
|
|
b.status,
|
|
b.size,
|
|
b.availability_zone,
|
|
b.volume_id,
|
|
b.container,
|
|
))
|
|
|
|
def setUp(self):
|
|
super(TestBackupList, self).setUp()
|
|
|
|
self.volumes_mock.list.return_value = [self.volume]
|
|
self.backups_mock.list.return_value = self.backups
|
|
# Get the command to test
|
|
self.cmd = backup.ListBackup(self.app, None)
|
|
|
|
def test_backup_list_without_options(self):
|
|
arglist = []
|
|
verifylist = [("long", False)]
|
|
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
columns, data = self.cmd.take_action(parsed_args)
|
|
|
|
self.assertEqual(self.columns, columns)
|
|
self.assertEqual(self.data, list(data))
|
|
|
|
def test_backup_list_with_options(self):
|
|
arglist = ["--long"]
|
|
verifylist = [("long", True)]
|
|
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
columns, data = self.cmd.take_action(parsed_args)
|
|
|
|
self.assertEqual(self.columns_long, columns)
|
|
self.assertEqual(self.data_long, list(data))
|
|
|
|
|
|
class TestBackupRestore(TestBackup):
|
|
|
|
volume = volume_fakes.FakeVolume.create_one_volume()
|
|
backup = volume_fakes.FakeBackup.create_one_backup(
|
|
attrs={'volume_id': volume.id})
|
|
|
|
def setUp(self):
|
|
super(TestBackupRestore, self).setUp()
|
|
|
|
self.backups_mock.get.return_value = self.backup
|
|
self.volumes_mock.get.return_value = self.volume
|
|
self.restores_mock.restore.return_value = None
|
|
# Get the command object to mock
|
|
self.cmd = backup.RestoreBackup(self.app, None)
|
|
|
|
def test_backup_restore(self):
|
|
arglist = [
|
|
self.backup.id,
|
|
self.backup.volume_id
|
|
]
|
|
verifylist = [
|
|
("backup", self.backup.id),
|
|
("volume", self.backup.volume_id)
|
|
]
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
|
|
result = self.cmd.take_action(parsed_args)
|
|
self.restores_mock.restore.assert_called_with(self.backup.id,
|
|
self.backup.volume_id)
|
|
self.assertIsNone(result)
|
|
|
|
|
|
class TestBackupShow(TestBackup):
|
|
|
|
backup = volume_fakes.FakeBackup.create_one_backup()
|
|
|
|
columns = (
|
|
'availability_zone',
|
|
'container',
|
|
'description',
|
|
'id',
|
|
'name',
|
|
'object_count',
|
|
'size',
|
|
'snapshot_id',
|
|
'status',
|
|
'volume_id',
|
|
)
|
|
data = (
|
|
backup.availability_zone,
|
|
backup.container,
|
|
backup.description,
|
|
backup.id,
|
|
backup.name,
|
|
backup.object_count,
|
|
backup.size,
|
|
backup.snapshot_id,
|
|
backup.status,
|
|
backup.volume_id,
|
|
)
|
|
|
|
def setUp(self):
|
|
super(TestBackupShow, self).setUp()
|
|
|
|
self.backups_mock.get.return_value = self.backup
|
|
# Get the command object to test
|
|
self.cmd = backup.ShowBackup(self.app, None)
|
|
|
|
def test_backup_show(self):
|
|
arglist = [
|
|
self.backup.id
|
|
]
|
|
verifylist = [
|
|
("backup", self.backup.id)
|
|
]
|
|
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
|
|
|
|
columns, data = self.cmd.take_action(parsed_args)
|
|
self.backups_mock.get.assert_called_with(self.backup.id)
|
|
|
|
self.assertEqual(self.columns, columns)
|
|
self.assertEqual(self.data, data)
|