openstack/python-tackerclient
Code Issues Proposed changes

Merge "Fixes passing boolean as string for symmetrical"

Browse Source
This commit is contained in:
Jenkins 2017-09-27 02:13:51 +00:00 committed by Gerrit Code Review
commit 4458d3dce1
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tackerclient/tacker/v1_0/nfvo/vnffg.py
View File

@ -97,7 +97,9 @@ class CreateVNFFG(tackerV10.CreateCommand):
help=_('List of logical VNFD name to VNF instance name mapping. ' help=_('List of logical VNFD name to VNF instance name mapping. '
'Example: VNF1:my_vnf1,VNF2:my_vnf2')) 'Example: VNF1:my_vnf1,VNF2:my_vnf2'))
parser.add_argument( parser.add_argument(
'--symmetrical', metavar='{True,False}', '--symmetrical',
action='store_true',
default=False,
help=_('Should a reverse path be created for the NFP')) help=_('Should a reverse path be created for the NFP'))
parser.add_argument( parser.add_argument(
'--param-file', '--param-file',

7
tackerclient/tests/unit/vm/test_cli10_vnffg.py
View File

@ -44,9 +44,9 @@ class CLITestV10VmVNFFGJSON(test_cli10.CLITestV10Base):
vnffg_name, vnffg_name,
'--vnffgd-id', vnffgd_id, '--vnffgd-id', vnffgd_id,
'--vnf-mapping', vnf_mapping, '--vnf-mapping', vnf_mapping,
'--symmetrical', 'True'] '--symmetrical']
position_names = ['vnffgd_id', 'vnf_mapping', 'symmetrical'] position_names = ['vnffgd_id', 'vnf_mapping', 'symmetrical']
position_values = [vnffgd_id, {"VNFD1": "VNF1"}, 'True'] position_values = [vnffgd_id, {"VNFD1": "VNF1"}, True]
extra_body = {'name': vnffg_name, 'attributes': {}} extra_body = {'name': vnffg_name, 'attributes': {}}
self._test_create_resource(self._RESOURCE, cmd, None, my_id, self._test_create_resource(self._RESOURCE, cmd, None, my_id,
args, position_names, position_values, args, position_names, position_values,
@ -64,7 +64,8 @@ class CLITestV10VmVNFFGJSON(test_cli10.CLITestV10Base):
] ]
position_names = ['vnffgd_id'] position_names = ['vnffgd_id']
position_values = [vnffgd_id] position_values = [vnffgd_id]
extra_body = {'name': vnffg_name, 'attributes': {}} extra_body = {'symmetrical': False, 'name': vnffg_name,
'attributes': {}}
self._test_create_resource(self._RESOURCE, cmd, vnffg_name, my_id, self._test_create_resource(self._RESOURCE, cmd, vnffg_name, my_id,
args, position_names, position_values, args, position_names, position_values,
extra_body=extra_body, extra_body=extra_body,