openstack/python-zunclient
Code Issues Proposed changes

Rename option '--rm' to '--auto-remove'

Browse Source 
I think the new option name '--auto-remove' is self-explanatory.
Also, the name style is more consistent with other options (prefer
full name to acronym).

Change-Id: I5def24aa8f31b23ce6e3eea75d355bca29a553f4
This commit is contained in:
Hongbin Lu 2018-01-04 07:42:18 +00:00
parent 303b3f78eb
commit 597bdc11d9
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
zunclient/osc/v1/containers.py
View File

@ -145,7 +145,7 @@ class CreateContainer(command.ShowOne):
help='A dictionary to configure volumes mounted inside the '
'container.')
parser.add_argument(
'--rm',
'--auto-remove',
dest='auto_remove',
action='store_true',
default=False,
@ -700,7 +700,7 @@ class RunContainer(command.ShowOne):
help='A dictionary to configure volumes mounted inside the '
'container.')
parser.add_argument(
'--rm',
'--auto-remove',
dest='auto_remove',
action='store_true',
default=False,

8
zunclient/v1/containers_shell.py
View File

@ -49,7 +49,7 @@ def _show_container(container):
@utils.arg('--workdir',
metavar='<workdir>',
help='The working directory for commands to run in')
@utils.arg('--rm',
@utils.arg('--auto-remove',
action='store_true',
help='Automatically remove the container when it exits')
@utils.arg('--label',
@ -134,7 +134,7 @@ def do_create(cs, args):
opts['memory'] = args.memory
opts['cpu'] = args.cpu
opts['environment'] = zun_utils.format_args(args.environment)
opts['auto_remove'] = args.rm
opts['auto_remove'] = args.auto_remove
opts['workdir'] = args.workdir
opts['labels'] = zun_utils.format_args(args.label)
opts['image_pull_policy'] = args.image_pull_policy
@ -450,7 +450,7 @@ def do_kill(cs, args):
@utils.arg('--workdir',
metavar='<workdir>',
help='The working directory for commands to run in')
@utils.arg('--rm',
@utils.arg('--auto-remove',
action='store_true',
help='Automatically remove the container when it exits')
@utils.arg('--label',
@ -536,7 +536,7 @@ def do_run(cs, args):
opts['cpu'] = args.cpu
opts['environment'] = zun_utils.format_args(args.environment)
opts['workdir'] = args.workdir
opts['auto_remove'] = args.rm
opts['auto_remove'] = args.auto_remove
opts['labels'] = zun_utils.format_args(args.label)
opts['image_pull_policy'] = args.image_pull_policy
opts['image_driver'] = args.image_driver