openstack/requirements
Code Issues Proposed changes

be more explicit about the configuration being tested

Browse Source 
Show the directories being read and the SHA of the patch being tested.

Change-Id: Ifa73c15a4cb7d965a397753463fdd2df68ae4acf
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This commit is contained in:
Doug Hellmann 2018-04-10 11:17:44 -04:00
parent daeb71bfc8
commit 3375d70b1f
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
playbooks/files/project-requirements-change.py
View File

@ -96,12 +96,21 @@ def main():
if reqdir is None: if reqdir is None:
if args.local: if args.local:
print('selecting default requirements directory for local mode')
reqdir = os.path.dirname( reqdir = os.path.dirname(
os.path.dirname( os.path.dirname(
os.path.dirname(sys.argv[0]))) os.path.dirname(sys.argv[0])))
else: else:
print('selecting default requirements directory for normal mode')
reqdir = _DEFAULT_REQS_DIR reqdir = _DEFAULT_REQS_DIR
print('Branch: {}'.format(branch))
print('Source: {}'.format(args.src_dir))
print('Requirements: {}'.format(reqdir))
sha, _ = run_command('git log -n 1 --format=%H')
print('Patch under test: {}'.format(sha))
# build a list of requirements from the global list in the # build a list of requirements from the global list in the
# openstack/requirements project so we can match them to the changes # openstack/requirements project so we can match them to the changes
with tempdir() as reqroot: with tempdir() as reqroot:
@ -115,7 +124,7 @@ def main():
# build a list of requirements in the proposed change, # build a list of requirements in the proposed change,
# and check them for style violations while doing so # and check them for style violations while doing so
head_proj = project.read(cwd) head_proj = project.read(cwd)
head_reqs = check.RequirementsList('HEAD', head_proj) head_reqs = check.RequirementsList(sha, head_proj)
# Don't apply strict parsing rules to stable branches. # Don't apply strict parsing rules to stable branches.
# Reasoning is: # Reasoning is:
# - devstack etc protect us from functional issues # - devstack etc protect us from functional issues