From 53e13b08f1bb7ae6fdb5e5ef0fa0465a95798a01 Mon Sep 17 00:00:00 2001 From: Masayuki Igawa Date: Mon, 13 Feb 2017 17:09:51 +0900 Subject: [PATCH] Add flake8-import-order to global-requirements.txt This commit adds flake8-import-order to global-requirements.txt. With this library, we can check whether imports order is along with the hacking import order template[1] automatically. Of course, we can check import orders by manual. However it is not fun and we sometimes mistake. And we have H306 rule for checking import orders but it only checks alphabetic order not for stdlibs or not. [1] http://docs.openstack.org/developer/hacking/#import-order-template * Is the library actively maintained? Yes. This has been released constantly and maintained by Python Code Quality Authority. http://meta.pycqa.org/en/latest/management.html * Is the library good code? Yes. It's simple enough. * Is the library python 3 compatible? Yes. * Is the library license compatible? Yes, the library is licensed as MIT. * Is the library already packaged in the distros we target (Ubuntu latest / Fedora latest)? No. It's on pypi. * Is the function of this library already covered by other libraries in global-requirements.txt? No. * Is the library required for OpenStack project or related dev or infrastructure setup? Which? Tempest at this point: Iff75ebec42b295870edd1c04001adfb17460a682 Change-Id: Ia2140f5566ce169b076ffa5c9ebfbdbfc41e5bed --- blacklist.txt | 1 + global-requirements.txt | 1 + 2 files changed, 2 insertions(+) diff --git a/blacklist.txt b/blacklist.txt index 34f319068d..cb713d4c2f 100644 --- a/blacklist.txt +++ b/blacklist.txt @@ -2,6 +2,7 @@ # over time. flake8 flake8_docstrings +flake8-import-order hacking mccabe pep257 diff --git a/global-requirements.txt b/global-requirements.txt index 3ed1f820c2..e3386fe0c8 100644 --- a/global-requirements.txt +++ b/global-requirements.txt @@ -417,6 +417,7 @@ zake>=0.1.6 # Apache-2.0 # beyond this list would ever use a == flake8>=2.5.4,<2.6.0 # MIT flake8_docstrings==0.2.1.post1 # MIT +flake8-import-order==0.11 # LGPLv3 hacking>=0.12.0,!=0.13.0,<0.14 # Apache-2.0 mccabe==0.2.1 # MIT License pep257==0.7.0 # MIT License