openstack/requirements
Code Issues Proposed changes

Raise mock requirement to 2.0

Browse Source 
Mock now has assert_called and assert_called_once checks. We had
previously needed to watch out for these and replace them with
things like assertEqual(1, mocked.call_count) if a new patch
introduced them.

This was complicated by the fact that the gate has been using 2.0
for some time as it pulled the latest version, so it wouldn't catch
if there was an invalid call introduced. If a user was using a
previously installed version it would fail for them locally.

Rather than having conditional checks or needing to watch for these
incompatibilities in reviews, I propose we just make 2.0 the default.

Change-Id: If8cb4e476ad56d3ce6b01215fdaa2f3aa8a354c4
This commit is contained in:
Sean McGinnis 2016-05-24 13:07:37 -05:00
parent 78fefdd84a
commit 56a5e89e32
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
global-requirements.txt
View File

@ -313,7 +313,7 @@ ldappool>=2.0.0 # MPL
mimic>=2.0.0 # Apache-2.0
# Do not make mock conditional on Python version: we depend on newer code than
# in [most] releases of the Python std library.
mock>=1.2 # BSD
mock>=2.0 # BSD
mox>=0.5.3 # Apache-2.0
mox3>=0.7.0 # Apache-2.0
MySQL-python;python_version=='2.7' # GPL with FOSS exception